Add tab to accept suggestion settings

Author: intitni

Core/Sources/HostApp/FeatureSettings/SuggestionSettingsView.swift

@@ -1,6 +1,10 @@
 import Preferences
 import SwiftUI
 
+#if canImport(ProHostApp)
+import ProHostApp
+#endif
+
 struct SuggestionSettingsView: View {
     final class Settings: ObservableObject {
         @AppStorage(\.realtimeSuggestionToggle)
@@ -21,6 +25,8 @@ struct SuggestionSettingsView: View {
         var suggestionFeatureProvider
         @AppStorage(\.suggestionDisplayCompactMode)
         var suggestionDisplayCompactMode
+        @AppStorage(\.acceptSuggestionWithTab)
+        var acceptSuggestionWithTab
         init() {}
     }
 
@@ -58,8 +64,16 @@ struct SuggestionSettingsView: View {
                 }
 
                 Toggle(isOn: $settings.realtimeSuggestionToggle) {
-                    Text("Real-time suggestion")
+                    Text("Real-time Suggestion")
+                }
+
+                #if canImport(ProHostApp)
+                WithFeatureEnabled(\.tabToAcceptSuggestion) {
+                    Toggle(isOn: $settings.acceptSuggestionWithTab) {
+                        Text("Accept Suggestion with Tab")
+                    }
                 }
+                #endif
 
                 HStack {
                     Toggle(isOn: $settings.disableSuggestionFeatureGlobally) {
@@ -74,7 +88,7 @@ struct SuggestionSettingsView: View {
                         isOpen: $isSuggestionFeatureEnabledListPickerOpen
                     )
                 }
-                
+
                 HStack {
                     Button("Disabled Language List") {
                         isSuggestionFeatureDisabledLanguageListViewOpen = true
@@ -110,7 +124,7 @@ struct SuggestionSettingsView: View {
                 Toggle(isOn: $settings.suggestionDisplayCompactMode) {
                     Text("Hide Buttons")
                 }
-                
+
                 Toggle(isOn: $settings.hideCommonPrecedingSpacesInSuggestion) {
                     Text("Hide Common Preceding Spaces")
                 }

Pro

@@ -50,6 +50,8 @@ public final class ActiveApplicationMonitor {
         .init { continuation in
             let id = UUID()
             Task { @MainActor in
+                // not sure why,
+                // but we need to wrap the addContinuation in this task to make it not crash
                 continuation.onTermination = { _ in
                     self.removeContinuation(id: id)
                 }

Tool/Sources/ActiveApplicationMonitor/ActiveApplicationMonitor.swift

@@ -249,6 +249,10 @@ public extension UserDefaultPreferenceKeys {
     var realtimeSuggestionDebounce: PreferenceKey<Double> {
         .init(defaultValue: 0, key: "RealtimeSuggestionDebounce")
     }
+    
+    var acceptSuggestionWithTab: PreferenceKey<Bool> {
+        .init(defaultValue: false, key: "AcceptSuggestionWithTab")
+    }
 }
 
 // MARK: - Chat