Add throttler to RealtimeSuggestionController

Author: intitni

Core/Sources/Service/RealtimeSuggestionController.swift

@@ -31,12 +31,12 @@ public actor RealtimeSuggestionController {
 
     private func observeXcodeChange() {
         cancellable.forEach { $0.cancel() }
-        
+
         XcodeInspector.shared.$focusedEditor
             .sink { [weak self] editor in
                 guard let self else { return }
                 Task {
-                    guard let editor  else { return }
+                    guard let editor else { return }
                     await self.handleFocusElementChange(editor)
                 }
             }.store(in: &cancellable)
@@ -51,7 +51,7 @@ public actor RealtimeSuggestionController {
         }
 
         self.sourceEditor = sourceEditor
-        
+
         let notificationsFromEditor = sourceEditor.axNotifications
 
         editorObservationTask?.cancel()
@@ -65,25 +65,54 @@ public actor RealtimeSuggestionController {
                 )
             }
 
-            for await notification in notificationsFromEditor {
-                guard let self else { return }
-                try Task.checkCancellation()
-
-                switch notification.kind {
-                case .valueChanged:
-                    await cancelInFlightTasks()
-                    await self.triggerPrefetchDebounced()
-                    await self.notifyEditingFileChange(editor: sourceEditor.element)
-                case .selectedTextChanged:
-                    guard let fileURL = XcodeInspector.shared.activeDocumentURL
-                    else { break }
-                    await PseudoCommandHandler().invalidateRealtimeSuggestionsIfNeeded(
-                        fileURL: fileURL,
-                        sourceEditor: sourceEditor
-                    )
-                default:
-                    break
+            let valueChange = notificationsFromEditor.filter { $0.kind == .valueChanged }
+            let selectedTextChanged = notificationsFromEditor
+                .filter { $0.kind == .selectedTextChanged }
+
+            await withTaskGroup(of: Void.self) { [weak self] group in
+                group.addTask { [weak self] in
+                    let handler = { [weak self] in
+                        guard let self else { return }
+                        await cancelInFlightTasks()
+                        await self.triggerPrefetchDebounced()
+                        await self.notifyEditingFileChange(editor: sourceEditor.element)
+                    }
+
+                    if #available(macOS 13.0, *) {
+                        for await _ in valueChange.throttle(for: .milliseconds(200)) {
+                            if Task.isCancelled { return }
+                            await handler()
+                        }
+                    } else {
+                        for await _ in valueChange {
+                            if Task.isCancelled { return }
+                            await handler()
+                        }
+                    }
                 }
+                group.addTask {
+                    let handler = {
+                        guard let fileURL = XcodeInspector.shared.activeDocumentURL else { return }
+                        await PseudoCommandHandler().invalidateRealtimeSuggestionsIfNeeded(
+                            fileURL: fileURL,
+                            sourceEditor: sourceEditor
+                        )
+                    }
+
+                    if #available(macOS 13.0, *) {
+                        for await _ in selectedTextChanged.throttle(for: .milliseconds(200)) {
+                            if Task.isCancelled { return }
+                            await handler()
+                        }
+                    } else {
+                        for await _ in selectedTextChanged {
+                            if Task.isCancelled { return }
+                            await handler()
+                        }
+                    }
+                }
+
+                await group.waitForAll()
             }
         }
 
@@ -94,7 +123,7 @@ public actor RealtimeSuggestionController {
                 .fetchOrCreateWorkspaceAndFilespace(fileURL: fileURL)
 
             if filespace.codeMetadata.uti == nil {
-                Logger.service.info("Generate cache for file.") 
+                Logger.service.info("Generate cache for file.")
                 // avoid the command get called twice
                 filespace.codeMetadata.uti = ""
                 do {
@@ -111,10 +140,11 @@ public actor RealtimeSuggestionController {
 
     func triggerPrefetchDebounced(force: Bool = false) {
         inflightPrefetchTask = Task(priority: .utility) { @WorkspaceActor in
-            try? await Task.sleep(nanoseconds: UInt64((
+            try? await Task.sleep(nanoseconds: UInt64(
                 max(UserDefaults.shared.value(for: \.realtimeSuggestionDebounce), 0.15)
-            ) * 1_000_000_000))
-            
+                    * 1_000_000_000
+            ))
+
             if Task.isCancelled { return }
 
             guard UserDefaults.shared.value(for: \.realtimeSuggestionToggle)

Tool/Sources/XcodeInspector/SourceEditor.swift

@@ -9,12 +9,16 @@ import SuggestionModel
 public class SourceEditor {
     public typealias Content = EditorInformation.SourceEditorContent
 
-    public struct AXNotification {
+    public struct AXNotification: Hashable {
         public var kind: AXNotificationKind
         public var element: AXUIElement
+        
+        public func hash(into hasher: inout Hasher) {
+            kind.hash(into: &hasher)
+        }
     }
 
-    public enum AXNotificationKind {
+    public enum AXNotificationKind: Hashable, Equatable {
         case selectedTextChanged
         case valueChanged
         case scrollPositionChanged