Allow all file types to have a filespace

Author: intitni

Tool/Sources/Workspace/Filespace.swift

@@ -76,6 +76,9 @@ public final class Filespace {
     public let fileURL: URL
     public private(set) lazy var language: CodeLanguage = languageIdentifierFromFileURL(fileURL)
     public var codeMetadata: FilespaceCodeMetadata = .init()
+    public var isTextReadable: Bool {
+        fileURL.pathExtension != "mlmodel"
+    }
 
     // MARK: Suggestions
 

Tool/Sources/Workspace/WorkspacePool.swift

@@ -88,11 +88,6 @@ public class WorkspacePool {
     public func fetchOrCreateWorkspaceAndFilespace(fileURL: URL) async throws
         -> (workspace: Workspace, filespace: Filespace)
     {
-        let ignoreFileExtensions = ["mlmodel"]
-        if ignoreFileExtensions.contains(fileURL.pathExtension) {
-            throw Workspace.UnsupportedFileError(extensionName: fileURL.pathExtension)
-        }
-
         // If we can get the workspace URL directly.
         if let currentWorkspaceURL = await XcodeInspector.shared.safe.realtimeActiveWorkspaceURL {
             if let existed = workspaces[currentWorkspaceURL] {

Tool/Sources/WorkspaceSuggestionService/SuggestionWorkspacePlugin.swift

@@ -96,6 +96,7 @@ public final class SuggestionServiceWorkspacePlugin: WorkspacePlugin {
 
     public func notifyOpenFile(filespace: Filespace) {
         Task {
+            guard filespace.isTextReadable else { return }
             guard !(await filespace.isGitIgnored) else { return }
             // check if file size is larger than 15MB, if so, return immediately
             if let attrs = try? FileManager.default
@@ -113,6 +114,7 @@ public final class SuggestionServiceWorkspacePlugin: WorkspacePlugin {
 
     public func notifyUpdateFile(filespace: Filespace, content: String) {
         Task {
+            guard filespace.isTextReadable else { return }
             guard !(await filespace.isGitIgnored) else { return }
             try await suggestionService?.notifyChangeTextDocument(
                 fileURL: filespace.fileURL,
@@ -123,6 +125,7 @@ public final class SuggestionServiceWorkspacePlugin: WorkspacePlugin {
 
     public func notifySaveFile(filespace: Filespace) {
         Task {
+            guard filespace.isTextReadable else { return }
             guard !(await filespace.isGitIgnored) else { return }
             try await suggestionService?.notifySaveTextDocument(fileURL: filespace.fileURL)
         }