Add support to store api keys in user defaults

Author: intitni

Core/Sources/HostApp/DebugView.swift

@@ -14,6 +14,7 @@ final class DebugSettings: ObservableObject {
     @AppStorage(\.disableFunctionCalling) var disableFunctionCalling
     @AppStorage(\.disableGitHubCopilotSettingsAutoRefreshOnAppear)
     var disableGitHubCopilotSettingsAutoRefreshOnAppear
+    @AppStorage(\.useUserDefaultsBaseAPIKeychain) var useUserDefaultsBaseAPIKeychain
     init() {}
 }
 
@@ -41,17 +42,22 @@ struct DebugSettingsView: View {
                 Toggle(isOn: $settings.triggerActionWithAccessibilityAPI) {
                     Text("Trigger command with AccessibilityAPI")
                 }
-                Toggle(isOn: $settings.alwaysAcceptSuggestionWithAccessibilityAPI) {
-                    Text("Always accept suggestion with Accessibility API")
-                }
-                Toggle(isOn: $settings.enableXcodeInspectorDebugMenu) {
-                    Text("Enable Xcode inspector debug menu")
-                }
-                Toggle(isOn: $settings.disableFunctionCalling) {
-                    Text("Disable function calling for chat feature")
-                }
-                Toggle(isOn: $settings.disableGitHubCopilotSettingsAutoRefreshOnAppear) {
-                    Text("Disable GitHub Copilot settings auto refresh status on appear")
+                Group {
+                    Toggle(isOn: $settings.alwaysAcceptSuggestionWithAccessibilityAPI) {
+                        Text("Always accept suggestion with Accessibility API")
+                    }
+                    Toggle(isOn: $settings.enableXcodeInspectorDebugMenu) {
+                        Text("Enable Xcode inspector debug menu")
+                    }
+                    Toggle(isOn: $settings.disableFunctionCalling) {
+                        Text("Disable function calling for chat feature")
+                    }
+                    Toggle(isOn: $settings.disableGitHubCopilotSettingsAutoRefreshOnAppear) {
+                        Text("Disable GitHub Copilot settings auto refresh status on appear")
+                    }
+                    Toggle(isOn: $settings.useUserDefaultsBaseAPIKeychain) {
+                        Text("Store API keys in UserDefaults")
+                    }
                 }
             }
             .padding()

Tool/Sources/Keychain/Keychain.swift

@@ -1,5 +1,6 @@
 import Configs
 import Foundation
+import Preferences
 import Security
 
 public protocol KeychainType {
@@ -31,13 +32,48 @@ public final class FakeKeyChain: KeychainType {
     }
 }
 
+public final class UserDefaultsBaseAPIKeychain: KeychainType {
+    let defaults = UserDefaults.shared
+    let scope: String
+    var key: String {
+        "UserDefaultsBaseAPIKeychain-\(scope)"
+    }
+    
+    init(scope: String) {
+        self.scope = scope
+    }
+    
+    public func getAll() throws -> [String : String] {
+        defaults.dictionary(forKey: key) as? [String: String] ?? [:]
+    }
+    
+    public func update(_ value: String, key: String) throws {
+        var dict = try getAll()
+        dict[key] = value
+        defaults.set(dict, forKey: self.key)
+    }
+    
+    public func get(_ key: String) throws -> String? {
+        try getAll()[key]
+    }
+    
+    public func remove(_ key: String) throws {
+        var dict = try getAll()
+        dict[key] = nil
+        defaults.set(dict, forKey: self.key)
+    }
+}
+
 public struct Keychain: KeychainType {
     let service = keychainService
     let accessGroup = keychainAccessGroup
     let scope: String
 
-    public static var apiKey: Keychain {
-        Keychain(scope: "apiKey")
+    public static var apiKey: KeychainType {
+        if UserDefaults.shared.value(for: \.useUserDefaultsBaseAPIKeychain) {
+            return UserDefaultsBaseAPIKeychain(scope: "apiKey")
+        }
+        return Keychain(scope: "apiKey")
     }
 
     public enum Error: Swift.Error {

Tool/Sources/Preferences/Keys.swift

@@ -213,7 +213,7 @@ public extension UserDefaultPreferenceKeys {
                     supportsFunctionCalling: true,
                     modelName: ChatGPTModel.gpt35Turbo.rawValue
                 )
-            )
+            ),
         ], key: "ChatModels")
     }
 
@@ -245,7 +245,7 @@ public extension UserDefaultPreferenceKeys {
                     maxTokens: OpenAIEmbeddingModel.textEmbeddingAda002.maxToken,
                     modelName: OpenAIEmbeddingModel.textEmbeddingAda002.rawValue
                 )
-            )
+            ),
         ], key: "EmbeddingModels")
     }
 }
@@ -320,15 +320,15 @@ public extension UserDefaultPreferenceKeys {
     var chatFeatureProvider: DeprecatedPreferenceKey<ChatFeatureProvider> {
         .init(defaultValue: .openAI, key: "ChatFeatureProvider")
     }
-    
+
     var defaultChatFeatureChatModelId: PreferenceKey<String> {
         .init(defaultValue: "", key: "DefaultChatFeatureChatModelId")
     }
 
     var embeddingFeatureProvider: DeprecatedPreferenceKey<EmbeddingFeatureProvider> {
         .init(defaultValue: .openAI, key: "EmbeddingFeatureProvider")
     }
-    
+
     var defaultChatFeatureEmbeddingModelId: PreferenceKey<String> {
         .init(defaultValue: "", key: "DefaultChatFeatureEmbeddingModelId")
     }
@@ -481,6 +481,10 @@ public extension UserDefaultPreferenceKeys {
         .init(defaultValue: false, key: "FeatureFlag-DisableFunctionCalling")
     }
 
+    var useUserDefaultsBaseAPIKeychain: FeatureFlag {
+        .init(defaultValue: false, key: "FeatureFlag-UseUserDefaultsBaseAPIKeychain")
+    }
+
     var disableGitHubCopilotSettingsAutoRefreshOnAppear: FeatureFlag {
         .init(
             defaultValue: false,