forked from CopilotKit/CopilotKit
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathresolve-verify-matrix.ts
More file actions
449 lines (420 loc) · 18 KB
/
Copy pathresolve-verify-matrix.ts
File metadata and controls
449 lines (420 loc) · 18 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
/**
* resolve-verify-matrix.ts — decide which staging services the
* post-redeploy verify probe should target.
*
* Replaces the inline bash+jq block in showcase_deploy.yml's
* `resolve-matrix` job ("Build verify matrix from SSOT" step). The bash
* had produced two confirmed bugs across prior CR rounds, so the logic
* was extracted into a pure, unit-testable TypeScript function.
*
* Decision table — `resolveVerifyMatrix` returns `{servicesCsv, hasServices}`:
*
* workflow_dispatch + service='all'/empty
* → full probe-eligible set (every SSOT service with probe.staging===true),
* sorted+dedup'd. has_services=true.
*
* workflow_dispatch + specific service (SSOT key OR dispatchName)
* → just that one canonical name. Unknown service → throws (CLI wrapper
* exits non-zero with `::error::` annotation, matching prior bash).
*
* workflow_run + summary_present='false'
* → has_services=false, services_csv=''. Nothing was redeployed (build
* legitimately had no buildable changes); skip verify.
*
* workflow_run + summary_present='true' + ok_services empty
* → has_services=false, services_csv=''. ALL services errored on
* redeploy → the success-set is empty → nothing left to verify.
* `enforce-redeploy-gate` independently reds the workflow on
* redeploy_red=true, so this case is already loud. The PRIOR bash
* fell through to the full probe-eligible fleet here, gratuitously
* probing every service against stale `:latest`; that was the
* "Issue A" bug this module fixes.
*
* workflow_run + summary_present='true' + ok_services non-empty
* → intersect ok_services with probe-eligible SSOT services. The
* ok_services CSV may carry SSOT keys OR dispatchName aliases;
* both spellings resolve to the canonical name. Result is sorted,
* dedup'd, CSV-joined. has_services=(csv non-empty).
*
* Testability: the pure function takes `ssotServices` as a parameter so
* tests run without filesystem IO. The CLI wrapper at the bottom reads
* env vars, loads `railway-envs.generated.json` (regenerating via
* emit-railway-envs-json.ts if missing — preserves the fallback the
* old bash had), and writes `services_csv=` / `has_services=` lines to
* $GITHUB_OUTPUT.
*/
import { execFileSync } from "node:child_process";
import { appendFileSync, existsSync, readFileSync } from "node:fs";
import { fileURLToPath } from "node:url";
export interface SsotService {
name: string;
dispatchName: string | null;
probe: { staging: boolean };
}
/** Accepted github.event_name values for this resolver. */
export type SupportedEventName = "workflow_run" | "workflow_dispatch";
export interface ResolveVerifyMatrixInput {
/** github.event_name — 'workflow_run' or 'workflow_dispatch'. */
eventName: SupportedEventName;
/** 'true' / 'false' / '' — the upstream `check-redeploy-summary` step output. */
summaryPresent: string;
/** CSV of services that redeployed OK (from `redeploy-gate.outputs.ok_services`). */
okFromRedeploy: string;
/** github.event.inputs.service — 'all', '', or an SSOT key / dispatchName. */
dispatchService: string;
/** The `services` array from railway-envs.generated.json. */
ssotServices: SsotService[];
}
export interface ResolveVerifyMatrixOutput {
servicesCsv: string;
hasServices: boolean;
}
/** Sorted, dedup'd list of every SSOT service with probe.staging===true. */
function probeEligibleNames(ssotServices: SsotService[]): string[] {
// Shape is guaranteed by parseSsotServices (every service has a `probe`
// object with a boolean `staging`), so no defensive optional chain.
const names = ssotServices
.filter((s) => s.probe.staging === true)
.map((s) => s.name);
return Array.from(new Set(names)).sort();
}
/**
* Map an `ok_services` CSV (which may carry SSOT keys OR dispatchName
* aliases — the build matrix sometimes emits dispatch_names) into the
* set of canonical SSOT names.
*
* Tokens are .trim()'d before lookup so a future change to the
* redeploy-gate bash (or a human-typed workflow_dispatch caller) that
* emits "a, b" with spaces does not silently drop tokens. Unmatched
* tokens are returned in `dropped` so the CLI wrapper can surface them
* via `::warning::` — a silent drop here is the exact SSOT/build drift
* smell that the boundary hardening is supposed to detect. Empty tokens
* (trailing comma, double comma) are filtered before matching and are
* NOT reported as dropped (they carry no signal).
*/
export interface OkCsvResult {
canonical: Set<string>;
dropped: string[];
}
export function okCsvToCanonicalNames(
okFromRedeploy: string,
ssotServices: SsotService[],
): OkCsvResult {
const canonical = new Set<string>();
const dropped: string[] = [];
const tokens = okFromRedeploy
.split(",")
.map((t) => t.trim())
.filter((t) => t.length > 0);
for (const t of tokens) {
const match = ssotServices.find(
(s) => s.name === t || s.dispatchName === t,
);
if (match) {
canonical.add(match.name);
} else {
dropped.push(t);
}
}
return { canonical, dropped };
}
export function resolveVerifyMatrix(
input: ResolveVerifyMatrixInput,
): ResolveVerifyMatrixOutput {
const {
eventName,
summaryPresent,
okFromRedeploy,
dispatchService,
ssotServices,
} = input;
// Fail loud on unrecognized eventName. Today only `workflow_run` and
// `workflow_dispatch` reach this resolver (showcase_deploy.yml's `on:`
// block is closed to those two). Any other value here means either a
// typo in the wrapper's env wiring or a new trigger that hasn't been
// explicitly handled — the prior fall-through to the workflow_run
// intersection branch silently emitted has_services=false for both,
// indistinguishable from a legit "no summary, nothing to verify" skip.
//
// The CLI wrapper narrows EVENT_NAME via `asSupportedEventName` before
// calling here, so on the CLI path this guard is defense-in-depth.
// Direct test callers (which build their own input object) still pay
// the runtime check, which is the point.
if (eventName !== "workflow_run" && eventName !== "workflow_dispatch") {
throw new Error(
`::error::resolve-verify-matrix: unexpected eventName '${eventName}' (expected 'workflow_run' or 'workflow_dispatch')`,
);
}
// Make the workflow_run boundary total. `check-redeploy-summary`
// always sets `summary_present` to exactly "true" or "false"; any other
// value here (including "" from a future step-id-rename wiring break,
// or "True" from a case-typo) means the wiring is broken upstream, NOT
// a legitimate skip. Without this guard, an empty/garbage summaryPresent
// falls through to the workflow_run intersection branch — which silently
// emits has_services=false on what may be a real redeploy. Throw instead
// so enforce-redeploy-gate (which fans in on resolve-matrix.result ==
// 'failure') reds the workflow.
// workflow_dispatch ignores summaryPresent and must NOT trip this guard.
if (
eventName === "workflow_run" &&
summaryPresent !== "true" &&
summaryPresent !== "false"
) {
throw new Error(
`::error::resolve-verify-matrix: workflow_run requires summary_present in {true,false}, got '${summaryPresent}'`,
);
}
// Case: workflow_run + nothing redeployed — the build legitimately
// didn't redeploy anything (no buildable service changed). Skip verify.
if (eventName === "workflow_run" && summaryPresent === "false") {
return { servicesCsv: "", hasServices: false };
}
// Case: workflow_run + redeploy summary PRESENT + empty ok_services
// (every service errored on redeploy). The success-set is empty, so
// there is nothing to verify. `enforce-redeploy-gate` already reds
// the workflow on redeploy_red=true; this matrix simply skips. This
// is the "Issue A" fix: the old bash fell through to the full
// probe-eligible fleet here.
if (
eventName === "workflow_run" &&
summaryPresent === "true" &&
okFromRedeploy.length === 0
) {
return { servicesCsv: "", hasServices: false };
}
const probeEligible = probeEligibleNames(ssotServices);
// workflow_dispatch: resolve the dispatch input first. If 'all' / empty,
// fall through to the full probe-eligible set. Otherwise resolve to
// the chosen service (by SSOT name OR dispatchName).
if (eventName === "workflow_dispatch") {
const dispatch = dispatchService || "all";
if (dispatch !== "all") {
const resolved = ssotServices.find(
(s) => s.name === dispatch || s.dispatchName === dispatch,
);
if (!resolved) {
// Preserves prior bash behavior: `::error::Unknown service...` +
// exit 1. The CLI wrapper converts this throw into a non-zero
// exit with the same annotation.
throw new Error(
`::error::Unknown service '${dispatch}' (not an SSOT key or dispatch_name)`,
);
}
const csv = resolved.name;
return { servicesCsv: csv, hasServices: csv.length > 0 };
}
const csv = probeEligible.join(",");
return { servicesCsv: csv, hasServices: csv.length > 0 };
}
// workflow_run + summary present + ok non-empty: intersect ok with
// probe-eligible. Map ok-tokens to canonical names first (handles the
// dispatchName-alias case). Drop anything not in probe-eligible (e.g.
// a service that redeployed OK but has no probe driver).
const { canonical: okCanonical } = okCsvToCanonicalNames(
okFromRedeploy,
ssotServices,
);
const intersection = probeEligible.filter((n) => okCanonical.has(n));
const csv = intersection.join(",");
return { servicesCsv: csv, hasServices: csv.length > 0 };
}
// ---------------------------------------------------------------------------
// CLI wrapper — guarded by import.meta.url check so tests can import the
// pure function without triggering env reads or filesystem IO.
// ---------------------------------------------------------------------------
const SSOT_JSON = "showcase/scripts/railway-envs.generated.json";
const EMIT_SCRIPT = "showcase/scripts/emit-railway-envs-json.ts";
/**
* Validate the parsed SSOT JSON shape. Two distinct failure modes to
* guard against:
* - SCHEMA DRIFT (e.g. someone renamed `probe.staging`): the JSON
* parses fine but silently empties the probe-eligible set, which
* the resolver would otherwise propagate as a false-green skip.
* - TRUNCATION (emitter crashed mid-write): either fails `JSON.parse`
* outright (loud) or — if the truncation happened to land on a
* valid-JSON boundary — leaves an empty `services` array, caught
* here by the non-empty check.
* We require the exact shape we depend on, and `::error::`-prefix the
* throw so the workflow log surfaces it as an annotation.
*/
export function parseSsotServices(raw: unknown, path: string): SsotService[] {
if (raw === null || typeof raw !== "object") {
throw new Error(
`::error::SSOT ${path} malformed: top-level value is not an object`,
);
}
const services = (raw as { services?: unknown }).services;
if (!Array.isArray(services)) {
throw new Error(
`::error::SSOT ${path} malformed: \`services\` is not an array`,
);
}
if (services.length === 0) {
throw new Error(
`::error::SSOT ${path} malformed: \`services\` is empty (emitter crashed mid-write or schema drift?)`,
);
}
const validated: SsotService[] = [];
for (let i = 0; i < services.length; i++) {
const s = services[i];
if (s === null || typeof s !== "object") {
throw new Error(
`::error::SSOT ${path} malformed: services[${i}] is not an object`,
);
}
const obj = s as {
name?: unknown;
dispatchName?: unknown;
probe?: unknown;
};
if (typeof obj.name !== "string" || obj.name.length === 0) {
throw new Error(
`::error::SSOT ${path} malformed: services[${i}] missing \`name\` (or not a non-empty string)`,
);
}
// dispatchName is OPTIONAL in the live SSOT (e.g. `pocketbase` has
// no dispatchName field — it is not a CI-built service). Accept
// missing OR null OR string; normalize to null internally.
if (
obj.dispatchName !== undefined &&
obj.dispatchName !== null &&
typeof obj.dispatchName !== "string"
) {
throw new Error(
`::error::SSOT ${path} malformed: services[${i}] (${obj.name}) \`dispatchName\` must be string, null, or absent`,
);
}
if (obj.probe === null || typeof obj.probe !== "object") {
throw new Error(
`::error::SSOT ${path} malformed: services[${i}] (${obj.name}) missing \`probe\` object`,
);
}
const probe = obj.probe as { staging?: unknown };
if (typeof probe.staging !== "boolean") {
throw new Error(
`::error::SSOT ${path} malformed: services[${i}] (${obj.name}) \`probe.staging\` is not boolean`,
);
}
validated.push({
name: obj.name,
dispatchName:
typeof obj.dispatchName === "string" ? obj.dispatchName : null,
probe: { staging: probe.staging },
});
}
return validated;
}
function loadSsotServices(): SsotService[] {
// Preserve the prior bash behavior: regenerate the JSON if it's missing
// (e.g. a freshly-checked-out workspace that hasn't run the emitter).
if (!existsSync(SSOT_JSON)) {
execFileSync("npx", ["tsx", EMIT_SCRIPT], { stdio: "inherit" });
}
// Re-check existence after the regen attempt: if the emitter exits 0
// without writing (transient race, broken IO, mis-configured cwd), the
// pre-fix code would JSON.parse a ReadFile-against-missing-path error
// and fail with a useless stack. Fail loud instead.
if (!existsSync(SSOT_JSON)) {
throw new Error(
`::error::SSOT ${SSOT_JSON} still missing after regenerate attempt (${EMIT_SCRIPT} exited 0 without writing?)`,
);
}
const raw: unknown = JSON.parse(readFileSync(SSOT_JSON, "utf-8"));
return parseSsotServices(raw, SSOT_JSON);
}
function requireEnv(name: string): string {
const v = process.env[name];
if (typeof v !== "string") {
throw new Error(`resolve-verify-matrix: $${name} is required`);
}
return v;
}
/**
* Narrow a raw env-string EVENT_NAME into the resolver's literal union.
* Replaces the prior `as 'workflow_run' | 'workflow_dispatch'` unchecked
* cast — the type system and runtime now tell the same story. The
* resolver itself ALSO guards eventName, but doing the narrowing here
* means the CLI path fails loud at the boundary with a wrapper-specific
* `::error::` annotation (EVENT_NAME, not eventName) before the resolver
* is even called.
*/
function asSupportedEventName(s: string): SupportedEventName {
if (s !== "workflow_run" && s !== "workflow_dispatch") {
throw new Error(
`::error::resolve-verify-matrix: unexpected EVENT_NAME '${s}' (expected 'workflow_run' or 'workflow_dispatch')`,
);
}
return s;
}
function writeGithubOutput(
githubOutput: string,
servicesCsv: string,
hasServices: boolean,
): void {
// Plain key=value lines (no heredoc): both values are simple strings
// without newlines. Matches the style of the prior bash and aligns
// with the rest of resolve-matrix's $GITHUB_OUTPUT writes.
appendFileSync(githubOutput, `services_csv=${servicesCsv}\n`);
appendFileSync(
githubOutput,
`has_services=${hasServices ? "true" : "false"}\n`,
);
}
function main(): void {
const githubOutput = requireEnv("GITHUB_OUTPUT");
const eventNameRaw = requireEnv("EVENT_NAME");
const summaryPresent = process.env.SUMMARY_PRESENT ?? "";
const okFromRedeploy = process.env.OK_FROM_REDEPLOY ?? "";
const dispatchService = process.env.DISPATCH_SERVICE ?? "";
try {
// Narrow the raw env-string to the resolver's literal union. Replaces
// the prior unchecked `as` cast — the narrowing helper throws on
// unexpected EVENT_NAME with a wrapper-specific `::error::`
// annotation, so the type system and runtime tell the same story.
// The resolver's internal eventName guard becomes defense-in-depth
// for direct (test) callers that construct input objects by hand.
const eventName: SupportedEventName = asSupportedEventName(eventNameRaw);
const ssotServices = loadSsotServices();
// Surface SSOT/build drift via ::warning:: when an ok_services token
// matches no SSOT service. The resolver-level intersection already
// drops the token; without this log, the operator never learns that
// a redeploy reported success for a service the SSOT has forgotten
// about (or vice versa). Keep this in the wrapper (not the pure
// function) so the resolver stays IO-free.
const okPreview = okCsvToCanonicalNames(okFromRedeploy, ssotServices);
if (okPreview.dropped.length > 0) {
process.stderr.write(
`::warning::ok_services tokens dropped (no SSOT match): ${okPreview.dropped.join(",")}\n`,
);
}
const { servicesCsv, hasServices } = resolveVerifyMatrix({
eventName,
summaryPresent,
okFromRedeploy,
dispatchService,
ssotServices,
});
writeGithubOutput(githubOutput, servicesCsv, hasServices);
} catch (e) {
// Mirror the prior bash: print `::error::...` to stderr and exit 1.
// Throws from this module already carry the `::error::` annotation
// (Unknown service, unexpected eventName, SSOT malformed, SSOT
// missing-after-regen).
process.stderr.write(`${e instanceof Error ? e.message : String(e)}\n`);
process.exit(1);
}
}
// Detect "this module is the entrypoint" — used to gate the CLI bottom
// half so tests can `import` the pure resolver without triggering env
// reads or filesystem IO. Intentionally NO try/catch: an ESM-interop
// failure here (e.g. `fileURLToPath` rejects `import.meta.url`) used to
// silently return false → CLI no-ops → $GITHUB_OUTPUT never written →
// downstream `verify:` step skips (false-green). Let it crash loud
// instead; the workflow surfaces the stack and the gate stays honest.
const invokedDirectly =
typeof process !== "undefined" &&
Array.isArray(process.argv) &&
process.argv[1] === fileURLToPath(import.meta.url);
if (invokedDirectly) {
main();
}