fix(showcase): fix pre-existing test failures from smoke-red-tick deletion and e2e-deep timeout

The rename PR (CopilotKit#4388) deleted smoke-red-tick.yml from config/alerts/
and test/fixtures/rules/valid/ but left 16 tests referencing it:

- render-red-tick.test.ts: removed smoke-red-tick.yml from YAMLS array
  and deleted two smoke-specific tests (endpoint link rendering)
- rule-loader.test.ts: replaced smoke-red-tick.yml fixture references
  with agent-red-tick.yml; created matching valid fixture; removed the
  smoke-red-tick describe block from full YAML contract coverage
- e2e-deep.test.ts: increased timeout on failure_turn test from 5s to
  15s -- fillAndVerifySend retry loop (3 x 2s) exceeds 5s when
  stallEvaluate prevents user message count growth

Author: jpr5

showcase/harness/src/alerts/render-red-tick.test.ts

@@ -55,7 +55,6 @@ function ctx(partial: Partial<TemplateContext>): TemplateContext {
 }
 
 const YAMLS = [
-  "smoke-red-tick.yml",
   "agent-red-tick.yml",
   "chat-red-tick.yml",
   "tools-red-tick.yml",
@@ -116,36 +115,6 @@ describe("red-tick YAML rendering — Items 2 & 3", () => {
     });
   });
 
-  // Smoke has the only dimension with `signal.links.*` references — verify
-  // the present-link path emits the expected Slack-link shape after the guard
-  // wrap.
-  it("smoke: renders_link_when_present — <url|label> shape preserved", () => {
-    const text = loadTemplate("smoke-red-tick.yml");
-    const r = createRenderer();
-    const flags = { ...emptyTriggerFlags(), green_to_red: true };
-    const out = r.render(
-      { text },
-      ctx({
-        trigger: flags,
-        signal: {
-          slug: "mastra",
-          failCount: 1,
-          errorDesc: "http 503",
-          firstFailureAt: "2026-04-20T00:00:00Z",
-          url: "https://example.test/smoke",
-        },
-      }),
-    );
-    const rendered = String(out.payload.text);
-    // A3: smoke template now references `signal.url` directly (driver signal
-    // has no `links` object). Render label "endpoint" since the linked URL is
-    // the smoke endpoint that was actually probed.
-    expect(rendered).toContain("<https://example.test/smoke|endpoint>");
-    // Guard-wrap must not introduce empty/dangling artifacts even with links
-    // present.
-    expect(rendered).not.toMatch(/<\|/);
-  });
-
   // A2: the dashboard Run link must be wrapped in a `{{#event.runId}}…{{/event.runId}}`
   // section so a missing runId doesn't render a broken `/runs/|Run` link every
   // alert. Parametrize across all 4 red-tick YAMLs.
@@ -197,29 +166,4 @@ describe("red-tick YAML rendering — Items 2 & 3", () => {
     });
   });
 
-  // A3: the smoke template historically referenced `signal.links.smoke` /
-  // `signal.links.health` — the DRIVER signal (probes/drivers/liveness.ts) has
-  // `slug, url, status, errorDesc, latencyMs` and no `links` object, so those
-  // section-guards were always empty. The template should pull `signal.url`
-  // directly and render an "endpoint" link.
-  it("smoke: renders_endpoint_link_from_signal_url (A3)", () => {
-    const text = loadTemplate("smoke-red-tick.yml");
-    const r = createRenderer();
-    const flags = { ...emptyTriggerFlags(), green_to_red: true };
-    const out = r.render(
-      { text },
-      ctx({
-        trigger: flags,
-        signal: {
-          slug: "mastra",
-          failCount: 1,
-          errorDesc: "http 503",
-          firstFailureAt: "2026-04-20T00:00:00Z",
-          url: "https://starter.example/smoke",
-        },
-      }),
-    );
-    const rendered = String(out.payload.text);
-    expect(rendered).toContain("<https://starter.example/smoke|endpoint>");
-  });
 });

showcase/harness/src/probes/drivers/e2e-deep.test.ts

@@ -336,7 +336,12 @@ describe("e2e-deep driver", () => {
     expect(fsig.failure_turn).toBe(1);
     expect(fsig.errorClass).toBe("conversation-error");
     expect(fsig.errorDesc).toMatch(/timeout/i);
-  });
+    // Timeout budget: fillAndVerifySend retries up to
+    // SEND_VERIFY_MAX_ATTEMPTS (3) × (SEND_VERIFY_INITIAL_DELAY_MS +
+    // remaining poll window) ≈ 6s when stallEvaluate prevents the user
+    // message count from growing, plus the 200ms responseTimeoutMs
+    // deadline. 15s absorbs CI variance without masking real hangs.
+  }, 15_000);
 
   it("emits red with goto-error when navigation fails", async () => {
     registerD5Script(

showcase/harness/src/rules/rule-loader.test.ts

@@ -14,15 +14,15 @@ const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const FIXTURES = path.resolve(__dirname, "../../test/fixtures/rules");
 
 describe("rule-loader: valid fixtures", () => {
-  it("loads smoke-red-tick.yml with merged defaults + escalation + guards", async () => {
+  it("loads agent-red-tick.yml with merged defaults + escalation + guards", async () => {
     const loader = createRuleLoader({
       dir: path.join(FIXTURES, "valid"),
       logger,
     });
     const rules = await loader.load();
     expect(rules).toHaveLength(1);
     const r = rules[0]!;
-    expect(r.id).toBe("smoke-red-tick");
+    expect(r.id).toBe("agent-red-tick");
     expect(r.severity).toBe("warn");
     expect(r.stringTriggers).toEqual([
       "green_to_red",
@@ -579,8 +579,8 @@ describe("rule-loader: invalid fixtures (skipped, not fatal)", () => {
       path.join(tmp, "_defaults.yml"),
     );
     await fs.copyFile(
-      path.join(FIXTURES, "valid", "smoke-red-tick.yml"),
-      path.join(tmp, "smoke-red-tick.yml"),
+      path.join(FIXTURES, "valid", "agent-red-tick.yml"),
+      path.join(tmp, "agent-red-tick.yml"),
     );
     // Drop a broken file alongside.
     await fs.copyFile(
@@ -590,7 +590,7 @@ describe("rule-loader: invalid fixtures (skipped, not fatal)", () => {
     const loader = createRuleLoader({ dir: tmp, logger });
     const { rules, errors } = await loader.loadWithErrors();
     expect(rules).toHaveLength(1);
-    expect(rules[0]!.id).toBe("smoke-red-tick");
+    expect(rules[0]!.id).toBe("agent-red-tick");
     expect(errors).toHaveLength(1);
     expect(errors[0]!.file).toBe("missing-id.yml");
   });
@@ -612,16 +612,16 @@ describe("rule-loader: reload error propagation", () => {
       path.join(tmp, "_defaults.yml"),
     );
     await fs.copyFile(
-      path.join(FIXTURES, "valid", "smoke-red-tick.yml"),
-      path.join(tmp, "smoke-red-tick.yml"),
+      path.join(FIXTURES, "valid", "agent-red-tick.yml"),
+      path.join(tmp, "agent-red-tick.yml"),
     );
     await fs.copyFile(
       path.join(FIXTURES, "invalid", "missing-id.yml"),
       path.join(tmp, "missing-id.yml"),
     );
     const loader = createRuleLoader({ dir: tmp, logger });
     const { rules, errors } = await loader.loadWithErrors();
-    expect(rules.map((r) => r.id)).toEqual(["smoke-red-tick"]);
+    expect(rules.map((r) => r.id)).toEqual(["agent-red-tick"]);
     expect(errors.map((e) => e.file)).toEqual(["missing-id.yml"]);
   });
 
@@ -1418,108 +1418,6 @@ describe("rule-loader + renderer: full YAML contract coverage", () => {
     });
   });
 
-  // ---- smoke-red-tick.yml -------------------------------------------
-  describe("smoke-red-tick", () => {
-    it("green_to_red branch renders slug, errorDesc and endpoint link", async () => {
-      const { rules, errors, renderer } = await loadRealRules();
-      expect(
-        errors.find((e) => e.file.startsWith("smoke-red-tick")),
-      ).toBeUndefined();
-      const rule = rules.find((r) => r.id === "smoke-red-tick");
-      expect(rule).toBeDefined();
-      expect(rule!.stringTriggers).toEqual([
-        "green_to_red",
-        "sustained_red",
-        "red_to_green",
-      ]);
-      const ctx = makeCtx(
-        rule!,
-        {
-          slug: "coagents-starter",
-          errorDesc: "http 503",
-          // A3: driver signal carries `url` (endpoint that was probed)
-          // instead of a `links` object — the template now renders a single
-          // endpoint link rather than separate smoke/health pair.
-          url: "https://svc.example/smoke",
-          failCount: 1,
-        },
-        { trigger: { green_to_red: true, isRedTick: true } },
-      );
-      const text = (
-        renderer.render({ text: rule!.template!.text }, ctx).payload as {
-          text: string;
-        }
-      ).text;
-      expect(text).toContain("coagents-starter");
-      expect(text).toContain("down, error: http 503");
-      // Triple-brace signal.url (marked slackSafe in LIVENESS_SLACK_SAFE_FIELDS)
-      // preserves the raw URL inside `<URL|label>` Slack link markup; prior
-      // double-brace would HTML-escape `/` → `&#x2F;` and break the link at
-      // Slack render time.
-      expect(text).toContain("<https://svc.example/smoke|endpoint>");
-    });
-
-    it("sustained_red branch renders failCount (attempt: N) and error", async () => {
-      const { rules, renderer } = await loadRealRules();
-      const rule = rules.find((r) => r.id === "smoke-red-tick")!;
-      const ctx = makeCtx(
-        rule,
-        {
-          slug: "mastra-starter",
-          errorDesc: "timeout after 15000ms",
-          // A3: endpoint URL lives under `signal.url` now.
-          url: "https://m.example/smoke",
-          failCount: 3,
-        },
-        { trigger: { sustained_red: true, isRedTick: true } },
-      );
-      const text = (
-        renderer.render({ text: rule.template!.text }, ctx).payload as {
-          text: string;
-        }
-      ).text;
-      expect(text).toContain("mastra-starter");
-      expect(text).toContain("attempt: 3");
-      expect(text).toContain("timeout after 15000ms");
-    });
-
-    it("red_to_green branch renders recovery + firstFailureAt", async () => {
-      const { rules, renderer } = await loadRealRules();
-      const rule = rules.find((r) => r.id === "smoke-red-tick")!;
-      const ctx = makeCtx(
-        rule,
-        {
-          slug: "langgraph-starter",
-          firstFailureAt: "2026-04-19T23:00:00Z",
-        },
-        { trigger: { red_to_green: true } },
-      );
-      const text = (
-        renderer.render({ text: rule.template!.text }, ctx).payload as {
-          text: string;
-        }
-      ).text;
-      expect(text).toContain("langgraph-starter");
-      expect(text).toContain("recovered");
-      expect(text).toContain("was down since 2026-04-19T23:00:00Z");
-    });
-
-    it("fleet rule owns <!channel> escalation (migrated from per-service red-tick)", async () => {
-      // Plan Item 4: <!channel> moved off smoke-red-tick onto smoke-red-fleet.
-      // The per-service rule still fires per-match via its own targets; the
-      // fleet rule is the single pager for cross-service outages. Per-service
-      // red-tick template must NOT contain <!channel>; fleet rule template
-      // MUST. Both invariants asserted together so a future refactor can't
-      // silently drop one without the other surfacing.
-      const { rules } = await loadRealRules();
-      const perService = rules.find((r) => r.id === "smoke-red-tick")!;
-      const fleet = rules.find((r) => r.id === "smoke-red-fleet")!;
-      expect(perService.template!.text).not.toContain("<!channel>");
-      expect(fleet.aggregation).toBeDefined();
-      expect(fleet.aggregation!.template).toContain("<!channel>");
-    });
-  });
-
   // ---- deploy-result.yml (remaining branches R20 didn't cover) ------
   describe("deploy-result (R20 follow-up branches)", () => {
     it("green_to_red partial branch renders failed/succeeded lists", async () => {
@@ -1680,8 +1578,8 @@ describe("rule-loader: initial load emits rules.reload.failed on errors (R24 buc
       path.join(tmp, "_defaults.yml"),
     );
     await fs.copyFile(
-      path.join(FIXTURES, "valid", "smoke-red-tick.yml"),
-      path.join(tmp, "smoke-red-tick.yml"),
+      path.join(FIXTURES, "valid", "agent-red-tick.yml"),
+      path.join(tmp, "agent-red-tick.yml"),
     );
     // One malformed rule (missing id, fails schema).
     await fs.copyFile(
@@ -1707,7 +1605,7 @@ describe("rule-loader: initial load emits rules.reload.failed on errors (R24 buc
 
     // Good rule still loads.
     expect(rules).toHaveLength(1);
-    expect(rules[0]!.id).toBe("smoke-red-tick");
+    expect(rules[0]!.id).toBe("agent-red-tick");
     // Bad rule surfaces via errors.
     expect(errors).toHaveLength(1);
     expect(errors[0]!.file).toBe("missing-id.yml");

showcase/harness/test/fixtures/rules/valid/agent-red-tick.yml

@@ -0,0 +1,36 @@
+id: agent-red-tick
+name: "Starter agent reachability failing"
+owner: "@oss"
+
+signal:
+  dimension: agent
+
+triggers:
+  - green_to_red
+  - sustained_red
+  - red_to_green
+
+conditions:
+  escalations:
+    - whenFailCount: 4
+      mention: "!channel"
+      severity: critical
+  guards:
+    - minDeployAgeMin: 20
+  rate_limit:
+    perKey: "{{signal.slug}}:{{triggerName}}"
+    window: 15m
+  suppress:
+    when: 'trigger == "sustained_red" && lastAlertAgeMin < 15'
+
+targets:
+  - kind: slack_webhook
+    webhook: oss_alerts
+
+template:
+  text: |
+    {{#trigger.green_to_red}}:red_circle: *{{signal.slug}}* — agent unreachable, error: {{signal.errorDesc}}{{/trigger.green_to_red}}
+    {{#trigger.sustained_red}}:red_circle: *{{signal.slug}}* — agent attempt: {{signal.failCount}}, error: {{signal.errorDesc}}{{/trigger.sustained_red}}
+    {{#trigger.red_to_green}}:white_check_mark: *{{signal.slug}}* agent recovered (was down since {{signal.firstFailureAt}}){{/trigger.red_to_green}}
+
+    <{{env.dashboardUrl}}|Showcase>{{#event.runId}} · <{{env.dashboardUrl}}/runs/{{event.runId}}|Run>{{/event.runId}}