Skip to content

Commit 0761801

Browse files
authored
fix(showcase/dashboard): add maxPossible to parity-matrix DepthResult literals (CopilotKit#4662)
## Summary - Two object literals in `showcase/shell-dashboard/src/components/parity-matrix.tsx` (`ParityCategorySection`) were missing the required `maxPossible` field on `DepthResult`, causing `next build` to fail with TS2322 on every shell-dashboard production build. - This blocked rebuilding the deployed showcase shell-dashboard, which currently ships with `NEXT_PUBLIC_SHELL_URL` unset — every Demo button on the dashboard renders as `about:blank#shell-url-missing/integrations/<slug>/<feature>/preview` instead of the actual preview URL. - Setting `maxPossible: 0` alongside `achieved: 0` for unwired cells is the natural fallback (no probe → no ceiling) and matches how `DepthChip` already renders an unshipped cell. ## Background The fix is cherry-picked from commit `1db2fbc7b` on the `fix/dashboard-polish` branch (Jordan Ritter) — that branch also has 8 other commits (D5 depth model rework, ops→harness rename) which together form a larger polish pass that hasn't been opened as a PR yet. Landing this 2-line slice standalone unblocks the showcase deploy without waiting on review of the larger branch. Once this lands, re-running `gh workflow run showcase_build.yml --ref main -f service=shell-dashboard` will produce a working production image with `NEXT_PUBLIC_SHELL_URL=https://showcase.copilotkit.ai` baked in. ## Test plan - [ ] CI typecheck passes (was previously failing here) - [ ] CI build of showcase-shell-dashboard image succeeds - [ ] After merge: trigger \`showcase_build.yml\` for \`shell-dashboard\` and verify deployed dashboard's Demo links resolve to \`https://showcase.copilotkit.ai/integrations/...\` instead of the \`about:blank#shell-url-missing\` sentinel
2 parents 3066629 + 8bc2e53 commit 0761801

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

showcase/shell-dashboard/src/components/parity-matrix.tsx

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,12 @@ function ParityCategorySection({
115115
const refCell = cellIndex.get(`${referenceSlug}/${feature.id}`);
116116
const refDepth: DepthResult = refCell
117117
? deriveDepth(refCell, liveStatus)
118-
: { achieved: 0, isRegression: false, unsupported: false };
118+
: {
119+
achieved: 0,
120+
maxPossible: 0,
121+
isRegression: false,
122+
unsupported: false,
123+
};
119124
const refStatus = refDepth.unsupported
120125
? "unsupported"
121126
: (refCell?.status ?? "unshipped");
@@ -141,7 +146,12 @@ function ParityCategorySection({
141146
const cell = cellIndex.get(`${int.slug}/${feature.id}`);
142147
const depth: DepthResult = cell
143148
? deriveDepth(cell, liveStatus)
144-
: { achieved: 0, isRegression: false, unsupported: false };
149+
: {
150+
achieved: 0,
151+
maxPossible: 0,
152+
isRegression: false,
153+
unsupported: false,
154+
};
145155
const cellStatus = depth.unsupported
146156
? "unsupported"
147157
: (cell?.status ?? "unshipped");

0 commit comments

Comments
 (0)