Skip to content

Commit 265c156

Browse files
committed
chore(showcase/langgraph-python): Phase 0 cleanup of orphans and dead probes
- delete orphan e2e specs (hitl, interrupt-headless, tool-rendering-reasoning-chain) - rename reasoning-default-render → reasoning-default (route + describe) - delete dead D5 probes (hitl-steps, interrupt-headless, tool-rendering-reasoning-chain) - update d5-feature-mapping: rename agentic-chat-reasoning → reasoning-custom and reasoning-default-render → reasoning-default; repoint hitl + hitl-in-chat-booking to hitl-text-input (still used by ag2/agno/built-in-agent) - update d5-registry: drop hitl-steps, interrupt-headless, tool-rendering-reasoning-chain feature types - update d5-reasoning-display preNavigateRoute branch logic and tests - update probes.test.ts and e2e-deep.test.ts to use surviving feature types
1 parent 90c38bd commit 265c156

16 files changed

Lines changed: 42 additions & 657 deletions

showcase/harness/src/http/probes.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -956,13 +956,13 @@ describe("POST /api/probes/:id/trigger — B2 featureTypes validation", () => {
956956
"Content-Type": "application/json",
957957
},
958958
body: JSON.stringify({
959-
filter: { featureTypes: ["hitl-steps"] },
959+
filter: { featureTypes: ["hitl-text-input"] },
960960
}),
961961
});
962962
expect(res.status).toBe(200);
963963
// Verify featureTypes is threaded through to scheduler.trigger opts
964964
expect(sched.lastTriggerOpts).toEqual({
965-
filter: { featureTypes: ["hitl-steps"] },
965+
filter: { featureTypes: ["hitl-text-input"] },
966966
});
967967
});
968968

showcase/harness/src/probes/drivers/e2e-deep.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -995,7 +995,7 @@ describe("e2e-deep feature-type filtering (driver level)", () => {
995995
const { writer, writes } = mkWriter();
996996

997997
const ctx = mkCtx(writer);
998-
ctx.featureTypes = ["hitl-steps"]; // not registered
998+
ctx.featureTypes = ["hitl-text-input"]; // scriptLoader no-op so no probe loaded
999999

10001000
const result = await driver.run(ctx, {
10011001
key: "e2e-deep:showcase-test",

showcase/harness/src/probes/helpers/d5-feature-mapping.ts

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,10 @@ const REGISTRY_TO_D5: Readonly<Record<string, readonly D5FeatureType[]>> = {
9090
// skipped by `demosToFeatureTypes`).
9191
"hitl-in-chat": ["hitl-text-input"],
9292
"hitl-in-chat-booking": ["hitl-text-input"],
93-
hitl: ["hitl-steps"],
93+
// `hitl` is used by ag2 / agno / built-in-agent / others as an alias of
94+
// hitl-in-chat. Repointed to `hitl-text-input` after `d5-hitl-steps.ts`
95+
// was removed in the genuine-pass Phase 0 cleanup.
96+
hitl: ["hitl-text-input"],
9497

9598
// hitl (approve/deny tier) — out-of-chat modal approval flow.
9699
"hitl-in-app": ["hitl-approve-deny"],
@@ -143,12 +146,11 @@ const REGISTRY_TO_D5: Readonly<Record<string, readonly D5FeatureType[]>> = {
143146
"frontend-tools-async": ["frontend-tools-async"],
144147

145148
// Reasoning family — single `reasoning-display` literal covers both
146-
// demo routes via preNavigateRoute. tool-rendering-reasoning-chain is
147-
// split because its assertion shape interleaves tool render with
148-
// reasoning block.
149-
"agentic-chat-reasoning": ["reasoning-display"],
150-
"reasoning-default-render": ["reasoning-display"],
151-
"tool-rendering-reasoning-chain": ["tool-rendering-reasoning-chain"],
149+
// demo routes via preNavigateRoute. The `tool-rendering-reasoning-chain`
150+
// demo was removed in the LGP demo-pass; its mapping entry and probe
151+
// script were deleted in the genuine-pass Phase 0 cleanup.
152+
"reasoning-custom": ["reasoning-display"],
153+
"reasoning-default": ["reasoning-display"],
152154

153155
// State family — `shared-state-read` registry feature reuses the
154156
// existing `shared-state-read` D5 literal (already paired with
@@ -168,9 +170,9 @@ const REGISTRY_TO_D5: Readonly<Record<string, readonly D5FeatureType[]>> = {
168170
"gen-ui-agent": ["gen-ui-agent"],
169171

170172
// Interrupt family — LangGraph interrupt-driven HITL, distinct from
171-
// useHumanInTheLoop hook patterns. Two demos = two literals (one
172-
// headless, one gen-UI yielding interrupt).
173-
"interrupt-headless": ["interrupt-headless"],
173+
// useHumanInTheLoop hook patterns. The `interrupt-headless` demo was
174+
// removed in the LGP demo-pass; its mapping entry and probe script
175+
// were deleted in the genuine-pass Phase 0 cleanup.
174176
"gen-ui-interrupt": ["gen-ui-interrupt"],
175177

176178
// BYOC family — single literal covers hashbrown + json-render via

showcase/harness/src/probes/helpers/d5-registry.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ export type D5FeatureType =
3737
| "shared-state-read"
3838
| "shared-state-write"
3939
| "hitl-approve-deny"
40-
| "hitl-steps"
4140
| "hitl-text-input"
4241
| "gen-ui-headless"
4342
| "gen-ui-headless-complete"
@@ -59,7 +58,6 @@ export type D5FeatureType =
5958
| "frontend-tools-async"
6059
// Reasoning family — reasoning/thinking block + final answer.
6160
| "reasoning-display"
62-
| "tool-rendering-reasoning-chain"
6361
// State family — streaming state updates and read-only agent context.
6462
| "shared-state-streaming"
6563
| "readonly-state-context"
@@ -70,7 +68,6 @@ export type D5FeatureType =
7068
| "gen-ui-agent"
7169
// Interrupt family — LangGraph-interrupt-driven HITL (distinct from
7270
// useHumanInTheLoop hook patterns).
73-
| "interrupt-headless"
7471
| "gen-ui-interrupt"
7572
// BYOC family — bring-your-own-component structured-output rendering
7673
// (one literal covers hashbrown + json-render via preNavigateRoute).
@@ -103,7 +100,6 @@ const D5_FEATURE_TYPES: readonly D5FeatureType[] = [
103100
"shared-state-read",
104101
"shared-state-write",
105102
"hitl-approve-deny",
106-
"hitl-steps",
107103
"hitl-text-input",
108104
"gen-ui-headless",
109105
"gen-ui-headless-complete",
@@ -120,14 +116,12 @@ const D5_FEATURE_TYPES: readonly D5FeatureType[] = [
120116
"frontend-tools",
121117
"frontend-tools-async",
122118
"reasoning-display",
123-
"tool-rendering-reasoning-chain",
124119
"shared-state-streaming",
125120
"readonly-state-context",
126121
"gen-ui-declarative",
127122
"gen-ui-a2ui-fixed",
128123
"gen-ui-open",
129124
"gen-ui-agent",
130-
"interrupt-headless",
131125
"gen-ui-interrupt",
132126
"byoc",
133127
"voice",

showcase/harness/src/probes/scripts/d5-hitl-steps.test.ts

Lines changed: 0 additions & 132 deletions
This file was deleted.

showcase/harness/src/probes/scripts/d5-hitl-steps.ts

Lines changed: 0 additions & 131 deletions
This file was deleted.

0 commit comments

Comments
 (0)