Skip to content

Commit 2d55b92

Browse files
authored
chore(showcase): quiet per-run success posts in #oss-alerts (CopilotKit#4065)
## Summary - Suppress per-run `:white_check_mark: *Showcase deploy*: N service(s) deployed to Railway` Slack posts from `showcase_deploy.yml`. During bulk drift rebuilds, the smoke-monitor fans out one `showcase_deploy.yml` run per stale service (up to ~18), producing ~18 noise messages in #oss-alerts per drift cycle. The top-line `:package: Image drift detected — N rebuilds triggered` in `showcase_smoke-monitor.yml` already covers the aggregate success case. - Also suppress the `no changes detected, nothing to deploy` post — rare and uninformative. - Preserve failure messages (pre-build failure, build failure) and the mid-matrix cancellation info message (state transition worth seeing). - Harden the Post step with `env.SLACK_WEBHOOK_OSS_ALERTS != ''` guard so a missing secret fails closed rather than erroring the action. Channel policy alignment: #oss-alerts surfaces only actionable state (failures + transitions). Ad-hoc single-service successes stay quiet — the Actions UI is the source of truth. ## Test plan - [x] `actionlint .github/workflows/showcase_deploy.yml` — no new findings introduced by this diff (pre-existing SC2086 style infos unrelated to the edited region) - [x] Local dry-run simulation of every branch in the payload step: success (bulk) → suppressed, no-changes → suppressed, build-failure → posted, detect/lockfile-failure → posted, mid-matrix cancel → posted, pre-build cancel → suppressed - [ ] Observe in production: next drift rebuild cycle should post one top-line drift message and zero per-service greens; any failing leg still surfaces ## Out of scope - Smoke monitor verbosity (already correct: red + recovery only) - Drift detection logic (unchanged) - `crewai-crews` 502 investigation (unrelated)
2 parents 5b1a137 + e4b27c5 commit 2d55b92

1 file changed

Lines changed: 17 additions & 3 deletions

File tree

.github/workflows/showcase_deploy.yml

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -468,12 +468,24 @@ jobs:
468468
exit 0
469469
fi
470470
471+
# Policy: #oss-alerts should only surface actionable state —
472+
# failures and state transitions. Per-run success confirmations
473+
# are noise, especially during bulk drift rebuilds which fan out
474+
# one showcase_deploy.yml run per service (up to ~18). The
475+
# top-line ":package: Image drift detected — N rebuilds triggered"
476+
# posted by showcase_smoke-monitor.yml is the aggregate success
477+
# signal for bulk rebuilds; ad-hoc single-service pushes/dispatches
478+
# stay quiet on success (the Actions UI is the source of truth).
471479
if [ "$DETECT" = "failure" ] || [ "$LOCKFILE" = "failure" ]; then
472480
MSG=":x: *Showcase deploy*: FAILED (pre-build check)"
473481
elif [ "$BUILD" = "success" ]; then
474-
MSG=":white_check_mark: *Showcase deploy*: ${COUNT} service(s) deployed to Railway (${SERVICES})"
482+
echo "Build succeeded — suppressing per-run success notification (policy: actionable-only)"
483+
echo "should_post=false" >> "$GITHUB_OUTPUT"
484+
exit 0
475485
elif [ "$BUILD" = "skipped" ] && [ "$DETECT" = "success" ]; then
476-
MSG=":white_check_mark: *Showcase deploy*: no changes detected, nothing to deploy"
486+
echo "No changes detected — suppressing notification (policy: actionable-only)"
487+
echo "should_post=false" >> "$GITHUB_OUTPUT"
488+
exit 0
477489
else
478490
MSG=":x: *Showcase deploy*: FAILED — ${COUNT} service(s) targeted (${SERVICES})"
479491
fi
@@ -482,7 +494,9 @@ jobs:
482494
echo "should_post=true" >> "$GITHUB_OUTPUT"
483495
484496
- name: Post to Slack
485-
if: always() && steps.payload.outputs.should_post == 'true'
497+
if: always() && steps.payload.outputs.should_post == 'true' && env.SLACK_WEBHOOK_OSS_ALERTS != ''
498+
env:
499+
SLACK_WEBHOOK_OSS_ALERTS: ${{ secrets.SLACK_WEBHOOK_OSS_ALERTS }}
486500
uses: slackapi/slack-github-action@v2.1.0
487501
with:
488502
webhook: ${{ secrets.SLACK_WEBHOOK_OSS_ALERTS }}

0 commit comments

Comments
 (0)