fix(showcase): make resolveD5 strict on missing mapped sub-rows

A multi-key D5 family with a missing mapped sub-row is now unverified
(status null), not credited green from the present rows. A present red
sub-row still yields red. Mirrors isD5Green's every(...) so both consumers
agree.

Author: jpr5

showcase/shell-dashboard/src/lib/__tests__/cell-model.test.ts

@@ -344,6 +344,64 @@ describe("buildCellModel", () => {
       // D6-ceiling: D5 green but D6 absent → amber
       expect(model.chipColor).toBe("amber");
     });
+
+    it("does not credit D5 green when one mapped sub-row is MISSING (strict)", () => {
+      // beautiful-chat maps to 5 sub-keys; emit only 4 (bar-chart missing).
+      // A missing mapped sub-row means the family is unverified, so D5 must
+      // NOT be credited green — it returns status:null (no-data), matching
+      // `isD5Green`'s `every(...)`. achievedDepth caps below 5; A1 renders
+      // the unverified ladder gray.
+      const live = mapOf([
+        row(keyFor("e2e", "agno", "beautiful-chat"), "e2e", "green"),
+        row(keyFor("chat", "agno"), "chat", "green"),
+        row(keyFor("d5", "agno", "beautiful-chat-toggle-theme"), "d5", "green"),
+        row(keyFor("d5", "agno", "beautiful-chat-pie-chart"), "d5", "green"),
+        // beautiful-chat-bar-chart intentionally omitted.
+        row(
+          keyFor("d5", "agno", "beautiful-chat-search-flights"),
+          "d5",
+          "green",
+        ),
+        row(
+          keyFor("d5", "agno", "beautiful-chat-schedule-meeting"),
+          "d5",
+          "green",
+        ),
+      ]);
+      const model = buildCellModel(live, wiredInput("agno", "beautiful-chat"));
+      expect(model.d5!.exists).toBe(true);
+      // Missing sub-row → no-data, NOT green and NOT red.
+      expect(model.d5!.status).toBeNull();
+      expect(model.achievedDepth).toBe(4);
+      // Unverified ladder (D5 null), D6 absent → gray.
+      expect(model.chipColor).toBe("gray");
+    });
+
+    it("still reports red when a present sub-row is red even if another is missing", () => {
+      // A present red sub-row signals a real failure regardless of a missing
+      // sibling — red dominates no-data.
+      const live = mapOf([
+        row(keyFor("e2e", "agno", "beautiful-chat"), "e2e", "green"),
+        row(keyFor("chat", "agno"), "chat", "green"),
+        row(keyFor("d5", "agno", "beautiful-chat-toggle-theme"), "d5", "green"),
+        row(keyFor("d5", "agno", "beautiful-chat-pie-chart"), "d5", "red"),
+        // bar-chart missing; one present sub-row is red.
+        row(
+          keyFor("d5", "agno", "beautiful-chat-search-flights"),
+          "d5",
+          "green",
+        ),
+        row(
+          keyFor("d5", "agno", "beautiful-chat-schedule-meeting"),
+          "d5",
+          "green",
+        ),
+      ]);
+      const model = buildCellModel(live, wiredInput("agno", "beautiful-chat"));
+      expect(model.d5!.status).toBe("red");
+      expect(model.achievedDepth).toBe(4);
+      expect(model.chipColor).toBe("red");
+    });
   });
 
   // ── No live data at all → D0 gray ──────────────────────────────────

showcase/shell-dashboard/src/lib/cell-model.ts

@@ -169,15 +169,13 @@ function resolveD4(live: LiveStatusMap, slug: string, now: number): TestLevel {
  * independent of `CATALOG_TO_D5_KEY` order. Only green is downgraded; a stale
  * red/degraded sub-row already signals a problem.
  *
- * NOTE on missing sub-rows: this fold only considers sub-rows that are PRESENT
- * — a missing row is SKIPPED (`if (!row) continue;`), not treated as failing.
- * So a multi-key family with only some sub-rows emitted can still be credited
- * green from those present rows. This DIVERGES from `depth-utils.ts`
- * `isD5Green`, which uses `d5Keys.every(...)` and therefore requires every
- * mapped key to be present AND green-and-fresh; a missing row makes the whole
- * family non-green there. The per-row stale-green→degraded downgrade IS
- * mirrored between the two; only the partial-emission (missing-row) handling
- * differs.
+ * STRICT on missing sub-rows: a multi-key family is credited green ONLY when
+ * EVERY mapped sub-row is present and green-and-fresh — a missing mapped
+ * sub-row forces the family out of green and resolves to `status: null`
+ * (no-data/unverified), so `achievedDepth` caps below 5 and the chip renders
+ * gray. A present RED sub-row still yields red (red dominates no-data). This
+ * matches `depth-utils.ts` `isD5Green`, which uses `d5Keys.every(...)`; both
+ * consumers now agree on partial-emission handling.
  */
 function resolveD5(
   live: LiveStatusMap,
@@ -194,9 +192,16 @@ function resolveD5(
 
   let worstRow: StatusRow | null = null;
   let worstState: State | null = null;
+  let anyMissing = false;
   for (const d5Key of d5Keys) {
     const row = live.get(keyFor("d5", slug, d5Key)) ?? null;
-    if (!row) continue;
+    if (!row) {
+      // STRICT: a missing mapped sub-row means the family is unverified —
+      // it can no longer be credited green. Mirrors `isD5Green`'s
+      // `every(...)` in depth-utils.ts so both consumers agree.
+      anyMissing = true;
+      continue;
+    }
     // Per-row staleness downgrade applied BEFORE the fold: a green sub-row
     // that is stale folds in as `degraded` so it can never win the all-green
     // tie and mask a fresh-green sibling.
@@ -219,6 +224,15 @@ function resolveD5(
     return { exists: true, status: null, row: null };
   }
 
+  // STRICT missing-sub-row handling: when a mapped sub-row is absent the
+  // family is unverified. A present RED sub-row still signals a real failure
+  // (red dominates no-data), but a present green/degraded fold must NOT be
+  // credited — collapse it to no-data (status: null) so achievedDepth caps
+  // below 5 and the chip renders gray, not a false-green/amber.
+  if (anyMissing && worstState !== "red") {
+    return { exists: true, status: null, row: null };
+  }
+
   return {
     exists: true,
     status: stateToTestStatus(worstState),