Skip to content

Commit 390ab6f

Browse files
committed
test(showcase/langgraph-python): rewrite subagents to 5 deterministic 3-card tests
- Drop the 8 stale tests that asserted travel-planner shapes (Current Itinerary / supervisor-indicator / .bg-gray-50). They predated the supervisor + 3-subagent rewrite and could not catch the 3 production bugs. - New suite (5 tests, 0 skipped): 1) page loads with composer + 3 verbatim suggestion pills + 3 subagent role indicators (testid-based). 2-4) one test per pill (Write a blog post / Explain a topic / Summarize a topic). Each clicks the pill, waits for all three role-scoped subagent cards to reach data-status= "complete", then asserts each card's subagent-result is non-empty AND does not contain the showcase-assistant boilerplate fragments. Test 4 also serves as a regression gate on the delegations reducer fix — without it, that pill returns HTTP 400 and the cards never reach complete. 5) clicks any pill, waits for terminal state, then asserts the critic-card count is exactly 1 and stays at 1 with status complete across a 5s dwell — catches any return of the supervisor -> critic loop. - Aimock fixtures: 3 verbatim pill chains (cold exposure training, LLM tool calling, reusable rockets) added to both d5-all.json and the harness source d5/mcp-subagents.json. Each chain drives the full supervisor flow (turnIndex 0..3) plus three nested sub-agent fixtures so every Researcher/Writer/Critic card surfaces real prose instead of showcase boilerplate.
1 parent 9b3d64d commit 390ab6f

3 files changed

Lines changed: 638 additions & 85 deletions

File tree

showcase/aimock/d5-all.json

Lines changed: 246 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -370,6 +370,252 @@
370370
"content": "Here is the summary, after research → drafting → critique:\n\nRemote work returns roughly ten hours a week to employees by eliminating the commute, and repeated surveys show meaningfully higher job satisfaction among remote workers. Employers benefit too: a geographically unbounded talent pool and lower office overhead. The honest counterweight is that ad-hoc collaboration, mentorship of junior staff, and cultural cohesion all degrade without intentional rituals to replace what an office provided implicitly."
371371
}
372372
},
373+
{
374+
"_comment": "Subagents pill 1 — 'Write a blog post' / cold exposure training. Drives supervisor → research_agent → writing_agent → critique_agent → final reply, plus three nested sub-agent turns.",
375+
"match": {
376+
"userMessage": "Produce a short blog post about the benefits of cold exposure training",
377+
"hasToolResult": false
378+
},
379+
"response": {
380+
"toolCalls": [
381+
{
382+
"id": "call_d5_subagents_p1_research_001",
383+
"name": "research_agent",
384+
"arguments": "{\"task\":\"Cold exposure training key facts\"}"
385+
}
386+
]
387+
}
388+
},
389+
{
390+
"_comment": "Nested: research sub-agent returns deterministic facts about cold exposure training.",
391+
"match": {
392+
"userMessage": "Cold exposure training key facts"
393+
},
394+
"response": {
395+
"content": "- Brief cold immersion (cold showers, ice baths) triggers a sympathetic-nervous-system response that releases noradrenaline\n- Repeated exposure is associated with improved self-reported mood and stress tolerance\n- Activates brown adipose tissue, modestly increasing basal metabolic rate\n- May reduce post-exercise muscle soreness when used as a recovery modality\n- Health risk for people with cardiovascular conditions; sessions should be short (1-3 minutes) and supervised at first"
396+
}
397+
},
398+
{
399+
"match": {
400+
"userMessage": "Produce a short blog post about the benefits of cold exposure training",
401+
"turnIndex": 1
402+
},
403+
"response": {
404+
"toolCalls": [
405+
{
406+
"id": "call_d5_subagents_p1_writing_001",
407+
"name": "writing_agent",
408+
"arguments": "{\"task\":\"Short blog-post paragraph on the benefits of cold exposure training, grounded in the research facts.\\n\\nFacts:\\n- Brief cold immersion triggers a noradrenaline release\\n- Repeated exposure improves self-reported mood and stress tolerance\\n- Activates brown adipose tissue, modestly raises basal metabolic rate\\n- May reduce post-exercise muscle soreness\\n- Cardiovascular risk; keep early sessions short and supervised\"}"
409+
}
410+
]
411+
}
412+
},
413+
{
414+
"_comment": "Nested: writing sub-agent returns deterministic prose for cold exposure.",
415+
"match": {
416+
"userMessage": "Short blog-post paragraph on the benefits of cold exposure training"
417+
},
418+
"response": {
419+
"content": "Cold exposure training — short, deliberate plunges into cold water or showers — has earned a foothold in modern recovery routines for reasons grounded in physiology rather than folklore. Each immersion produces a measurable surge of noradrenaline, the same chemistry that underpins the lift practitioners report in mood and focus afterward; with repetition, that response is associated with greater day-to-day stress tolerance. Cold also activates brown adipose tissue and can blunt post-exercise soreness, making it a low-cost adjunct for active people. The honest caveat is cardiovascular risk: keep early sessions to one to three minutes, and if you have a heart condition, get a green light before you start."
420+
}
421+
},
422+
{
423+
"match": {
424+
"userMessage": "Produce a short blog post about the benefits of cold exposure training",
425+
"turnIndex": 2
426+
},
427+
"response": {
428+
"toolCalls": [
429+
{
430+
"id": "call_d5_subagents_p1_critique_001",
431+
"name": "critique_agent",
432+
"arguments": "{\"task\":\"Critique the cold-exposure blog draft. Draft: Cold exposure training — short, deliberate plunges into cold water or showers — has earned a foothold in modern recovery routines for reasons grounded in physiology rather than folklore. Each immersion produces a measurable surge of noradrenaline...\"}"
433+
}
434+
]
435+
}
436+
},
437+
{
438+
"_comment": "Nested: critique sub-agent returns deterministic critique of cold-exposure draft.",
439+
"match": {
440+
"userMessage": "Critique the cold-exposure blog draft"
441+
},
442+
"response": {
443+
"content": "1. The phrase 'measurable surge of noradrenaline' should cite a study or rough magnitude — without a number, the claim reads as marketing rather than evidence.\n2. 'Modern recovery routines' is filler; lead with the physiological mechanism instead and let the cultural framing follow.\n3. The cardiovascular caveat is buried at the end. Move it earlier or make it a standalone closing line so a reader who skims still sees it."
444+
}
445+
},
446+
{
447+
"match": {
448+
"userMessage": "Produce a short blog post about the benefits of cold exposure training",
449+
"turnIndex": 3
450+
},
451+
"response": {
452+
"content": "Here is the polished blog post on cold exposure training, after research → drafting → critique:\n\nCold exposure training — short, deliberate plunges into cold water or showers — produces a measurable noradrenaline surge that practitioners feel as a mood and focus lift; repeated exposure is associated with greater stress tolerance, brown-adipose activation, and reduced post-exercise soreness. Keep early sessions to one to three minutes, and if you have a cardiovascular condition, clear it with a clinician first."
453+
}
454+
},
455+
{
456+
"_comment": "Subagents pill 2 — 'Explain a topic' / LLM tool calling.",
457+
"match": {
458+
"userMessage": "Explain how large language models handle tool calling",
459+
"hasToolResult": false
460+
},
461+
"response": {
462+
"toolCalls": [
463+
{
464+
"id": "call_d5_subagents_p2_research_001",
465+
"name": "research_agent",
466+
"arguments": "{\"task\":\"How LLMs handle tool calling\"}"
467+
}
468+
]
469+
}
470+
},
471+
{
472+
"_comment": "Nested: research sub-agent for LLM tool calling.",
473+
"match": {
474+
"userMessage": "How LLMs handle tool calling"
475+
},
476+
"response": {
477+
"content": "- The model is shown a tool schema (name, description, JSON-schema parameters) inside the system or developer prompt at request time\n- During decoding, instead of emitting natural-language text, the model emits a structured tool_call block (function name + JSON-encoded arguments)\n- The application runs the tool, packages the result into a tool message, and resends the full conversation so the model can continue\n- Modern decoders use constrained decoding or grammars to keep the arguments syntactically valid JSON\n- The model decides on tool use turn-by-turn — there is no out-of-band channel; tool calls are just a different message role in the same chat thread"
478+
}
479+
},
480+
{
481+
"match": {
482+
"userMessage": "Explain how large language models handle tool calling",
483+
"turnIndex": 1
484+
},
485+
"response": {
486+
"toolCalls": [
487+
{
488+
"id": "call_d5_subagents_p2_writing_001",
489+
"name": "writing_agent",
490+
"arguments": "{\"task\":\"One-paragraph explanation of how LLMs handle tool calling, grounded in the research.\\n\\nFacts:\\n- Tool schemas (name, description, JSON-schema params) are passed in the prompt\\n- Models emit a structured tool_call block instead of text\\n- Application runs the tool and replays the result as a tool message\\n- Constrained decoding keeps arguments valid JSON\\n- Tool use is decided turn-by-turn in the same chat thread\"}"
491+
}
492+
]
493+
}
494+
},
495+
{
496+
"_comment": "Nested: writing sub-agent for LLM tool calling.",
497+
"match": {
498+
"userMessage": "One-paragraph explanation of how LLMs handle tool calling"
499+
},
500+
"response": {
501+
"content": "Large language models handle tool calling by treating tools as a structured extension of the chat protocol rather than a separate channel. At request time the application supplies each tool's name, description, and JSON-schema parameters in the prompt; during decoding the model can emit a tool_call block — a function name plus JSON-encoded arguments — instead of plain text, with constrained decoding keeping the arguments syntactically valid. The application then executes the tool and replays the result back as a tool-role message, and the model continues the conversation from there. The decision to call a tool is made turn-by-turn, so a single user request can fan out into a chain of tool calls that the model orchestrates as it reads each result."
502+
}
503+
},
504+
{
505+
"match": {
506+
"userMessage": "Explain how large language models handle tool calling",
507+
"turnIndex": 2
508+
},
509+
"response": {
510+
"toolCalls": [
511+
{
512+
"id": "call_d5_subagents_p2_critique_001",
513+
"name": "critique_agent",
514+
"arguments": "{\"task\":\"Critique the LLM tool-calling explanation draft. Draft: Large language models handle tool calling by treating tools as a structured extension of the chat protocol rather than a separate channel. At request time the application supplies each tool's name, description, and JSON-schema parameters in the prompt...\"}"
515+
}
516+
]
517+
}
518+
},
519+
{
520+
"_comment": "Nested: critique sub-agent for LLM tool calling.",
521+
"match": {
522+
"userMessage": "Critique the LLM tool-calling explanation draft"
523+
},
524+
"response": {
525+
"content": "1. The opening contrast 'rather than a separate channel' assumes the reader already knows what a 'separate channel' would mean — either drop the contrast or give a one-clause example (e.g., 'rather than a side API the model talks to in parallel').\n2. 'Constrained decoding keeping the arguments syntactically valid' is technically correct but vague; mention that this is what makes the JSON parseable on the application side.\n3. The final sentence introduces multi-tool chains without saying who controls the loop — clarify that the application is the runtime that decides whether to keep going, not the model itself."
526+
}
527+
},
528+
{
529+
"match": {
530+
"userMessage": "Explain how large language models handle tool calling",
531+
"turnIndex": 3
532+
},
533+
"response": {
534+
"content": "Here is the explanation of LLM tool calling, after research → drafting → critique:\n\nLLMs treat tool calling as part of the chat protocol: each tool's name, description, and JSON-schema parameters are passed in the prompt, and during decoding the model can emit a structured tool_call block (function name + JSON arguments) instead of plain text. The application — not the model — runs the tool, returns the result as a tool-role message, and decides whether to keep looping. Constrained decoding keeps the arguments valid JSON the application can parse, and the model orchestrates multi-step chains turn-by-turn from inside the same conversation."
535+
}
536+
},
537+
{
538+
"_comment": "Subagents pill 3 — 'Summarize a topic' / reusable rockets. Note: the original Railway-side bug for this pill was the concurrent-update on `delegations`; the agent state reducer fix unblocks this fixture chain.",
539+
"match": {
540+
"userMessage": "Summarize the current state of reusable rockets",
541+
"hasToolResult": false
542+
},
543+
"response": {
544+
"toolCalls": [
545+
{
546+
"id": "call_d5_subagents_p3_research_001",
547+
"name": "research_agent",
548+
"arguments": "{\"task\":\"Current state of reusable rockets\"}"
549+
}
550+
]
551+
}
552+
},
553+
{
554+
"_comment": "Nested: research sub-agent for reusable rockets.",
555+
"match": {
556+
"userMessage": "Current state of reusable rockets"
557+
},
558+
"response": {
559+
"content": "- SpaceX Falcon 9 routinely lands and re-flies first stages; individual boosters have flown more than 20 missions each\n- Falcon Heavy reuses both side boosters; the center core has been recovered on a subset of flights\n- Rocket Lab's Electron has demonstrated mid-air booster catch but routine reuse is still in development\n- SpaceX Starship is targeting full reuse of both stages; orbital test flights are ongoing as of 2024-2025\n- Reuse is the dominant lever on launch cost: Falcon 9 list pricing is set well below expendable competitors largely because of stage recovery"
560+
}
561+
},
562+
{
563+
"match": {
564+
"userMessage": "Summarize the current state of reusable rockets",
565+
"turnIndex": 1
566+
},
567+
"response": {
568+
"toolCalls": [
569+
{
570+
"id": "call_d5_subagents_p3_writing_001",
571+
"name": "writing_agent",
572+
"arguments": "{\"task\":\"One polished paragraph summarizing the current state of reusable rockets, grounded in the research.\\n\\nFacts:\\n- Falcon 9 first stages routinely re-fly, some 20+ flights\\n- Falcon Heavy reuses side boosters; center core recovered sometimes\\n- Rocket Lab Electron demonstrating mid-air catch, reuse still in development\\n- SpaceX Starship targeting full reuse of both stages, in flight test\\n- Reuse drives launch cost downward\"}"
573+
}
574+
]
575+
}
576+
},
577+
{
578+
"_comment": "Nested: writing sub-agent for reusable rockets.",
579+
"match": {
580+
"userMessage": "One polished paragraph summarizing the current state of reusable rockets"
581+
},
582+
"response": {
583+
"content": "Reusable rockets have shifted from a research goal to the default cost lever in commercial spaceflight. SpaceX's Falcon 9 routinely lands and re-flies its first stage — individual boosters have now flown twenty-plus missions — and Falcon Heavy reuses both side boosters with intermittent recovery of the center core. Smaller-class operators like Rocket Lab have demonstrated mid-air booster catch but have not yet made reuse routine, while SpaceX's Starship is in active flight testing toward full two-stage reuse. The economic consequence is already visible: Falcon 9 list pricing sits well below expendable competitors precisely because the dominant cost — building a fresh first stage every flight — has been amortized across many missions."
584+
}
585+
},
586+
{
587+
"match": {
588+
"userMessage": "Summarize the current state of reusable rockets",
589+
"turnIndex": 2
590+
},
591+
"response": {
592+
"toolCalls": [
593+
{
594+
"id": "call_d5_subagents_p3_critique_001",
595+
"name": "critique_agent",
596+
"arguments": "{\"task\":\"Critique the reusable rockets summary draft. Draft: Reusable rockets have shifted from a research goal to the default cost lever in commercial spaceflight. SpaceX's Falcon 9 routinely lands and re-flies its first stage — individual boosters have now flown twenty-plus missions...\"}"
597+
}
598+
]
599+
}
600+
},
601+
{
602+
"_comment": "Nested: critique sub-agent for reusable rockets.",
603+
"match": {
604+
"userMessage": "Critique the reusable rockets summary draft"
605+
},
606+
"response": {
607+
"content": "1. 'Default cost lever' is jargon that pre-supposes the reader already accepts the framing — open instead with the concrete result (Falcon 9 reflight count) and let the framing emerge.\n2. The Starship sentence is hedged ('in active flight testing toward full reuse') in a way that obscures the actual milestone reached as of writing — name the latest test outcome or drop the clause.\n3. The closing economic claim asserts pricing is 'well below expendable competitors' without a reference price; one number (e.g., $/kg-to-LEO) would land the point much harder than the qualitative claim alone."
608+
}
609+
},
610+
{
611+
"match": {
612+
"userMessage": "Summarize the current state of reusable rockets",
613+
"turnIndex": 3
614+
},
615+
"response": {
616+
"content": "Here is the polished summary on reusable rockets, after research → drafting → critique:\n\nReusable rockets are now mainstream in commercial spaceflight. SpaceX's Falcon 9 lands and re-flies its first stage routinely — individual boosters have flown twenty-plus missions — and Falcon Heavy reuses both side boosters. Rocket Lab has demonstrated mid-air Electron booster catch but reuse is not yet routine, while SpaceX Starship is in active orbital flight testing with full two-stage reuse as the target. The economic impact is already priced in: Falcon 9 sits well below expendable competitors per kilogram to low Earth orbit because amortizing a recovered first stage across many missions removes the largest single cost from the launch."
617+
}
618+
},
373619
{
374620
"match": {
375621
"userMessage": "describe the sample image"

0 commit comments

Comments
 (0)