move disableWhenEmpty to BaseAutosuggestionsConfig

.

Author: ataibarkai

packages/react-textarea/src/components/copilot-textarea/base-copilot-textarea/base-copilot-textarea.tsx

@@ -87,7 +87,8 @@ export function BaseCopilotTextarea(
     autosuggestionsConfig.debounceTime,
     autosuggestionsConfig.acceptAutosuggestionKey,
     props.autosuggestionsFunction,
-    insertText
+    insertText,
+    autosuggestionsConfig.disableWhenEmpty
   );
 
   // sync autosuggestions state with the editor

packages/react-textarea/src/components/copilot-textarea/copilot-textarea.tsx

@@ -24,8 +24,7 @@ export function CopilotTextarea(props: CopilotTextareaProps): JSX.Element {
     autosuggestionsConfig.apiEndpoint,
     autosuggestionsConfig.makeSystemMessage,
     autosuggestionsConfig.fewShotMessages,
-    autosuggestionsConfig.contextCategories,
-    autosuggestionsConfig.disableWhenEmpty
+    autosuggestionsConfig.contextCategories
   );
 
   return (

packages/react-textarea/src/hooks/make-autosuggestions-function/use-make-standard-autosuggestions-function.tsx

@@ -28,17 +28,12 @@ export function useMakeAutosuggestionFunction(
   apiEndpoint: string,
   makeSystemMessage: MakeSystemMessage,
   fewShotMessages: MinimalChatGPTMessage[],
-  contextCategories: string[] | undefined,
-  disableWhenEmpty: boolean
+  contextCategories: string[] | undefined
 ): AutosuggestionsBareFunction {
   const { getContextString } = useContext(CopilotContext);
 
   return useCallback(
     async (beforeText: string, afterText: string, abortSignal: AbortSignal) => {
-      if (disableWhenEmpty && beforeText === "" && afterText === "") {
-        throw new Error("No text to suggest");
-      }
-
       const res = await retry(async () => {
         return await fetch(apiEndpoint, {
           method: "POST",

packages/react-textarea/src/hooks/use-autosuggestions.ts

@@ -27,7 +27,8 @@ export function useAutosuggestions(
   debounceTime: number,
   acceptAutosuggestionKey: string,
   autosuggestionFunction: AutosuggestionsBareFunction,
-  insertAutocompleteSuggestion: (suggestion: AutosuggestionState) => void
+  insertAutocompleteSuggestion: (suggestion: AutosuggestionState) => void,
+  disableWhenEmpty: boolean
 ): UseAutosuggestionsResult {
   const [previousAutocompleteState, setPreviousAutocompleteState] =
     useState<EditorAutocompleteState | null>(null);
@@ -43,6 +44,14 @@ export function useAutosuggestions(
       editorAutocompleteState: EditorAutocompleteState,
       abortSignal: AbortSignal
     ) => {
+      if (
+        disableWhenEmpty &&
+        editorAutocompleteState.textBeforeCursor === "" &&
+        editorAutocompleteState.textAfterCursor === ""
+      ) {
+        return;
+      }
+
       const suggestion = await autosuggestionFunction(
         editorAutocompleteState.textBeforeCursor,
         editorAutocompleteState.textAfterCursor,
@@ -59,7 +68,7 @@ export function useAutosuggestions(
         point: editorAutocompleteState.cursorPoint,
       });
     },
-    [autosuggestionFunction, setCurrentAutocompleteSuggestion]
+    [autosuggestionFunction, setCurrentAutocompleteSuggestion, disableWhenEmpty]
   );
 
   const debouncedFunction = useMemo(

packages/react-textarea/src/types/autosuggestions-config.tsx

@@ -9,20 +9,21 @@ export interface BaseAutosuggestionsConfig {
   textareaPurpose: string;
   debounceTime: number;
   acceptAutosuggestionKey: string;
+  disableWhenEmpty: boolean;
 }
 
 export const defaultBaseAutosuggestionsConfig: BaseAutosuggestionsConfig = {
   textareaPurpose: "A generic textbox",
   debounceTime: 500,
   acceptAutosuggestionKey: "Tab",
+  disableWhenEmpty: true,
 };
 
 export interface AutosuggestionsConfig extends BaseAutosuggestionsConfig {
   apiEndpoint: string;
   contextCategories: string[] | undefined;
   makeSystemMessage: MakeSystemMessage;
   fewShotMessages: MinimalChatGPTMessage[];
-  disableWhenEmpty: boolean;
 }
 
 export const defaultMakeSystemMessage: MakeSystemMessage = (
@@ -94,5 +95,4 @@ export const defaultAutosuggestionsConfig: AutosuggestionsConfig = {
   makeSystemMessage: defaultMakeSystemMessage,
   fewShotMessages: defaultFewShotMessages,
   contextCategories: undefined,
-  disableWhenEmpty: false,
 };