Skip to content

Commit 8daaf3c

Browse files
committed
fix(showcase-harness): repair three pre-existing probe failures post-Slice 3
- qa probe: manifest.yaml path corrected from showcase/packages/ to showcase/integrations/ (Slice 3 moved files; probe code and test fixture still referenced the old path). - pin-drift probe: fail-baseline.json ENOENT in container — the 5-level import.meta.url walk-up from dist/probes/drivers/ overshoots /app and lands at /. Added PIN_DRIFT_REPO_ROOT=/app env var and COPY of the baseline file into the runtime stage. - aimock-wiring probe: showcase-ms-agent-harness-dotnet (deployed: false) was not in the EXCLUDE_SERVICES set, causing it to be flagged as unwired. Added to the exclude list in both aimock-wiring.ts and smoke.yml.
1 parent 7255531 commit 8daaf3c

5 files changed

Lines changed: 14 additions & 2 deletions

File tree

showcase/harness/Dockerfile

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,10 @@ ENV NODE_ENV=production
6868
# qa probe: repo-root override so the walk-up from dist/probes/drivers/
6969
# (3 levels to /app) matches the showcase/integrations/ layout copied above.
7070
ENV QA_REPO_ROOT=/app
71+
# pin-drift probe: same walk-up issue — the compiled driver lives at
72+
# dist/probes/drivers/pin-drift.js, five `..` segments overshoot /app
73+
# and land at /. Override so the driver finds showcase/scripts/fail-baseline.json.
74+
ENV PIN_DRIFT_REPO_ROOT=/app
7175
# Playwright cache lives outside /home/node so `chown` below doesn't
7276
# have to recurse over the ~300MB chromium tree on every build. Setting
7377
# PLAYWRIGHT_BROWSERS_PATH at this stage pins the install target; the
@@ -97,6 +101,10 @@ RUN node ./node_modules/playwright/cli.js install --with-deps chromium \
97101
# keep the image lean until another probe config actually needs those trees.
98102
COPY --from=build /repo/pnpm-workspace.yaml ./pnpm-workspace.yaml
99103
COPY --from=build /repo/packages ./packages
104+
# pin-drift probe: the driver reads showcase/scripts/fail-baseline.json as
105+
# the ratchet baseline. Only the JSON file is needed — the full scripts/
106+
# tree stays out of the runtime image.
107+
COPY --from=build /repo/showcase/scripts/fail-baseline.json ./showcase/scripts/fail-baseline.json
100108
# qa probe: the driver reads showcase/integrations/<slug>/manifest.yaml to
101109
# check QA file coverage. Copy only the manifests (not full source) to
102110
# keep the runtime image lean. The qa/ subdirectories are also needed

showcase/harness/config/probes/smoke.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ discovery:
7373
- "showcase-shell-dashboard"
7474
- "showcase-shell-docs"
7575
- "showcase-shell-dojo"
76+
# Harness service for .NET integration testing — not a demo service,
77+
# deployed: false in manifest, no aimock wiring yet.
78+
- "showcase-ms-agent-harness-dotnet"
7679
# Decommissioned starters — Railway services stopped, deployments
7780
# halted (PR #4390). Excluded so probes don't scan dead endpoints.
7881
- "showcase-starter-ag2"

showcase/harness/src/probes/aimock-wiring.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ const EXCLUDE_SERVICES: ReadonlySet<string> = new Set([
6060
"showcase-shell-dojo",
6161
"showcase-pocketbase",
6262
"showcase-harness",
63+
"showcase-ms-agent-harness-dotnet",
6364
"showcase-starter-ag2",
6465
"showcase-starter-agno",
6566
"showcase-starter-claude-sdk-python",

showcase/harness/src/probes/drivers/qa.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ interface FixtureOpts {
6363
*/
6464
function makeRepoFixture(opts: FixtureOpts): string {
6565
const root = fs.mkdtempSync(path.join(os.tmpdir(), "qa-driver-"));
66-
const pkgDir = path.join(root, "showcase", "packages", opts.slug);
66+
const pkgDir = path.join(root, "showcase", "integrations", opts.slug);
6767
fs.mkdirSync(pkgDir, { recursive: true });
6868
const manifestBody =
6969
opts.manifestBody ??

showcase/harness/src/probes/drivers/qa.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export function createQaDriver(
9494
const slug = deriveSlug(input);
9595
const repoRoot = deps.repoRoot ?? resolveRepoRoot(ctx);
9696

97-
const pkgDir = path.join(repoRoot, "showcase", "packages", slug);
97+
const pkgDir = path.join(repoRoot, "showcase", "integrations", slug);
9898
const manifestPath = path.join(pkgDir, "manifest.yaml");
9999

100100
let manifestRaw: string;

0 commit comments

Comments
 (0)