fix(showcase): verify-deploy arg-parse symmetry + non-bare releaseBody catch

Author: jpr5

showcase/scripts/__tests__/verify-deploy.test.ts

@@ -30,6 +30,30 @@ describe("verify-deploy argv parsing", () => {
             parseArgs(["--env", "staging", "--services="]),
         ).toThrow(/--services/);
     });
+
+    it("rejects --services space-form whose CSV is all empty entries (symmetry with equals-form)", () => {
+        // Bug: space-form previously only guarded `!v` on the raw next-arg,
+        // so `--services ,,` produced an empty list that fell through to a
+        // less-precise zero-targets error. Both forms must throw the same
+        // precise `--services requires a CSV value` here.
+        expect(() =>
+            parseArgs(["--env=staging", "--services", ",,"]),
+        ).toThrow(/--services requires a CSV value/);
+    });
+
+    it("rejects bare trailing --env (no following value)", () => {
+        // Bug: `argv[++i]` was undefined and we deferred to a vague
+        // `resolveEnv` error. Must throw the precise message here.
+        expect(() => parseArgs(["--env"])).toThrow(
+            /--env requires a value \(staging\|prod\)/,
+        );
+    });
+
+    it("rejects --env= with empty value (symmetry with bare trailing --env)", () => {
+        expect(() => parseArgs(["--env="])).toThrow(
+            /--env requires a value \(staging\|prod\)/,
+        );
+    });
 });
 
 describe("resolveProbeTargets", () => {

showcase/scripts/verify-deploy.drivers.baseline.ts

@@ -91,9 +91,22 @@ async function releaseBody(
 ): Promise<void> {
     try {
         await res.body?.cancel?.();
-    } catch {
-        // Cancelling a body that was already consumed throws on some
-        // runtimes; that's harmless — the socket is already released.
+    } catch (e: unknown) {
+        // Expected benign case: undici throws when the body is already
+        // "locked" (a reader is attached, or it was fully read by an
+        // earlier `res.json()` / `res.text()`). In every such case the
+        // socket is already released, so this is a no-op — swallow it.
+        // Anything else is unexpected; surface it on stderr so we don't
+        // hide a real bug, but keep `releaseBody` best-effort (never
+        // propagate — undici socket release is an optimization, not a
+        // correctness invariant).
+        const msg = e instanceof Error ? e.message : String(e);
+        const locked = /lock/i.test(msg);
+        if (!locked) {
+            process.stderr.write(
+                `[verify-deploy] releaseBody: unexpected cancel error: ${msg}\n`,
+            );
+        }
     }
 }
 

showcase/scripts/verify-deploy.ts

@@ -40,13 +40,35 @@ export function parseArgs(argv: string[]): ParsedArgs {
     for (let i = 0; i < argv.length; i++) {
         const a = argv[i];
         if (a === "--env") {
-            envRaw = argv[++i];
+            const v = argv[++i];
+            // Guard a bare trailing `--env` (undefined) here so the
+            // operator gets a precise, flag-named diagnostic instead of
+            // the downstream `resolveEnv` "Unknown env" / "--env required"
+            // surface. Mirrors the same guard on `--services`.
+            if (v === undefined) {
+                throw new Error("--env requires a value (staging|prod)");
+            }
+            envRaw = v;
         } else if (a.startsWith("--env=")) {
-            envRaw = a.slice("--env=".length);
+            const v = a.slice("--env=".length);
+            // `--env=` (empty post-equals) is the equals-form twin of the
+            // bare-trailing case above; collapse both to the same precise
+            // error rather than deferring to `resolveEnv`.
+            if (v === "") {
+                throw new Error("--env requires a value (staging|prod)");
+            }
+            envRaw = v;
         } else if (a === "--services") {
             const v = argv[++i];
             if (!v) throw new Error("--services requires a CSV value");
             services = v.split(",").map((s) => s.trim()).filter(Boolean);
+            // Symmetry with the equals-form below: a raw value like `,,`
+            // or `"  "` survives the `!v` guard but produces an empty
+            // post-filter list. Throw the same precise error here so both
+            // forms behave identically.
+            if (services.length === 0) {
+                throw new Error("--services requires a CSV value");
+            }
         } else if (a.startsWith("--services=")) {
             const v = a.slice("--services=".length);
             if (!v) throw new Error("--services requires a CSV value");