Skip to content

Commit df42fb3

Browse files
committed
fix(showcase): update CI workflows for gitignored generated data
- deploy workflow: add shared/scripts/manifest paths to shell-dashboard and shell-docs filters (previously triggered implicitly by committed JSON diffs in those directories) - capture-previews: add generate-registry step before capture; use git add -f for the gitignored registry.json - e2e smoke test: document generator dependency in import comment
1 parent 72381f8 commit df42fb3

3 files changed

Lines changed: 15 additions & 1 deletion

File tree

.github/workflows/showcase_capture-previews.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,12 @@ jobs:
106106
echo "slugs=$CHANGED" >> $GITHUB_OUTPUT
107107
echo "Changed packages: $CHANGED"
108108
109+
- name: Generate registry
110+
run: |
111+
cd showcase/scripts
112+
npm ci --silent
113+
npx tsx generate-registry.ts
114+
109115
- name: Capture previews
110116
run: |
111117
ARGS=""
@@ -140,7 +146,7 @@ jobs:
140146
echo "No registry changes"
141147
exit 0
142148
fi
143-
git add registry.json
149+
git add -f registry.json
144150
git commit -m "Update preview URLs in registry"
145151
# Rebase-and-retry loop: the capture job can take ~30 minutes,
146152
# during which other commits routinely land on main. Without

.github/workflows/showcase_deploy.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,14 @@ jobs:
168168
- 'showcase/packages/*/manifest.yaml'
169169
shell_dashboard:
170170
- 'showcase/shell-dashboard/**'
171+
- 'showcase/shared/**'
172+
- 'showcase/scripts/**'
173+
- 'showcase/packages/*/manifest.yaml'
171174
shell_docs:
172175
- 'showcase/shell-docs/**'
176+
- 'showcase/shared/**'
177+
- 'showcase/scripts/**'
178+
- 'showcase/packages/*/manifest.yaml'
173179
174180
- name: Build service matrix
175181
id: build-matrix

showcase/tests/e2e/integration-smoke.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616

1717
import { test, expect } from "@playwright/test";
1818
import { checkHealth, checkAgentEndpoint, sendChatMessage } from "./helpers";
19+
// Generated by showcase/scripts/generate-registry.ts — must run `npm run build`
20+
// in showcase/shell (or run the generator directly) before this test can import the file.
1921
import registry from "../../shell/src/data/registry.json";
2022
import localPorts from "../../shared/local-ports.json";
2123

0 commit comments

Comments
 (0)