Skip to content

Commit dfeb061

Browse files
committed
fix(showcase/d6): drop turnIndex:0 from multi-turn goldfish agentic-chat fixtures
The aimock matcher gates turnIndex against the request's assistant-message count (assistantCount !== turnIndex → skip). The agno, spring-ai, and langgraph-fastapi agentic-chat fixtures baked turnIndex:0 on all three goldfish conversation turns. Turn 2+ carries >=1 assistant message, so turnIndex:0 could never match those turns — aimock returned no-match and the request fell through to proxy (503), failing the d6 cell. Mirror the canonical clean pattern used by the other 15 frameworks (langgraph-python et al.): omit turnIndex on the multi-turn conversation turns and disambiguate purely by userMessage. Single-turn fixtures in the same files keep turnIndex:0 (unchanged). Verified locally against the aimock matcher: turn-2 goes 404→200 for all three frameworks, turn-1 unregressed.
1 parent 078f97c commit dfeb061

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

showcase/aimock/d6/agno/agentic-chat.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,29 @@
77
},
88
"fixtures": [
99
{
10+
"_comment": "agentic-chat turn 1 — goldfish name. No turnIndex gate: the probe sends 3 sequential turns in one thread; turnIndex would restrict this to the first turn only, causing turns 2-3 to fall through to proxy.",
1011
"match": {
1112
"userMessage": "good name for a goldfish",
12-
"turnIndex": 0,
1313
"context": "agno"
1414
},
1515
"response": {
1616
"content": "How about Bubbles? It is friendly, classic, and easy to call out at the tank. If you want alternatives: Goldie, Finley, or Mango."
1717
}
1818
},
1919
{
20+
"_comment": "agentic-chat turn 2 — tank name. No turnIndex gate (multi-turn conversation).",
2021
"match": {
2122
"userMessage": "name for its tank",
22-
"turnIndex": 0,
2323
"context": "agno"
2424
},
2525
"response": {
2626
"content": "Following the Bubbles theme, you could call the tank The Bubble Bowl. It pairs naturally with the goldfish's name and keeps the playful tone."
2727
}
2828
},
2929
{
30+
"_comment": "agentic-chat turn 3 — recall. No turnIndex gate (multi-turn conversation).",
3031
"match": {
3132
"userMessage": "what we named the goldfish",
32-
"turnIndex": 0,
3333
"context": "agno"
3434
},
3535
"response": {

showcase/aimock/d6/langgraph-fastapi/agentic-chat.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,29 @@
77
},
88
"fixtures": [
99
{
10+
"_comment": "agentic-chat turn 1 — goldfish name. No turnIndex gate: the probe sends 3 sequential turns in one thread; turnIndex would restrict this to the first turn only, causing turns 2-3 to fall through to proxy.",
1011
"match": {
1112
"userMessage": "good name for a goldfish",
12-
"turnIndex": 0,
1313
"context": "langgraph-fastapi"
1414
},
1515
"response": {
1616
"content": "How about Bubbles? It is friendly, classic, and easy to call out at the tank. If you want alternatives: Goldie, Finley, or Mango."
1717
}
1818
},
1919
{
20+
"_comment": "agentic-chat turn 2 — tank name. No turnIndex gate (multi-turn conversation).",
2021
"match": {
2122
"userMessage": "name for its tank",
22-
"turnIndex": 0,
2323
"context": "langgraph-fastapi"
2424
},
2525
"response": {
2626
"content": "Following the Bubbles theme, you could call the tank The Bubble Bowl. It pairs naturally with the goldfish's name and keeps the playful tone."
2727
}
2828
},
2929
{
30+
"_comment": "agentic-chat turn 3 — recall. No turnIndex gate (multi-turn conversation).",
3031
"match": {
3132
"userMessage": "what we named the goldfish",
32-
"turnIndex": 0,
3333
"context": "langgraph-fastapi"
3434
},
3535
"response": {

showcase/aimock/d6/spring-ai/agentic-chat.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,29 +7,29 @@
77
},
88
"fixtures": [
99
{
10+
"_comment": "agentic-chat turn 1 — goldfish name. No turnIndex gate: the probe sends 3 sequential turns in one thread; turnIndex would restrict this to the first turn only, causing turns 2-3 to fall through to proxy.",
1011
"match": {
1112
"userMessage": "good name for a goldfish",
12-
"turnIndex": 0,
1313
"context": "spring-ai"
1414
},
1515
"response": {
1616
"content": "How about Bubbles? It is friendly, classic, and easy to call out at the tank. If you want alternatives: Goldie, Finley, or Mango."
1717
}
1818
},
1919
{
20+
"_comment": "agentic-chat turn 2 — tank name. No turnIndex gate (multi-turn conversation).",
2021
"match": {
2122
"userMessage": "name for its tank",
22-
"turnIndex": 0,
2323
"context": "spring-ai"
2424
},
2525
"response": {
2626
"content": "Following the Bubbles theme, you could call the tank The Bubble Bowl. It pairs naturally with the goldfish's name and keeps the playful tone."
2727
}
2828
},
2929
{
30+
"_comment": "agentic-chat turn 3 — recall. No turnIndex gate (multi-turn conversation).",
3031
"match": {
3132
"userMessage": "what we named the goldfish",
32-
"turnIndex": 0,
3333
"context": "spring-ai"
3434
},
3535
"response": {

0 commit comments

Comments
 (0)