fix(showcase): canonicalize build-result service names (trim) + reject array payloads

Author: jpr5

showcase/scripts/lib/__tests__/build-outputs.test.ts

@@ -139,6 +139,46 @@ describe("mergeBuildResultFiles", () => {
     expect(() => mergeBuildResultFiles(slotPayloads)).toThrow(/duplicate/i);
     expect(() => mergeBuildResultFiles(slotPayloads)).toThrow(/dup/);
   });
+
+  it("normalizes trailing whitespace in service to its trimmed canonical form", () => {
+    const result = mergeBuildResultFiles([
+      '{"service":"foo ","status":"success"}',
+    ]);
+    expect(result).toEqual([{ service: "foo", status: "success" }]);
+  });
+
+  it("normalizes leading whitespace in service to its trimmed canonical form", () => {
+    const result = mergeBuildResultFiles([
+      '{"service":" foo","status":"success"}',
+    ]);
+    expect(result).toEqual([{ service: "foo", status: "success" }]);
+  });
+
+  it("parseBuildOutputs also returns the trimmed canonical service", () => {
+    const json = JSON.stringify([{ service: "  bar  ", status: "success" }]);
+    expect(parseBuildOutputs(json)).toEqual([
+      { service: "bar", status: "success" },
+    ]);
+  });
+
+  it("detects duplicates that differ only by surrounding whitespace", () => {
+    const slotPayloads = [
+      '{"service":"foo","status":"failure"}',
+      '{"service":"foo ","status":"success"}',
+    ];
+    expect(() => mergeBuildResultFiles(slotPayloads)).toThrow(/duplicate/i);
+    expect(() => mergeBuildResultFiles(slotPayloads)).toThrow(/foo/);
+  });
+
+  it("rejects an array payload with a clear 'expected object' error (not 'missing service')", () => {
+    expect(() => mergeBuildResultFiles(["[]"])).toThrow(/expected object/i);
+    expect(() => mergeBuildResultFiles(["[]"])).not.toThrow(/missing/i);
+  });
+
+  it("parseBuildOutputs rejects an array nested as an entry with 'expected object'", () => {
+    const bad = JSON.stringify([[]]);
+    expect(() => parseBuildOutputs(bad)).toThrow(/expected object/i);
+  });
 });
 
 describe("shouldRedeployStaging", () => {

showcase/scripts/lib/build-outputs.ts

@@ -17,22 +17,18 @@
  */
 
 // Single source of truth for the set of valid build outcomes. The
-// `as const` tuple drives BOTH the compile-time `BuildOutcome` union
-// AND the runtime `VALID_STATUSES` set, so adding a status in one
-// place is enforced in the other. The exhaustiveness check below
-// guarantees the tuple and the union stay in lockstep.
+// `as const` tuple drives BOTH the runtime `VALID_STATUSES` set AND
+// the compile-time `BuildOutcome` union (derived via indexed access
+// below), so the tuple is the only place a status needs to be added.
+// Since `BuildOutcome` is derived from this tuple there is no separate
+// union that could drift out of sync — no redundant exhaustiveness
+// assertion is needed.
 const BUILD_OUTCOMES = ["success", "failure", "skipped"] as const;
 
 export type BuildOutcome = (typeof BUILD_OUTCOMES)[number];
 
 const VALID_STATUSES: ReadonlySet<BuildOutcome> = new Set(BUILD_OUTCOMES);
 
-// Compile-time exhaustiveness check: if BuildOutcome ever drifts from
-// the BUILD_OUTCOMES tuple (e.g. a hand-edited union), this assignment
-// will fail to typecheck.
-const _exhaustive: ReadonlyArray<BuildOutcome> = BUILD_OUTCOMES;
-void _exhaustive;
-
 export interface ServiceBuildResult {
   service: string;
   status: BuildOutcome;
@@ -55,7 +51,7 @@ function validateServiceBuildResult(
   raw: unknown,
   contextLabel: string,
 ): ServiceBuildResult {
-  if (typeof raw !== "object" || raw === null) {
+  if (typeof raw !== "object" || raw === null || Array.isArray(raw)) {
     throw new Error(
       `${contextLabel}: expected object with {service, status}, got ${JSON.stringify(raw)}`,
     );
@@ -66,7 +62,8 @@ function validateServiceBuildResult(
       `${contextLabel}: missing required string field "service": ${JSON.stringify(raw)}`,
     );
   }
-  if (service.trim().length === 0) {
+  const trimmedService = service.trim();
+  if (trimmedService.length === 0) {
     throw new Error(
       `${contextLabel}: field "service" must be a non-empty, non-whitespace string: ${JSON.stringify(raw)}`,
     );
@@ -80,7 +77,7 @@ function validateServiceBuildResult(
       `${contextLabel}: invalid "status" (must be success|failure|skipped): ${JSON.stringify(raw)}`,
     );
   }
-  return { service, status: status as BuildOutcome };
+  return { service: trimmedService, status: status as BuildOutcome };
 }
 
 export function parseBuildOutputs(raw: string): ServiceBuildResult[] {