fix(react-core): address CR-loop findings on IntelligenceIndicator

Round-1 review on the indicator branch surfaced perf and defensive
hardening items. Tests: react-core 1158 — all green.

- CopilotChatMessageView auto-mount now gates on
  `message.role === "assistant"` in addition to
  `copilotkit.intelligence !== undefined`. Eliminates wasted
  `useAgent` subscriptions, 200 ms polling intervals, and four
  `useEffect`s on every user / activity / reasoning slot — the
  indicator's own role gate would short-circuit anyway, but only
  after a subscribe + interval-set + cleanup cycle on every render.

- IntelligenceIndicator's `toolCalls` access is now defensive:
  `Array.isArray(...)` guard and `tc?.function?.name` chain. A
  malformed agent payload no longer crashes the chat tree at
  `.some(...)`.

Comment fixes:

- CopilotChatMessageView: stale `CopilotKitProvider.intelligenceIndicator.e2e.test.tsx`
  reference updated to the actual path
  `intelligence-indicator/__tests__/IntelligenceIndicator.e2e.test.tsx`.

- IntelligenceIndicator `ISRUNNING_POLL_MS` JSDoc rewritten — the
  prior version claimed `addMessage` iterates subscribers live during
  streaming. In fact AG-UI's `runAgent` snapshots subscribers and
  threads them through the entire pipeline (including
  `processApplyEvents` for streaming events), so a late-mounted
  subscriber misses both `onMessagesChanged` AND `onRunFinalized`
  from the run's pipeline. The poll fallback is the only thing that
  catches the falling edge.

- `globals.css` pill-styles port comment listed `#BEC2FF` as part of
  the palette but that hex doesn't appear anywhere in the rules.
  Updated to the actual swatches: text #5B21B6, icon #7C3AED, border
  #9599E0, gradient #EEE6FE, shadow #5E64AD.

Author: mme

packages/react-core/src/v2/components/chat/CopilotChatMessageView.tsx

@@ -330,8 +330,8 @@ const MemoizedCustomMessage = React.memo(
     // before runAgent fires) won't observe the false→true transition for
     // the first run. In practice this is rare; the canonical pattern is
     // to gate on the slot's own runId membership (see
-    // CopilotKitProvider.intelligenceIndicator.e2e.test.tsx for the
-    // recommended renderer shape).
+    // intelligence-indicator/__tests__/IntelligenceIndicator.e2e.test.tsx
+    // for the recommended renderer shape).
     if (
       nextProps.isInLatestRun &&
       prevProps.isRunning !== nextProps.isRunning
@@ -699,12 +699,17 @@ export function CopilotChatMessageView({
       );
     }
 
-    // Auto-mount the IntelligenceIndicator for every message slot when
-    // the runtime is in intelligence mode. The component self-gates so
-    // only the canonical slot (last message of latest in-flight run
-    // containing a matching tool call) actually renders a pill — every
-    // other invocation returns null.
-    if (copilotkit.intelligence !== undefined) {
+    // Auto-mount the IntelligenceIndicator on assistant message slots
+    // when the runtime is in intelligence mode. The component self-gates
+    // further (last in run, latest run, matching tool call) so only one
+    // pill renders at a time — but mounting it only for assistant
+    // messages avoids spinning up a `useAgent` subscription, a 200 ms
+    // poll interval, and four effects on every user/reasoning/activity
+    // slot just to have it return null at the role gate.
+    if (
+      copilotkit.intelligence !== undefined &&
+      message.role === "assistant"
+    ) {
       elements.push(
         <IntelligenceIndicator
           key={`${message.id}-intelligence`}

packages/react-core/src/v2/components/intelligence-indicator/IntelligenceIndicator.tsx

@@ -23,15 +23,19 @@ const CHECK_HOLD_MS = 800;
 const FADE_OUT_ANIMATION_MS = 480;
 
 /**
- * Polling interval for `agent.isRunning`. Background: AG-UI's
- * `runAgent` snapshots `[...this.subscribers]` at invocation time, so a
- * subscriber added AFTER the run starts — which is always the case here
- * since the renderer mounts when the matching message appears INSIDE
- * the run — is missing from that snapshot and never sees the falling
- * edge. `onMessagesChanged` works because `addMessage` iterates
- * subscribers live, but it stops firing once streaming ends, leaving
- * the renderer stuck on its last view of `isRunning=true`. A 200 ms
- * poll closes the gap.
+ * Polling interval for `agent.isRunning`. Background: AG-UI's `runAgent`
+ * snapshots `[...this.subscribers]` at invocation time and threads that
+ * snapshot through the entire run pipeline (including the `finalize`
+ * block that fires `onRunFinalized` and flips `isRunning` off). A
+ * subscriber added AFTER `runAgent` starts — which is always the case
+ * here, because the renderer mounts when the matching message first
+ * appears INSIDE the run — is missing from that snapshot and never
+ * receives the falling edge.
+ *
+ * Re-renders driven by parent state still keep the pill alive while
+ * messages stream, but `agent.isRunning` only flips off via the
+ * snapshotted set. A 200 ms poll reads the live property and forces a
+ * re-render when it changes, closing the gap.
  */
 const ISRUNNING_POLL_MS = 200;
 
@@ -167,10 +171,17 @@ export function IntelligenceIndicator(
 
   // Must be an assistant message with at least one matching tool call.
   if (message.role !== "assistant") return null;
-  const toolCalls = message.toolCalls ?? [];
-  const hasMatch = toolCalls.some((tc) =>
-    DEFAULT_TOOL_PATTERNS.some((p) => p.test(tc.function.name)),
-  );
+  // Defensive: a malformed `toolCalls` (non-array, missing nested
+  // `function.name`) would otherwise throw inside `.some(...)` and take
+  // down the chat tree. Treat as "no match" instead.
+  const toolCalls = Array.isArray(message.toolCalls) ? message.toolCalls : [];
+  const hasMatch = toolCalls.some((tc) => {
+    const name = tc?.function?.name;
+    return (
+      typeof name === "string" &&
+      DEFAULT_TOOL_PATTERNS.some((p) => p.test(name))
+    );
+  });
   if (!hasMatch) return null;
 
   // The message must belong to the latest run on the thread, AND must

packages/react-core/src/v2/styles/globals.css

@@ -233,7 +233,8 @@
  * IntelligenceIndicator pill — visual styles ported from
  * CopilotKit/Intelligence #155.
  *
- * Color palette: violet/indigo glassmorphism (#BEC2FF / #9599E0 / #EEE6FE).
+ * Violet/indigo glassmorphism — text #5B21B6, icon #7C3AED, border
+ * #9599E0, gradient stop #EEE6FE, soft shadow #5E64AD.
  */
 .cpk-intelligence-pill {
   display: inline-flex;