chore: migrate from husky to lefthook and fix angular tests

- Replace husky with lefthook for git hooks management
- Pre-commit runs lint --fix, format, test, and check:packages in parallel
  with auto-staging of fixes via stage_fixed
- Commit-msg runs commitlint
- Add dependsOn ^build to test target in nx.json so dependencies are
  built before tests run
- Upgrade @analogjs/vite-plugin-angular and @analogjs/vitest-angular
  from ^1.20.2 to ^2.2.3 for vite 7 compatibility
- Add pnpm packageExtensions to declare missing vite peer dependency
  on @analogjs/vite-plugin-angular
- Fix lint issues: let -> const in agent and react packages
- Disable nx TUI in pre-commit hooks via NX_TUI env var

Author: AlemTuzlak

.husky/commit-msg

@@ -0,0 +1,21 @@
+pre-commit:
+  parallel: true
+  commands:
+    lint-fix:
+      env:
+        NX_TUI: "false"
+      run: pnpm run lint --fix && pnpm run format
+      stage_fixed: true
+    test:
+      env:
+        NX_TUI: "false"
+      run: pnpm run test
+    check-packages:
+      env:
+        NX_TUI: "false"
+      run: pnpm run check:packages
+
+commit-msg:
+  commands:
+    commitlint:
+      run: pnpm commitlint --edit {1}

lefthook.yml

@@ -40,6 +40,9 @@
       "cache": false
     },
     "test": {
+      "dependsOn": [
+        "^build"
+      ],
       "inputs": [
         "test"
       ],

nx.json

@@ -33,7 +33,7 @@
     "demo:next:angular": "nx run-many -t dev --projects=examples/v2/angular/demo,examples/v2/angular/demo-server",
     "demo:next:react": "pnpm -C examples/v2/react/demo dev",
     "changeset": "changeset",
-    "prepare": "husky",
+    "prepare": "lefthook install",
     "graph": "nx graph",
     "publint": "nx run-many -t publint --projects=packages/**",
     "attw": "nx run-many -t attw --projects=packages/**",
@@ -66,7 +66,7 @@
     "eslint": "^8.56.0",
     "eslint-config-custom": "workspace:*",
     "glob": "^10.3.12",
-    "husky": "^9.1.4",
+    "lefthook": "^2.1.1",
     "install": "^0.13.0",
     "npm": "^10.7.0",
     "nx": "^22.5.0",
@@ -109,6 +109,13 @@
     "publicHoistPattern": [
       "@ag-ui/*"
     ],
+    "packageExtensions": {
+      "@analogjs/vite-plugin-angular": {
+        "peerDependencies": {
+          "vite": "*"
+        }
+      }
+    },
     "patchedDependencies": {
       "@changesets/assemble-release-plan@6.0.9": "patches/@changesets__assemble-release-plan@6.0.9.patch"
     }

package.json

@@ -413,23 +413,23 @@ export function convertJsonSchemaToZodSchema(
         jsonSchema.required ? jsonSchema.required.includes(key) : false,
       );
     }
-    let schema = z.object(spec).describe(jsonSchema.description ?? "");
+    const schema = z.object(spec).describe(jsonSchema.description ?? "");
     return required ? schema : schema.optional();
   } else if (jsonSchema.type === "string") {
-    let schema = z.string().describe(jsonSchema.description ?? "");
+    const schema = z.string().describe(jsonSchema.description ?? "");
     return required ? schema : schema.optional();
   } else if (jsonSchema.type === "number" || jsonSchema.type === "integer") {
-    let schema = z.number().describe(jsonSchema.description ?? "");
+    const schema = z.number().describe(jsonSchema.description ?? "");
     return required ? schema : schema.optional();
   } else if (jsonSchema.type === "boolean") {
-    let schema = z.boolean().describe(jsonSchema.description ?? "");
+    const schema = z.boolean().describe(jsonSchema.description ?? "");
     return required ? schema : schema.optional();
   } else if (jsonSchema.type === "array") {
     if (!jsonSchema.items) {
       throw new Error("Array type must have items property");
     }
-    let itemSchema = convertJsonSchemaToZodSchema(jsonSchema.items, true);
-    let schema = z.array(itemSchema).describe(jsonSchema.description ?? "");
+    const itemSchema = convertJsonSchemaToZodSchema(jsonSchema.items, true);
+    const schema = z.array(itemSchema).describe(jsonSchema.description ?? "");
     return required ? schema : schema.optional();
   }
   console.error("Invalid JSON schema:", JSON.stringify(jsonSchema, null, 2));

packages/v2/agent/src/index.ts

@@ -46,8 +46,8 @@
     "rxjs": "^7.8.0"
   },
   "devDependencies": {
-    "@analogjs/vite-plugin-angular": "^1.20.2",
-    "@analogjs/vitest-angular": "^1.20.2",
+    "@analogjs/vite-plugin-angular": "^2.2.3",
+    "@analogjs/vitest-angular": "^2.2.3",
     "@angular/cdk": "^18.0.0",
     "@angular/common": "^18.0.0",
     "@angular/compiler": "^18.0.0",

packages/v2/angular/package.json

@@ -30,7 +30,6 @@ import {
 describe("useFrontendTool E2E - Dynamic Registration", () => {
   describe("Minimal dynamic registration without chat run", () => {
     it("registers tool and renders tool call via ToolCallsView", async () => {
-      // eslint-disable-next-line no-console
       // No agent run; we render ToolCallsView directly
       const DynamicToolComponent: React.FC = () => {
         const tool: ReactFrontendTool<{ message: string }> = {
@@ -1905,7 +1904,7 @@ describe("useFrontendTool E2E - Dynamic Registration", () => {
   describe("Wildcard Handler", () => {
     it("should handle unknown tools with wildcard", async () => {
       const agent = new MockStepwiseAgent();
-      let wildcardHandlerCalls: { name: string; args: any }[] = [];
+      const wildcardHandlerCalls: { name: string; args: any }[] = [];
 
       // Note: Wildcard tools work as fallback renderers when no specific tool is found
       // The wildcard renderer receives the original tool name and arguments