Skip to content

Commit f4e3ee6

Browse files
committed
fix(shell-docs): correct REB2B var name (was RB2B_ID, code reads REB2B_KEY)
The previous commit used `NEXT_PUBLIC_RB2B_ID` based on a stale entry in the cutover plan doc, but `app/layout.tsx:86` reads `NEXT_PUBLIC_REB2B_KEY`. Without this fix the build-arg would be piped under the wrong name and the REB2B Script tag would still not render.
1 parent 6eba49c commit f4e3ee6

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/showcase_build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ jobs:
304304
# inlined into client JS chunks. Sourced from repo secrets;
305305
# Railway runtime env doesn't reach this build step.
306306
ARGS="${ARGS:+${ARGS}$'\n'}NEXT_PUBLIC_POSTHOG_KEY=${{ secrets.POSTHOG_PROJECT_KEY }}"
307-
ARGS="${ARGS:+${ARGS}$'\n'}NEXT_PUBLIC_RB2B_ID=${{ secrets.RB2B_ID }}"
307+
ARGS="${ARGS:+${ARGS}$'\n'}NEXT_PUBLIC_REB2B_KEY=${{ secrets.REB2B_KEY }}"
308308
ARGS="${ARGS:+${ARGS}$'\n'}NEXT_PUBLIC_SCARF_PIXEL_ID=${{ secrets.SCARF_PIXEL_ID }}"
309309
ARGS="${ARGS:+${ARGS}$'\n'}NEXT_PUBLIC_REO_KEY=${{ secrets.REO_PROJECT_KEY }}"
310310
ARGS="${ARGS:+${ARGS}$'\n'}NEXT_PUBLIC_GOOGLE_ANALYTICS_TRACKING_ID=${{ secrets.GOOGLE_ANALYTICS_TRACKING_ID }}"

showcase/shell-docs/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ ENV NEXT_PUBLIC_BASE_URL=${NEXT_PUBLIC_BASE_URL}
1212
# no-op in the browser.
1313
ARG NEXT_PUBLIC_POSTHOG_KEY
1414
ENV NEXT_PUBLIC_POSTHOG_KEY=${NEXT_PUBLIC_POSTHOG_KEY}
15-
ARG NEXT_PUBLIC_RB2B_ID
16-
ENV NEXT_PUBLIC_RB2B_ID=${NEXT_PUBLIC_RB2B_ID}
15+
ARG NEXT_PUBLIC_REB2B_KEY
16+
ENV NEXT_PUBLIC_REB2B_KEY=${NEXT_PUBLIC_REB2B_KEY}
1717
ARG NEXT_PUBLIC_SCARF_PIXEL_ID
1818
ENV NEXT_PUBLIC_SCARF_PIXEL_ID=${NEXT_PUBLIC_SCARF_PIXEL_ID}
1919
ARG NEXT_PUBLIC_REO_KEY

0 commit comments

Comments
 (0)