Skip to content

Commit f773c51

Browse files
committed
fix(showcase): gate starter smoke tests on integration.deployed
The STARTERS filter in integration-smoke.spec.ts gated on `i.starter?.deployed === true`, but the manifest→registry bundler (showcase/scripts/bundle-demo-content.ts + generate-registry.ts) does not carry that field forward from the source YAML manifests. At registry regen time (commit 14537d8), all `starter.deployed` values were dropped. Result: the filter matched zero entries, `Deployed Starters` yielded no tests, and the starter-deployed-smoke CI workflow has failed on every run (>15 consecutive reds starting 2026-04-18) with Playwright erroring `No tests found.` against `--grep "@starter-health|@starter-agent|@starter-chat"`. Switch to integration-level `i.deployed`, which is the single deployment flag the registry actually carries and which the INTEGRATIONS array in the same file already uses for its own gating. This keeps both filters anchored to the same source of truth. Verified locally: `--grep "@starter-health|@starter-agent|@starter-chat" --list` now discovers 17 tests (one per deployed integration).
1 parent d4e7595 commit f773c51

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

showcase/tests/e2e/integration-smoke.spec.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,6 +371,15 @@ type RegistryIntegration = (typeof registry)["integrations"][number];
371371

372372
const STARTER_SLUG = process.env.STARTER_SLUG;
373373

374+
// Registry uses integration-level `deployed` as the single deployment flag.
375+
// An earlier iteration had `starter.deployed` as a per-starter override, but
376+
// the manifest→registry bundler (showcase/scripts/bundle-demo-content.ts +
377+
// generate-registry.ts) doesn't carry that field forward from the source YAML
378+
// manifests, so any value written there is dropped on regen. Gating on
379+
// `i.deployed === true` matches how the INTEGRATIONS array above filters
380+
// `activeIntegrations` and keeps both filters anchored to the same source of
381+
// truth. Without this, the Deployed Starters describe block yields zero tests
382+
// and Playwright's --grep fails with "No tests found."
374383
const STARTERS: Starter[] = registry.integrations
375384
.filter(
376385
(
@@ -380,7 +389,7 @@ const STARTERS: Starter[] = registry.integrations
380389
} =>
381390
Boolean(i.starter?.demo_url) &&
382391
(!STARTER_SLUG || i.slug === STARTER_SLUG) &&
383-
(SMOKE_ALL || i.starter?.deployed === true),
392+
(SMOKE_ALL || i.deployed === true),
384393
)
385394
.map((i) => ({
386395
slug: i.slug,

0 commit comments

Comments
 (0)