pullrequests Search Results · user:sindresorhus language:swift archived:false is:public language:Swift language:JavaScript
Filter by
11.9k results
insindresorhus (press backspace or delete to remove)Splitting the regex makes it much easier to edit.
If this isn t well-liked, I propose one of:
- [ ] Have a build (even manual) so that you can edit this version but ship a regex literal
- [ ] Use ...
fregante
- Fixes https://github.com/sindresorhus/linkify-issues/issues/16
Blocked by:
- [x] #17
- [x] https://github.com/sindresorhus/issue-regex/pull/16
- Fixes #17
Blocked by:
- [x] #18
- [x] https://github.com/sindresorhus/issue-regex/pull/19
- Follows https://github.com/sindresorhus/linkify-urls/pull/44
This PR fixes a small bug when iterating over promise.stdout/promise.stderr and the stdout/stderr option is ignore (or
anything else but pipe).
ehmicky
This PR splits the source files into smaller files. This does not change the logic.
I advise using a more granular plugin dedicated to regex rather than a single better regex rule:
https://github.com/gmullerb/eslint-plugin-regex
- Closes https://github.com/sindresorhus/eslint-plugin-unicorn/issues/2409 ...
On Windows, we need to know whether the binary is a .exe or .com file. If not, cmd.exe must be used.
To do that detection, we check for .exe or .com files within the current PATH environment variable, ...
nanoSpawn(...).stdout must be iterated right away. Otherwise, nano-spawn will already have started buffering the output,
which conflicts with the iteration.
This PR adds some tests covering this.
This is a tiny improvement of some logic related to handling errors thrown in a for await (const line of nanoSpawn(...))
{ ... } loop.