pullrequests Search Results · user:sindresorhus language:swift archived:false is:public language:Swift is:merged
Filter by
319 results
insindresorhus (press backspace or delete to remove)We don t need to set both. According to comments in the Obj-C headers:
/*
A URL identifying the item on which progress is being made. This is required for any NSProgress that is published using -publish ...
sindresorhus
NSTextField#textColor is not animatable, so I had to be creative. Happy to consider less hacky solutions.
Here is the Proof of concept I mentioned in https://github.com/sindresorhus/gifski-app/pull/9#discussion_r171176503..
I don t like how I have to unpublish in each error case. Could maybe create a wrapper ...
LarsJK
These are the changes I suggested in my review of #6
I made some changes to the progress handling as well. Let me know if you want me to split up this PR. Need some more
work on the error handling..
...
So progress is shown in Finder.
Using the Progress type also simplifies the code and paves the way for cancelation.
@kornelski Can you comment what info you want your copyright statement to include?
This should make it noticeably faster. However, it s a bit hacky since it needs to link with GCC s library, which brew
puts wherever it wants. Maybe it could be improved with injection of brew --prefix ...
kornelski
Updated code to use UIAlertController instead of UIAlertView.
ranesr