Skip to content

pullrequests Search Results · user:sindresorhus language:swift archived:false is:public

Filter by

419 results  (245 ms)

419 results

insindresorhus (press backspace or delete to remove)

sindresorhus/Gifski
Fix off-by-one error and ensure Gifski completion handler is only called once

I introduced an off-by-one error in 8a764ad695b097cf99356735a9653dd11f0ab1ef. It was only noticeable when trying to convert the video in https://github.com/sindresorhus/gifski-app/issues/46, which is why ...
  • sindresorhus
  • 11
  • Opened 
    on Jan 25, 2019
  • #56

sindresorhus/Gifski
Finish progress based on `isFinished` instead of `fractionCompleted`

Fixes #46 It sounds like the behavior you described could be caused by some kind of rounding issue. To rule that out I observe the .isFinished property in addition to .fractionCompleted to definitively ...
  • boyvanamstel
  • 7
  • Opened 
    on Jan 24, 2019
  • #55

sindresorhus/CircularProgress
Add ability to cancel the progress

Brings over the cancel functionality added to Gifski recently. cancel I chose to copy over the CustomButton verbatim. Using it here might help fleshing out how it should behave as a standalone component ...
  • boyvanamstel
  • 20
  • Opened 
    on Jan 23, 2019
  • #4

sindresorhus/CircularProgress
Fix scaling in Interface Builder

As requested in https://github.com/sindresorhus/CircularProgress/issues/2. ~This keeps the aspect ratio by adding a layout constraint specifically for IB.~ ✨ The layout constraint is no longer necessary ...
  • boyvanamstel
  • 2
  • Opened 
    on Jan 22, 2019
  • #3

sindresorhus/Gifski
Tweak custom button color generator setter

See https://github.com/sindresorhus/gifski-app/pull/50#pullrequestreview-194865256 Allows for $0.setColorGenerator(for: \.backgroundColor, nil) to be used, making the removeGenerator(for keyPath:) method ...
  • boyvanamstel
  • 4
  • Opened 
    on Jan 22, 2019
  • #54

sindresorhus/Gifski
Add cancel feature

Fixes #5 I experimented with a few solutions, before ending up with what I m submitting now. (Feel free to squash the commit if that s more appropriate.) The window maintains its minimalist look and ...
  • boyvanamstel
  • 66
  • Opened 
    on Jan 17, 2019
  • #50

sindresorhus/Gifski
Add predefined size dropdown in the save panel

Add predefined size dropdown. go2 Fixes #36 !-- Issuehunt content -- details summary b IssueHunt Summary /b /summary IssueHunt has been backed by the following sponsors. Become a sponsor /details ...
  • ShamsAlDinShakuntala
  • 24
  • Opened 
    on Jan 17, 2019
  • #49

sindresorhus/Gifski
Use `Result` type

This makes generateCGImagesAsynchronously method use a Result type. I was not sure whether or not to model the cancelled state as success or error.
  • sindresorhus
  • 12
  • Opened 
    on Jan 15, 2019
  • #45

sindresorhus/DockProgress
Add `badge` circle style

Hi, I implemented #3 and updated the example to loop through it as well. Let me know if there are any things you d like me to change or fix. The badgeLabel only allows for 3 characters though, after ...
  • JoniVR
  • 48
  • Opened 
    on Jan 13, 2019
  • #7

sindresorhus/Gifski
Add initial `Show in Finder` button

This is how it looks: img width= 472 alt= screen shot 2018-12-27 at 00 31 09 src= https://user-images.githubusercontent.com/170270/50459761-fac86380-096e-11e9-913d-56766ac4c0da.png It looks a bit empty, ...
  • sindresorhus
  • 2
  • Opened 
    on Dec 26, 2018
  • #43