Skip to content

pullrequests Search Results · user:sindresorhus language:swift archived:false is:public language:Swift language:HTML

Filter by

508 results  (228 ms)

508 results

insindresorhus (press backspace or delete to remove)

sindresorhus/Gifski
Use my own progress indicator

And some other tweaks.
  • sindresorhus
  • 1
  • Opened 
    on Mar 13, 2018
  • #24

sindresorhus/Gifski
Dark UI improvements

The alert and open/save dialogs are now dark too! img width= 532 alt= screen shot 2018-03-12 at 00 21 21 src= https://user-images.githubusercontent.com/170270/37256336-a96c6760-258b-11e8-8489-e210f451c6e8.png ...
  • sindresorhus
  • 2
  • Opened 
    on Mar 11, 2018
  • #21

sindresorhus/Gifski
Move view/model code out of AppDelegate into a WindowController

I thought the AppDelegate had to many responsibilities, so I moved a lot of the code into a WindowController. I m not sure what best practice is with handling menu item actions, but I changed the open ...
  • LarsJK
  • 22
  • Opened 
    on Mar 7, 2018
  • #20

sindresorhus/Gifski
Drop the `fileURLKey`

We don t need to set both. According to comments in the Obj-C headers: /* A URL identifying the item on which progress is being made. This is required for any NSProgress that is published using -publish ...
  • sindresorhus
  • Opened 
    on Mar 6, 2018
  • #19

sindresorhus/Gifski
Animate the drag-n-drop text color

NSTextField#textColor is not animatable, so I had to be creative. Happy to consider less hacky solutions.
  • sindresorhus
  • 6
  • Opened 
    on Mar 5, 2018
  • #18

sindresorhus/Gifski
Use a static func to convert instead of instance method

Here is the Proof of concept I mentioned in https://github.com/sindresorhus/gifski-app/pull/9#discussion_r171176503.. I don t like how I have to unpublish in each error case. Could maybe create a wrapper ...
  • LarsJK
  • 28
  • Opened 
    on Feb 28, 2018
  • #16

sindresorhus/Gifski
Link OpenMP runtime statically

Fixes #11
  • kornelski
  • 7
  • Opened 
    on Feb 26, 2018
  • #13

sindresorhus/Gifski
Add thin class wrapper around the gifski api

These are the changes I suggested in my review of #6 I made some changes to the progress handling as well. Let me know if you want me to split up this PR. Need some more work on the error handling.. ...
  • LarsJK
  • 29
  • Opened 
    on Feb 25, 2018
  • #9

sindresorhus/Gifski
Report progress to the system

So progress is shown in Finder. Using the Progress type also simplifies the code and paves the way for cancelation.
  • sindresorhus
  • 7
  • Opened 
    on Feb 23, 2018
  • #6

sindresorhus/Gifski
Add license file

@kornelski Can you comment what info you want your copyright statement to include?
  • sindresorhus
  • Opened 
    on Feb 22, 2018
  • #3