refactor: remove get and set from config for native access

If there are any manipulations that need to happen they can be in the setup() method

Author: AntoineGS

lua/copilot/client.lua

@@ -161,7 +161,7 @@ local function get_handlers()
   }
 
   -- optional handlers
-  local logger_conf = config.get("logger") --[[@as copilot_config_logging]]
+  local logger_conf = config.config.logger
   if logger_conf.trace_lsp ~= "off" then
     handlers = vim.tbl_extend("force", handlers, {
       ["$/logTrace"] = logger.handle_lsp_trace,
@@ -233,7 +233,7 @@ local function prepare_client_config(overrides)
     },
   }
 
-  local config_workspace_folders = config.get("workspace_folders") --[[@as table<string>]]
+  local config_workspace_folders = config.config.workspace_folders
 
   for _, config_workspace_folder in ipairs(config_workspace_folders) do
     if config_workspace_folder ~= "" then
@@ -249,7 +249,7 @@ local function prepare_client_config(overrides)
   end
 
   local editor_info = util.get_editor_info()
-  local provider_url = config.get("auth_provider_url") --[[@as string|nil]]
+  local provider_url = config.config.auth_provider_url
   local proxy_uri = vim.g.copilot_proxy
 
   local settings = { ---@type copilot_settings
@@ -296,7 +296,7 @@ local function prepare_client_config(overrides)
         logger.trace("workspace configuration", configurations)
 
         -- to activate tracing if we want it
-        local logger_conf = config.get("logger") --[[@as copilot_config_logging]]
+        local logger_conf = config.config.logger
         local trace_params = { value = logger_conf.trace_lsp } --[[@as copilot_nofify_set_trace_params]]
         api.notify_set_trace(client, trace_params)
 
@@ -325,14 +325,13 @@ local function prepare_client_config(overrides)
     },
     settings = settings,
     workspace_folders = workspace_folders,
-    trace = config.get("trace") or "off",
   }, overrides)
 end
 
 function M.setup()
-  M.should_attach = config.get("should_attach") --[[@as copilot_should_attach|nil]]
-  local server_config = config.get("server") --[[@as copilot_config_server]]
-  local node_command = config.get("copilot_node_command") --[[@as string|nil]]
+  M.should_attach = config.config.should_attach
+  local server_config = config.config.server
+  local node_command = config.config.copilot_node_command
   M.server = vim.tbl_deep_extend("force", M.server, server_config)
 
   if M.server.custom_server_filepath then
@@ -345,7 +344,7 @@ function M.setup()
     lsp_binary.setup(M.server.custom_server_filepath)
   end
 
-  M.config = prepare_client_config(config.get("server_opts_overrides"))
+  M.config = prepare_client_config(config.config.server_opts_overrides)
 
   if not M.config then
     is_disabled = true
@@ -399,7 +398,7 @@ function M.add_workspace_folder(folder_path)
     name = folder_path,
   }
 
-  local workspace_folders = config.get("workspace_folders") --[[@as table<string>]]
+  local workspace_folders = config.config.workspace_folders
   if not workspace_folders then
     workspace_folders = {}
   end

lua/copilot/config.lua

@@ -94,47 +94,10 @@ function mod.setup(opts)
     return mod.config
   end
 
-  local config = vim.tbl_deep_extend("force", default_config, opts or {})
-
-  --- for backward compatibility
-  if config.ft_disable then
-    for _, disabled_ft in ipairs(config.ft_disable) do
-      config.filetypes[disabled_ft] = false
-    end
-
-    config.ft_disable = nil
-  end
-
-  mod.config = config
-
+  mod.config = vim.tbl_deep_extend("force", default_config, opts or {})
   return mod.config
 end
 
----@param key? string
-function mod.get(key)
-  if not mod.config then
-    logger.error("not initialized")
-    return
-  end
-
-  if key then
-    return mod.config[key]
-  end
-
-  return mod.config
-end
-
----@param key string
----@param value any
-function mod.set(key, value)
-  if not mod.config then
-    logger.error("not initialized")
-    return
-  end
-
-  mod.config[key] = value
-end
-
 function mod.get_root_dir()
   if not mod.config then
     error("[Copilot] not initialized")

lua/copilot/panel.lua

@@ -567,7 +567,7 @@ function mod.open(layout)
 end
 
 function mod.setup()
-  local opts = config.get("panel") --[[@as copilot_config_panel]]
+  local opts = config.config.panel
   if not opts.enabled then
     return
   end
@@ -592,7 +592,7 @@ function mod.setup()
 end
 
 function mod.teardown()
-  local opts = config.get("panel") --[[@as copilot_config_panel]]
+  local opts = config.config.panel
   if not opts.enabled then
     return
   end

lua/copilot/suggestion.lua

@@ -700,7 +700,7 @@ local function create_autocmds()
 end
 
 function mod.setup()
-  local opts = config.get("suggestion") --[[@as copilot_config_suggestion]]
+  local opts = config.config.suggestion
   if not opts.enabled then
     return
   end
@@ -721,7 +721,7 @@ function mod.setup()
 end
 
 function mod.teardown()
-  local opts = config.get("suggestion") --[[@as copilot_config_suggestion]]
+  local opts = config.config.suggestion
   if not opts.enabled then
     return
   end

lua/copilot/util.lua

@@ -90,7 +90,7 @@ end
 ---@return boolean should_attach
 ---@return string? no_attach_reason
 function M.should_attach()
-  local ft = config.get("filetypes") --[[@as table<string, boolean>]]
+  local ft = config.config.filetypes
   local ft_disabled, ft_disabled_reason = is_ft_disabled(vim.bo.filetype, ft)
 
   if ft_disabled then
@@ -169,8 +169,7 @@ end
 
 ---@return copilot_workspace_configurations
 function M.get_workspace_configurations()
-  local conf = config.get() --[[@as copilot_config]]
-
+  local conf = config.config
   local filetypes = vim.deepcopy(conf.filetypes) --[[@as table<string, boolean>]]
 
   if filetypes["*"] == nil then