refactor(types): Improve type safety of STANDARD_SHAPES

Centralized the definition of `STANDARD_SHAPE_SPECS` in the `ums-lib` package and improved its type definition by using `as const`.

This change eliminates an unsafe `as unknown as string[]` type assertion by providing more specific, readonly types for the shape specifications. It also removes the duplicated `STANDARD_SHAPES` constant from the `copilot-instructions-cli` package, which now relies on the single source of truth from `ums-lib`.

Author: google-labs-jules[bot]

packages/copilot-instructions-cli/src/constants.ts

@@ -40,39 +40,6 @@ export const RENDER_ORDER: DirectiveKey[] = [
   'examples',
 ];
 
-// Standard shapes as defined in UMS v1.0 Section 2.5
-export const STANDARD_SHAPES = {
-  specification: {
-    required: ['goal', 'constraints'],
-    optional: ['principles', 'examples'],
-  },
-  procedure: {
-    required: ['goal', 'process'],
-    optional: ['constraints', 'examples'],
-  },
-  pattern: {
-    required: ['goal', 'principles'],
-    optional: ['constraints', 'examples'],
-  },
-  checklist: {
-    required: ['goal', 'criteria'],
-    optional: ['examples'],
-  },
-  data: {
-    required: ['goal', 'data'],
-    optional: ['examples'],
-  },
-  'procedural-specification': {
-    required: ['goal', 'process', 'constraints'],
-    optional: ['criteria', 'examples'],
-  },
-  playbook: {
-    required: ['goal', 'process', 'constraints', 'criteria'],
-    optional: ['principles', 'examples', 'data'],
-  },
-} as const;
-
-export type StandardShape = keyof typeof STANDARD_SHAPES;
 
 // Schema version for UMS v1.0
 export const UMS_SCHEMA_VERSION = '1.0';

packages/ums-lib/src/constants.ts

@@ -50,35 +50,35 @@ export const MODULE_ID_REGEX =
 // Standard shape directive specifications (UMS v1.0 compliant)
 export const STANDARD_SHAPE_SPECS = {
   procedure: {
-    required: ['goal', 'process'] as string[],
-    optional: ['examples', 'data'] as string[],
+    required: ['goal', 'process'],
+    optional: ['examples', 'data'],
   },
   specification: {
-    required: ['goal', 'constraints'] as string[],
-    optional: ['examples', 'data'] as string[],
+    required: ['goal', 'constraints'],
+    optional: ['examples', 'data'],
   },
   pattern: {
-    required: ['goal', 'principles'] as string[],
-    optional: ['constraints', 'examples', 'data'] as string[],
+    required: ['goal', 'principles'],
+    optional: ['constraints', 'examples', 'data'],
   },
   checklist: {
-    required: ['goal', 'criteria'] as string[],
-    optional: ['examples', 'data'] as string[],
+    required: ['goal', 'criteria'],
+    optional: ['examples', 'data'],
   },
   data: {
-    required: ['goal', 'data'] as string[],
-    optional: ['examples'] as string[],
+    required: ['goal', 'data'],
+    optional: ['examples'],
   },
   'procedural-specification': {
-    required: ['goal', 'process', 'constraints'] as string[],
-    optional: ['examples', 'data'] as string[],
+    required: ['goal', 'process', 'constraints'],
+    optional: ['examples', 'data'],
   },
   'pattern-specification': {
-    required: ['goal', 'principles', 'constraints'] as string[],
-    optional: ['examples', 'data'] as string[],
+    required: ['goal', 'principles', 'constraints'],
+    optional: ['examples', 'data'],
   },
   playbook: {
-    required: ['goal', 'process', 'constraints', 'criteria'] as string[],
-    optional: ['principles', 'examples', 'data'] as string[],
+    required: ['goal', 'process', 'constraints', 'criteria'],
+    optional: ['principles', 'examples', 'data'],
   },
-};
+} as const;

packages/ums-lib/src/core/module-loader.ts

@@ -550,7 +550,7 @@ function validateBodyForShape(body: unknown, shape: unknown): ValidationResult {
     STANDARD_SHAPE_SPECS[shape as keyof typeof STANDARD_SHAPE_SPECS];
 
   const bodyObj = body as Record<string, unknown>;
-  const allowedDirectives = new Set([
+  const allowedDirectives = new Set<string>([
     ...shapeSpec.required,
     ...shapeSpec.optional,
   ]);