Replace separator: "\n" with whereSeparator: \.isNewline

Author: intitni

Core/Sources/PromptToCodeService/OpenAIPromptToCodeService.swift

@@ -266,7 +266,7 @@ extension OpenAIPromptToCodeService {
     }
 
     func getCommonLeadingSpaceCount(_ code: String) -> Int {
-        let lines = code.split(separator: "\n")
+        let lines = code.split(whereSeparator: \.isNewline)
         guard !lines.isEmpty else { return 0 }
         var commonCount = Int.max
         for line in lines {

Pro

@@ -359,7 +359,7 @@ func getXcodeVersion() async throws -> String {
                     if let data = try outpipe.fileHandleForReading.readToEnd(),
                        let content = String(data: data, encoding: .utf8)
                     {
-                        let firstLine = content.split(separator: "\n").first ?? ""
+                        let firstLine = content.split(whereSeparator: \.isNewline).first ?? ""
                         var version = firstLine.replacingOccurrences(of: "Xcode ", with: "")
                         if version.isEmpty {
                             version = "14.0"

Tool/Sources/CodeiumService/CodeiumService.swift

@@ -130,11 +130,11 @@ public class ObjectiveCFocusedCodeFinder: KnownLanguageFocusedCodeFinder<
             }
         }
 
-        prefix = prefix.split(separator: "\n")
+        prefix = prefix.split(whereSeparator: \.isNewline)
             .joined(separator: " ")
             .trimmingCharacters(in: .whitespacesAndNewlines)
 
-        extra = extra.split(separator: "\n")
+        extra = extra.split(whereSeparator: \.isNewline)
             .joined(separator: " ")
             .trimmingCharacters(in: .whitespacesAndNewlines)
 

Tool/Sources/FocusedCodeFinder/ObjectiveC/ObjectiveCCodeFinder.swift

@@ -156,7 +156,7 @@ public class SwiftFocusedCodeFinder: KnownLanguageFocusedCodeFinder<
             let type = node.funcKeyword.text
             let name = node.identifier.text
             let signature = node.signature.trimmedDescription
-                .split(separator: "\n")
+                .split(whereSeparator: \.isNewline)
                 .map { $0.trimmingCharacters(in: .whitespacesAndNewlines) }
                 .joined(separator: " ")
 

Tool/Sources/FocusedCodeFinder/Swift/SwiftFocusedCodeFinder.swift

@@ -81,7 +81,7 @@ public struct DefaultGitIgnoredChecker: GitIgnoredChecker {
                 environment: [:]
             )
             return result
-                .split(separator: "\n")
+                .split(whereSeparator: \.isNewline)
                 .map(String.init)
                 .compactMap(URL.init(fileURLWithPath:))
         } catch {

Tool/Sources/GitIgnoreCheck/GitIgnoreCheck.swift

@@ -57,7 +57,7 @@ public extension Filespace {
         }
 
         let editingLine = lines[cursorPosition.line].dropLast(1) // dropping \n
-        let suggestionLines = presentingSuggestion.text.split(separator: "\n")
+        let suggestionLines = presentingSuggestion.text.split(whereSeparator: \.isNewline)
         let suggestionFirstLine = suggestionLines.first ?? ""
 
         /// For example:

Tool/Sources/WorkspaceSuggestionService/Filespace+SuggestionService.swift

@@ -129,7 +129,7 @@ public extension SourceEditor {
     }
 
     static func breakLines(_ string: String) -> [String] {
-        let lines = string.split(separator: "\n", omittingEmptySubsequences: false)
+        let lines = string.split(whereSeparator: \.isNewline, omittingEmptySubsequences: false)
         var all = [String]()
         for (index, line) in lines.enumerated() {
             if index == lines.endIndex - 1 {