refactor: warnings cleanup

Author: AntoineGS

.github/workflows/typecheck.yml

@@ -1,4 +1,4 @@
-name: lua_ls-typecheck
+name: Typecheck
 
 on: [push, pull_request]
 

.luacheckrc

@@ -1,2 +1,4 @@
 ---@diagnostic disable-next-line: lowercase-global
 globals = { "vim", "describe", "it", "before_each", "after_each", "assert", "async", "MiniTest" }
+---@diagnostic disable-next-line: lowercase-global
+max_comment_line_length = 420

lua/copilot/client/init.lua

@@ -60,7 +60,7 @@ function M.buf_attach(force, bufnr)
     return
   end
 
-  if (not force) and util.get_buffer_attach_status(bufnr) == ATTACH_STATUS_MANUALLY_DETACHED then
+  if (not force) and util.get_buffer_attach_status(bufnr) == util.ATTACH_STATUS_MANUALLY_DETACHED then
     logger.trace("buffer not attaching as it was manually detached")
     return
   end
@@ -80,7 +80,7 @@ function M.buf_attach(force, bufnr)
 
   if not (force or should_attach) then
     logger.debug("not attaching to buffer based should_attach criteria: " .. reason)
-    util.set_buffer_attach_status(bufnr, ATTACH_STATUS_NOT_ATTACHED_PREFIX .. reason)
+    util.set_buffer_attach_status(bufnr, util.ATTACH_STATUS_NOT_ATTACHED_PREFIX .. reason)
     return
   end
 
@@ -104,10 +104,10 @@ function M.buf_attach(force, bufnr)
   util.set_buffer_previous_ft(bufnr, vim.bo[bufnr].filetype)
   if force then
     logger.debug("force attached to buffer")
-    util.set_buffer_attach_status(bufnr, ATTACH_STATUS_FORCE_ATTACHED)
+    util.set_buffer_attach_status(bufnr, util.ATTACH_STATUS_FORCE_ATTACHED)
   else
     logger.trace("buffer attached")
-    util.set_buffer_attach_status(bufnr, ATTACH_STATUS_ATTACHED)
+    util.set_buffer_attach_status(bufnr, util.ATTACH_STATUS_ATTACHED)
   end
 end
 
@@ -116,7 +116,7 @@ function M.buf_detach_if_attached(bufnr)
   bufnr = bufnr or vim.api.nvim_get_current_buf()
   if M.buf_is_attached(bufnr) then
     vim.lsp.buf_detach_client(bufnr, M.id)
-    util.set_buffer_attach_status(bufnr, ATTACH_STATUS_NOT_ATTACHED_PREFIX .. "detached")
+    util.set_buffer_attach_status(bufnr, util.ATTACH_STATUS_NOT_ATTACHED_PREFIX .. "detached")
   end
 end
 

lua/copilot/command.lua

@@ -53,7 +53,7 @@ function M.detach()
   if c.buf_is_attached(bufnr) then
     c.buf_detach_if_attached(bufnr)
     logger.trace("buffer manually detached")
-    u.set_buffer_attach_status(bufnr, ATTACH_STATUS_MANUALLY_DETACHED)
+    u.set_buffer_attach_status(bufnr, u.ATTACH_STATUS_MANUALLY_DETACHED)
   end
 end
 

lua/copilot/config/init.lua

@@ -68,7 +68,7 @@ function M.validate(config)
   vim.validate("copilot_model", config.copilot_model, { "string", "nil" })
   vim.validate("root_dir", config.root_dir, { "string", "function" })
   vim.validate("should_attach", config.should_attach, "function")
-  vim.validate("copilot_node_command", config.copilot_node_command, {"string", "table"})
+  vim.validate("copilot_node_command", config.copilot_node_command, { "string", "table" })
 
   require("copilot.config.panel").validate(config.panel)
   require("copilot.config.suggestion").validate(config.suggestion)

lua/copilot/init.lua

@@ -7,7 +7,8 @@ local config = require("copilot.config")
 M.setup = function(opts)
   if vim.fn.has("nvim-0.11") == 0 then
     vim.notify_once(
-      "[copilot.lua] Neovim 0.11+ will soon be required. Please upgrade your Neovim version if you wish to keep using this plugin.",
+      "[copilot.lua] Neovim 0.11+ will soon be required. "
+        .. "Please upgrade your Neovim version if you wish to keep using this plugin.",
       vim.log.levels.WARN
     )
     return

lua/copilot/logger/init.lua

@@ -84,7 +84,7 @@ local function write_log(log_level, log_file, msg, ...)
   local log_msg = format_log(log_level, msg, ...) .. "\n"
 
   uv.fs_open(log_file, "a", tonumber("644", 8), function(err, fd)
-    if err then
+    if err or not fd then
       notify_log(vim.log.levels.ERROR, "Failed to open log file: " .. err)
       return
     end

lua/copilot/lsp/nodejs.lua

@@ -10,7 +10,6 @@ local M = {
   initialization_failed = false,
 }
 
-
 ---@return string node_version
 ---@return nil|string node_version_error
 function M.get_node_version()

lua/copilot/panel/init.lua

@@ -462,7 +462,8 @@ function panel:refresh()
       utf16_index = vim.str_utfindex(self.state.line, "utf-16")
     else
       ---@diagnostic disable-next-line: missing-parameter
-      _, utf16_index = vim.str_utfindex(self.state.line)
+      local _, this_utf16_index = vim.str_utfindex(self.state.line)
+      utf16_index = this_utf16_index
     end
     params.doc.position.character = utf16_index
     params.position.character = params.doc.position.character

lua/copilot/util.lua

@@ -1,14 +1,15 @@
 local config = require("copilot.config")
 local logger = require("copilot.logger")
 
-local M = {}
-VAR_ATTACH_STATUS = "copilot_lua_attach_status"
-VAR_PREVIOUS_FT = "copilot_lua_previous_ft"
-ATTACH_STATUS_MANUALLY_DETACHED = "manually detached"
-ATTACH_STATUS_FORCE_ATTACHED = "force attached"
-ATTACH_STATUS_ATTACHED = "attached"
-ATTACH_STATUS_NOT_ATTACHED_PREFIX = "not attached based on "
-ATTACH_STATUS_NOT_YET_REQUESTED = "attach not yet requested"
+local M = {
+  VAR_ATTACH_STATUS = "copilot_lua_attach_status",
+  VAR_PREVIOUS_FT = "copilot_lua_previous_ft",
+  ATTACH_STATUS_MANUALLY_DETACHED = "manually detached",
+  ATTACH_STATUS_FORCE_ATTACHED = "force attached",
+  ATTACH_STATUS_ATTACHED = "attached",
+  ATTACH_STATUS_NOT_ATTACHED_PREFIX = "not attached based on ",
+  ATTACH_STATUS_NOT_YET_REQUESTED = "attach not yet requested",
+}
 
 ---@return { editorInfo: copilot_editor_info, editorPluginInfo: copilot_editor_plugin_info }
 function M.get_editor_info()
@@ -163,26 +164,26 @@ end
 ---@param bufnr integer
 ---@param status string
 function M.set_buffer_attach_status(bufnr, status)
-  vim.api.nvim_buf_set_var(bufnr, VAR_ATTACH_STATUS, status)
+  vim.api.nvim_buf_set_var(bufnr, M.VAR_ATTACH_STATUS, status)
 end
 
 ---@param bufnr integer
 ---@return string
 function M.get_buffer_attach_status(bufnr)
-  local ok, result = pcall(vim.api.nvim_buf_get_var, bufnr, VAR_ATTACH_STATUS)
-  return (ok and result) or ATTACH_STATUS_NOT_YET_REQUESTED
+  local ok, result = pcall(vim.api.nvim_buf_get_var, bufnr, M.VAR_ATTACH_STATUS)
+  return (ok and result) or M.ATTACH_STATUS_NOT_YET_REQUESTED
 end
 
 ---@param bufnr integer
 ---@param filetype string
 function M.set_buffer_previous_ft(bufnr, filetype)
-  vim.api.nvim_buf_set_var(bufnr, VAR_PREVIOUS_FT, filetype)
+  vim.api.nvim_buf_set_var(bufnr, M.VAR_PREVIOUS_FT, filetype)
 end
 
 ---@param bufnr integer
 ---@return string
 function M.get_buffer_previous_ft(bufnr)
-  local ok, result = pcall(vim.api.nvim_buf_get_var, bufnr, VAR_PREVIOUS_FT)
+  local ok, result = pcall(vim.api.nvim_buf_get_var, bufnr, M.VAR_PREVIOUS_FT)
   return (ok and result) or ""
 end