Skip to content

Commit d373a8c

Browse files
committed
Update to throw instead of returning empty list
1 parent edda705 commit d373a8c

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

Tool/Sources/SuggestionProvider/SuggestionServiceMiddleware.swift

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,13 @@ public enum SuggestionServiceMiddlewareContainer {
4545

4646
public struct DisabledLanguageSuggestionServiceMiddleware: SuggestionServiceMiddleware {
4747
public init() {}
48+
49+
struct DisabledLanguageError: Error, LocalizedError {
50+
let language: String
51+
var errorDescription: String? {
52+
"Suggestion service is disabled for \(language)."
53+
}
54+
}
4855

4956
public func getSuggestion(
5057
_ request: SuggestionRequest,
@@ -55,10 +62,7 @@ public struct DisabledLanguageSuggestionServiceMiddleware: SuggestionServiceMidd
5562
if UserDefaults.shared.value(for: \.suggestionFeatureDisabledLanguageList)
5663
.contains(where: { $0 == language.rawValue })
5764
{
58-
#if DEBUG
59-
Logger.service.info("Suggestion service is disabled for \(language).")
60-
#endif
61-
return []
65+
throw DisabledLanguageError(language: language.rawValue)
6266
}
6367

6468
return try await next(request)

0 commit comments

Comments
 (0)