Makefile errors with "Unsupported operating system" on Windows 11

[josephemorgan]

I'm (unfortunately) having to use Windows 11 currently, and I'm getting an issue when installing CopilotChat.nvim via Lazy in Neovim.

The makefile says:

ifeq ($(UNAME), Linux)
    OS := linux
    EXT := so
else ifeq ($(UNAME), Darwin)
    OS := macOS
    EXT := dylib
else ifeq ($(UNAME), Windows_NT)
    OS := windows
    EXT := dll
else
    $(error Unsupported operating system: $(UNAME))
endif

But on my system, under Powershell, uname doesn't return Windows_NT, it returns MSYS_NT-10.0-26100

If I modify the OS check as follows, everything installs and works correctly:

ifeq ($(UNAME), Linux)
    OS := linux
    EXT := so
else ifeq ($(UNAME), Darwin)
    OS := macOS
    EXT := dylib
else ifeq ($(UNAME), Windows_NT)
    OS := windows
    EXT := dll
else ifneq ($(findstring MSYS_NT,$(UNAME)),)
    OS := windows
    EXT := dll
endif

Is this known about/documented anywhere?

[deathbeam]

I havent rly used windows in a while but your fix sounds good to me at least if you want to make a PR with it (ofc keep the final else wit the error unsupported operating system)

[josephemorgan]

Sounds good, I'll open a PR once I'm off work for the day.

[AjmalShajahan]

@deathbeam I can confirm the fix works on windows. I use Windows 11 25H2 .

[josephemorgan]

Oh nice, looks like I don't have to open that pull request, thanks @AjmalShajahan !