Skip to content

fix(chat): properly reset modifiable after modifying it #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deathbeam merged 1 commit into from
Jul 31, 2025
Merged

fix(chat): properly reset modifiable after modifying it #1234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions lua/CopilotChat/ui/chat.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,7 @@ function Chat:add_message(message, replace)
local section = current_message.section

if section then
local modifiable = vim.bo[self.bufnr].modifiable
vim.bo[self.bufnr].modifiable = true
vim.api.nvim_buf_set_lines(
self.bufnr,
Expand All @@ -447,7 +448,7 @@ function Chat:add_message(message, replace)
false,
vim.split(message.content, '\n')
)
vim.bo[self.bufnr].modifiable = false
vim.bo[self.bufnr].modifiable = modifiable
self:append('')
end
else
Expand All @@ -474,9 +475,10 @@ function Chat:remove_message(role)
end

-- Remove the section from the buffer
local modifiable = vim.bo[self.bufnr].modifiable
vim.bo[self.bufnr].modifiable = true
vim.api.nvim_buf_set_lines(self.bufnr, section.start_line - 2, section.end_line + 1, false, {})
vim.bo[self.bufnr].modifiable = false
vim.bo[self.bufnr].modifiable = modifiable

-- Remove the message from the messages list
for i, msg in ipairs(self.messages) do
Expand Down Expand Up @@ -505,9 +507,10 @@ function Chat:append(str)

local last_line, last_column, _ = self:last()

local modifiable = vim.bo[self.bufnr].modifiable
vim.bo[self.bufnr].modifiable = true
vim.api.nvim_buf_set_text(self.bufnr, last_line, last_column, last_line, last_column, vim.split(str, '\n'))
vim.bo[self.bufnr].modifiable = false
vim.bo[self.bufnr].modifiable = modifiable

if should_follow_cursor then
self:follow()
Expand All @@ -520,9 +523,11 @@ function Chat:clear()
self.token_count = nil
self.token_max_count = nil
self.messages = {}

local modifiable = vim.bo[self.bufnr].modifiable
vim.bo[self.bufnr].modifiable = true
vim.api.nvim_buf_set_lines(self.bufnr, 0, -1, false, {})
vim.bo[self.bufnr].modifiable = false
vim.bo[self.bufnr].modifiable = modifiable
end

--- Create the chat window buffer.
Expand Down
Loading