fix(ui): prevent errors when restoring invalid window#1539
Merged
deathbeam merged 1 commit intoCopilotC-Nvim:mainfrom Mar 29, 2026
Merged
fix(ui): prevent errors when restoring invalid window#1539deathbeam merged 1 commit intoCopilotC-Nvim:mainfrom
deathbeam merged 1 commit intoCopilotC-Nvim:mainfrom
Conversation
- Add a check in Overlay:restore to ensure the window is valid before attempting to set the buffer, preventing errors if the window was closed. - Scope the close keymap in chat buffer to the buffer only, avoiding global keymap pollution. Closes CopilotC-Nvim#1535
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attempting to set the buffer, preventing errors if the window was
closed.
global keymap pollution.
Closes #1535