feat(CopilotChat): Improve line separation and prompt update logic, add diff view#99
Merged
jellydn merged 4 commits intoCopilotC-Nvim:canaryfrom Feb 29, 2024
Merged
Conversation
added 2 commits
February 29, 2024 11:39
Now submit_code and submit_prompt properly try to find first match from the end so you dont need to cursor over specific blocks. This is also prerequisite for showing current diff as float or in corner somewhere. BREAKING CHANGE: The key mapping for submitting code is now <C-d> instead of <C-y>. Signed-off-by: Tomas Slusny <ts6234@att.com>
Signed-off-by: Tomas Slusny <ts6234@att.com>
deathbeam
force-pushed
the
better-submit
branch
from
407c144 to
a13c697
Compare
deathbeam
changed the title
Collaborator
Author
|
Added diff display as well, currently with K keybinding that will open float, but there should be a better way to display it for sure:
|
deathbeam
force-pushed
the
better-submit
branch
2 times, most recently
from
98ecc14 to
d7517b5
Compare
Contributor
|
@deathbeam Nice. Let me know when it's ready ;) I will take a try. Thanks. |
For now with keybinding (default K). Maybe find a way to display it in better place. Signed-off-by: Tomas Slusny <ts6234@att.com>
deathbeam
force-pushed
the
better-submit
branch
from
d7517b5 to
d4894a4
Compare
Collaborator
Author
Just did one last small change I wanted to do to the display so should be ready now I think. I realized that most common user configs will have conflicting K mapping so I changed the keybind to C-d as well and accept to C-y again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now submit_code and submit_prompt properly try to find first match from the end so you dont need to cursor over specific blocks. This is also prerequisite for showing current diff as float or in corner somewhere.