fix: prevent 'Unknown provider' regression for LangChainAdapter#3840
Merged
Conversation
When getLanguageModel() returns null and provider/model are undefined (as with LangChainAdapter), the code constructed "undefined/undefined" as a model string, causing a cryptic "Unknown provider" error. Now checks each source of model info explicitly and throws a clear error message directing users to provide an explicit agents config when using adapters that don't expose model metadata.
jpr5
requested review from
ataibarkai,
mme,
ranst91 and
tylerslaton
as code owners
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
📣 Social Copy GeneratorGenerate social media copies (Twitter/X, LinkedIn, Blog Post) for this PR using Claude.
|
3 tasks
@copilotkit/a2ui-renderer
@copilotkitnext/angular
copilotkit
@copilotkit/core
@copilotkit/react-core
@copilotkit/react-textarea
@copilotkit/react-ui
@copilotkit/runtime
@copilotkit/runtime-client-gql
@copilotkit/sdk-js
@copilotkit/shared
@copilotkit/sqlite-runner
@copilotkit/voice
copilotkit-vscode-extension
@copilotkit/web-inspector
commit: |
AlemTuzlak
reviewed
Apr 16, 2026
AlemTuzlak
left a comment
AlemTuzlak
left a comment
Contributor
There was a problem hiding this comment.
looks good, tests please
) Covers the three branches added by the fix: - getLanguageModel() returns a LanguageModel -> wired into BuiltInAgent - provider + model strings present -> composed as "provider/model" - neither present (e.g. LangChainAdapter) -> throws CopilotKitMisuseError with adapter name in the message, instead of silently producing "undefined/undefined" and failing downstream. Also guards the partial-info case where only one of provider/model is set to ensure the regression doesn't re-emerge via a half-populated adapter.
ranst91
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3217
When
getLanguageModel()returns null and provider/model are undefined (as with LangChainAdapter), the code constructed"undefined/undefined"as a model string, causing a cryptic "Unknown provider" error.Now checks each source of model info explicitly and throws a clear error message directing users to provide an explicit agents config when using adapters that don't expose model metadata.
Split from #3838.