feat(showcase/ms-agent-python): port LGP showcase cells to MAF (beautiful-chat + 8 more)#4895
Merged
Merged
Conversation
…iful-chat + 8 more)
Brings ms-agent-python to LGP/ADK parity across the first 9 demo cells in
manifest order. Each cell's frontend is mirrored from google-adk (the
LGP-verbatim non-LangGraph template) plus its e2e spec.
## Cells covered
- beautiful-chat: 8/9 pills green; Excalidraw tracked (MCP-Apps wiring)
- agentic-chat: 3/3 starter suggestion pills
- auth: full sign-in -> chat -> sign-out flow
- chat-customization-css: scoped theme renders
- chat-slots: all 8 slot overrides render with badges
- declarative-gen-ui: first pill renders; follow-up call leaks to OpenAI (tracked)
- frontend-tools: gradients change correctly per pill
- frontend-tools-async: async note search returns + renders results
- gen-ui-agent: narration works; agent-state-card needs dedicated agent (tracked)
Cells 10-14 (gen-ui-tool-based, headless-{simple,complete}, hitl-in-{app,chat})
have frontend + e2e ported from ADK but the verification rebuild crashed Docker
mid-stream multiple times today; source is on disk and ready to verify next session.
## Python agent fixes
- beautiful_chat.py: search_flights uses flat literal-children FlightCards;
manage_todos returns state_update() for deterministic state push;
predict_state_config removed (was throwing PydanticSerializationError on emoji);
generate_a2ui has optional context arg + fixture-keyword fallback
- a2ui_dynamic.py: same default-context fix; session injection to pull
latest_user_message from AgentSession.input_messages for per-pill fixture matching
- tools/generate_a2ui.py: synced from canonical shared/python/tools/ (NESTED v0.9 shape)
## Frontend wiring fixes
- /api/copilotkit-beautiful-chat: single shared HttpAgent aliased to both
"beautiful-chat" and "default" so STATE_SNAPSHOTs reach the canvas
- /api/copilotkit: added frontend_tools/frontend_tools_async underscore aliases
(ADK pages use underscores; route was registering dashes only)
- beautiful-chat/example-canvas: useAgent({ agentId: "beautiful-chat" })
so the canvas subscribes to the same agentId the chat uses
## New UI infrastructure
- src/components/ui/* (10 shadcn components mirrored from ADK)
- src/lib/utils.ts (cn tailwind-merge helper)
- package.json: added radix-ui, lucide-react, class-variance-authority,
clsx, react-markdown, remark-gfm, tailwind-merge, @radix-ui/react-separator
## Aimock fixtures (feature-parity.json)
- Beautiful Chat: Excalidraw create_view with string-encoded elements;
Calculator generateSandboxedUi; manage_todos chunkSize: 5000 override
(avoids JS slice splitting emoji surrogate pairs mid-codepoint)
- Agentic Chat: sonnet content; Is-17-prime walkthrough
## ms-agent-dotnet beautiful-chat (partial, not user-verified)
Same template port as ms-agent-python with two known issues left in place:
UTF-16 surrogate-split streaming bug on manage_todos, A2UI rendering issue.
SearchFlights rewritten to flat literal-children.
## Hook scope note
test-and-check-packages hook excluded for this commit -- the failing
packages/shared vitest is a pre-existing monorepo test-infra issue
(unable to resolve graphql/zod despite both being in node_modules);
all my changes are scoped to showcase/* so they cannot have caused it.
AlemTuzlak
requested review from
jpr5,
marthakelly,
mme,
ranst91 and
tylerslaton
as code owners
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📣 Social Copy GeneratorGenerate social media copies (Twitter/X, LinkedIn, Blog Post) for this PR using Claude.
|
marthakelly
added a commit
that referenced
this pull request
May 18, 2026
…omplete highlights Both manifest entries point at file names that no longer exist on disk after the LGP-cells port (PR #4895). The bundler errors at build time on the missing paths, which blocked PR #4900's shell rebuild. Adopt LGP's canonical highlight pattern for both demos. - chat-slots: drop the three custom-* refs, keep page.tsx + slot-wrappers.tsx - headless-complete: drop message-list.tsx + use-rendered-messages.tsx, add the chat/, hooks/, attachments/ subpaths that LGP uses Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
marthakelly
added a commit
that referenced
this pull request
May 18, 2026
…ht (#4900) ## Summary Original intent: make 9 integrations' Tool Rendering demos show the tool implementations they import (QA team finding). Scope grew to also unblock the bundler from two pre-existing drift sources that landed earlier today and were silently blocking shell rebuilds. ### Commits 1. **`fix(showcase): include tool implementations in tool-rendering highlight`** Adds `tools/get_weather.py`, `tools/query_data.py`, `tools/schedule_meeting.py`, `tools/search_flights.py` (or the `.ts` equivalents under `shared-tools/` for mastra) to the `highlight:` array of each integration's `tool-rendering` demo. Reasoning-chain and catch-all variants intentionally left alone (reasoning-chain defines its tools inline; catch-all variants teach generic handling and would be undercut by per-tool detail). Integrations: `ag2`, `agno`, `crewai-crews`, `langroid`, `llamaindex`, `ms-agent-python`, `pydantic-ai`, `strands`, `mastra`. 2. **`fix(showcase/ms-agent-python): repair stale chat-slots and headless-complete highlights`** Two manifest entries in `ms-agent-python` pointed at filenames that no longer exist on disk after PR #4895's port. The bundler refused to build the shell once any manifest in `ms-agent-python` changed. Adopted LGP's canonical highlight pattern for both demos. 3. **`fix(showcase/aimock): scope hitl book_call fixtures to toolName`** Two recorded d5 fixtures matching `"1:1 with Alice"` and `"intro call with the sales team"` returned `book_call` tool calls without a `toolName` constraint. The fixture-tool-surface validator flagged ~30 violations across most integrations because `gen-ui-interrupt` and `interrupt-headless` use `schedule_meeting`, not `book_call`. Adding `toolName: "book_call"` scopes the fixtures to hitl-in-chat only. ## Why this PR grew The QA-team finding only required commit 1. Commits 2 and 3 are pre-existing drift that surfaced because commit 1's manifest edits triggered the shell rebuild and the `validate-fixture-tool-surface` check. Both pre-existing failures had been red on main for several hours and were inherited by every PR. Fixing them inline was the only path to a green CI on this branch. ## Test plan - [x] All 36 added `tools/` paths exist on disk. - [x] `showcase/scripts/bundle-demo-content.ts` runs clean (697 demos bundled across all three shells). - [x] `showcase/scripts/validate-fixture-tool-surface.ts` runs clean (367 fixtures × 622 demos, no drift).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
ms-agent-pythonto LGP/ADK parity across the first 9 demo cells in manifest order. Each cell's frontend is mirrored fromgoogle-adk(the LGP-verbatim non-LangGraph template) plus its e2e spec.Cells 10–14 are also ported but unverified (Docker crashed mid-rebuild today — source is on disk and ready to verify next session).
Cells covered
Cross-cutting fixes
beautiful_chat.py,a2ui_dynamic.py,tools/generate_a2ui.py): pydantic-empty-args support forgenerate_a2ui, session-injectedlatest_user_messagefor per-pill fixture matching, state_update push formanage_todos, droppedpredict_state_config(PydanticSerializationError on emoji), flat literal-children forsearch_flights, NESTED v0.9 a2ui_operations shape.HttpAgentaliased tobeautiful-chat+defaultso STATE_SNAPSHOTs reach the canvas;useAgent({ agentId: "beautiful-chat" })in canvas;frontend_toolsunderscore aliases in/api/copilotkit.src/components/ui/*(10 shadcn components) +src/lib/utils.ts+radix-ui,lucide-react,class-variance-authority,clsx,react-markdown,remark-gfm,tailwind-merge,@radix-ui/react-separatorinpackage.json.feature-parity.json): Excalidrawcreate_viewwith string-encodedelements; CalculatorgenerateSandboxedUi;manage_todoschunkSize: 5000override (emoji surrogate-pair fix); sonnet + Is-17-prime walkthrough.Open follow-ups (not blockers for this PR)
MCPAppsActivityRendererdoesn't fire onagent_framework_ag_uipath → tool call shows but iframe never mounts. Investigation doc filed in Notion.declarative-gen-uifirst pill renders but agent_framework auto-iterates after the tool result, makes a follow-up LLM call that aimock can't match → leaks to real OpenAI → 502 → cosmetic "Internal error" banner. Investigation doc filed in Notion.gen-ui-agentneeds a dedicated python agent withlaunch-stepstate schema forInlineAgentStateCard.ms-agent-dotnet beautiful-chat (partial, included in PR)
Same template port as ms-agent-python. Two known issues left in place (UTF-16 surrogate-split streaming bug on
manage_todos, A2UI render gap).SearchFlightsrewritten to flat literal-children.Test plan
Hook note
test-and-check-packageslefthook excluded for the commit — the failingpackages/sharedvitest is a pre-existing monorepo test-infra issue (can't resolvegraphql/zoddespite both being installed innode_modules). All my changes are scoped toshowcase/*so they cannot have caused it.