Skip to content

feat: add three MICE config fields to NumericImputationConfig #157

@DEVunderdog

Description

@DEVunderdog

Parent

#91

What to build

Add three new fields to NumericImputationConfig that control n_nearest_features derivation for large MICE blocks. Update to_dict() / from_dict() to serialise them. Add unit tests confirming the round-trip preserves all three fields with their defaults.

Fields to add:

  • mice_n_nearest_features_min_cols: int = 10 — MICE block size below which n_nearest_features is left unset (all predictors used)
  • mice_max_nearest_features: int = 20 — cap on the computed n_nearest_features value
  • mice_correlation_threshold: float = 0.1 — minimum |Pearson r| for a column to count as an informative predictor

Acceptance criteria

  • All three fields exist on NumericImputationConfig with the documented defaults
  • to_dict() includes all three fields
  • from_dict() reconstructs all three fields; missing keys fall back to defaults
  • Numpy-style docstring on NumericImputationConfig is updated to document all three new parameters
  • Unit test: to_dict() / from_dict() round-trip preserves all three fields with correct defaults
  • Unit test: from_dict() with an empty dict produces the correct defaults for all three fields

Blocked by

None — can start immediately

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions