Add saving throw and ability check rolling to character sheet

[FirebrickRed]

Priority: MEDIUM
Status: TODO
Depends on: Issue #55 (Skill rolling system - prerequisite)

Description

Extend the interactive rolling system (Issue #55) to support saving throws and raw ability checks. Players should be able to click ability scores in the character sheet to roll saves or ability checks.

Current State

• ✅ Skill checks implemented (Issue Interactive Character Sheet: Skills Drilldown and Rolling System #55)
• ❌ No way to roll saving throws
• ❌ No way to roll raw ability checks

D&D 5e Context

Saving Throws:

• Roll: d20 + ability modifier + proficiency (if proficient)
• Example: DEX save vs fireball = d20 + DEX mod + prof bonus
• Proficiency determined by class (e.g., Rogue proficient in DEX/INT saves)

Ability Checks:

• Roll: d20 + ability modifier (no proficiency)
• Example: Raw STR check to break door = d20 + STR mod
• Used when no specific skill applies

Proposed Implementation

UI Flow

Option A: Click ability score in character sheet

Player clicks "STR 16 (+3)" in character sheet
→ Opens menu:
   [Roll STR Check]        (d20 + 3)
   [Roll STR Save]         (d20 + 3 + prof if proficient)
   [Cancel]
→ Each option leads to advantage/disadvantage menu (reuse from Issue #55)

Option B: Dedicated section in skills menu

Skills Menu:
[STR] [Athletics]
      [Roll STR Check]  [Roll STR Save]

[DEX] [Acrobatics] [Sleight of Hand] [Stealth]  
      [Roll DEX Check]  [Roll DEX Save]

Recommend Option A - keeps character sheet interactive.

Roll Options Menu

Reuse existing RollOptionsMenu from Issue #55:

• Normal Roll
• Advantage
• Disadvantage
• Show Modifier Only
• Cancel

Chat Output Examples

Saving Throw:

[CharName] rolled DEX save: 18 (d20: 13 +3 +2)
[CharName] rolled STR save with advantage: 22 (d20: 17, 12 +3)

Ability Check:

[CharName] rolled STR check: 15 (d20: 12 +3)
[CharName] rolled CHA check with disadvantage: 8 (d20: 6, 14 +2)

Acceptance Criteria

• Click ability scores to open roll type menu
• "Roll [Ability] Check" option (d20 + modifier)
• "Roll [Ability] Save" option (d20 + modifier + prof if proficient)
• Saving throw proficiency correctly applied based on class
• Both options support advantage/disadvantage
• Results broadcast to chat with proper formatting
• "Show Modifier Only" works for both types

Technical Implementation

New Components

• AbilityRollOptionsMenu (or reuse/extend RollOptionsMenu?)
• Add ROLL_ABILITY_CHECK and ROLL_SAVING_THROW to MenuAction
• Update ViewCharacterSheetMenu to make ability items clickable

Reuse from Issue #55

• RollOptionsMenu (advantage/disadvantage selection)
• Roll logic (rollD20, rollAdvantage, rollDisadvantage)
• Chat broadcast formatting
• MenuAction pattern

Data Needed

• Ability modifier: character.getModifier(ability)
• Save proficiency: character.getMainClass().getSavingThrows().contains(ability)
• Proficiency bonus: character.getProficiencyBonus()

Related Issues

• Issue Interactive Character Sheet: Skills Drilldown and Rolling System #55: Skill rolling system (prerequisite - reuse architecture)
• Issue Add private/hidden roll system for DM-only visibility #58: Private rolls (future - saves often need to be hidden from players)

Future Enhancements

• Death saving throws (special case - no modifiers)
• Concentration saves (CON save with special DC)
• Contested checks (opposed rolls)
• Save DC display for spells

Notes

• Very similar to Issue Interactive Character Sheet: Skills Drilldown and Rolling System #55 implementation
• Main difference: calculating bonus (ability mod vs skill bonus)
• Should feel consistent with skill rolling UX

[FirebrickRed]

Implemented ability check and saving throw rolling with advantage/disadvantage support.

What was added:

• Ability checks: Click ability icons in Skills menu to roll d20 + ability modifier (no proficiency)
• Saving throws: Click save icons to roll d20 + ability modifier + proficiency bonus (if class grants it)
• Visual indicator: Save icons glow with enchantment effect when character is proficient
• Full advantage/disadvantage support for both roll types
• Consistent with skill rolling system from Interactive Character Sheet: Skills Drilldown and Rolling System #55

Technical highlights:

• Payload prefix pattern ("SKILL:", "CHECK:", "SAVE:") unifies three roll types in single execution pipeline
• Consolidated duplicate code: RollOptionsMenu reduced ~48%, handler reduced ~60 lines
• Uses DiceRoller utility for consistency
• Abbreviated ability names (STR, DEX, etc.) keep chat messages concise

Output examples:

• Normal:
• Advantage:
• Disadvantage:

Tested in-game and working correctly. Ready for play!