fix: guard against undefined return from sendFunction in push-to-talk#1
Open
HowieG wants to merge 1 commit into
Open
fix: guard against undefined return from sendFunction in push-to-talk#1HowieG wants to merge 1 commit into
HowieG wants to merge 1 commit into
Conversation
sendFunction (wrapping sendMessage) returns Promise<void>, so accessing .id on the result throws a TypeError. Add a null check to skip setting startReadingFromMessageId when the return value is undefined. Fixes CopilotKit#3042, fixes CopilotKit#3011 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendFunctioninuse-push-to-talk.tsxwrapssendMessagewhich returnsPromise<void>, so the result is alwaysundefined.idonundefinedthrows aTypeError, crashing the push-to-talk voice featuresetStartReadingFromMessageIdwhen the return isundefined, which is safe since the existing code at line 169 already guards againststartReadingFromMessageIdbeing unsetFixes CopilotKit#3042
Fixes CopilotKit#3011
Test plan
nx run @copilotkit/react-ui:buildsucceedsmessage.idsendFunctionreturns a message object🤖 Generated with Claude Code