fix: preserve loading indicator when tool messages are appended#2
Open
HowieG wants to merge 1 commit into
Open
fix: preserve loading indicator when tool messages are appended#2HowieG wants to merge 1 commit into
HowieG wants to merge 1 commit into
Conversation
…lotKit#3055) When tool messages (role="tool") are appended after an assistant message, they shift array indices causing isCurrentMessage to become false for the assistant message, which makes the loading indicator disappear. Fix by calculating lastVisibleMessageIndex based on user/assistant roles instead of using messages.length - 1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Hello @HowieG , do you know if there is any plan to merge your PR in the main CopilotKit repository main branch? it would be very helpful to fix the tool loading issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role="tool") shift array indices, causingisCurrentMessageto becomefalsefor the assistant messagelastVisibleMessageIndex(last user/assistant message) instead of usingmessages.length - 1, so invisible tool messages no longer affect loading stateTest plan
nx run @copilotkit/react-ui:buildpasses (confirmed locally)inProgressis trueisCurrentMessageis correctly set on the last visible (user/assistant) message🤖 Generated with Claude Code