Skip to content

Bug hunt: 15 verified findings across the codebase #207

@mayagore

Description

@mayagore

As requested — agents searched every subsystem, each finding adversarially verified.

15 confirmed bugs. 46 found, 31 refuted. Grouped by area.

get_vote.rs (server crash cluster)

  • get_vote.rs:64high — panics if LLM response has no valid prefix char (A–T). Fix: continue instead of unwrap.
  • get_vote.rs:158highunwrap_leaf() panics if node is Branch. Fix: pattern-match PfxTree::Leaf(i) directly.
  • get_vote.rs:178high — fallback voting path has chained unwraps; same crash on tree mismatch. Fix: if let guard.
  • get_vote.rs:28mediumRegex::new().unwrap() on dynamic pattern. Fix: .expect("descriptive msg").

CLI

  • streaming.rs:235criticalpanic! on malformed JSON from instance runner. Fix: return Err(Error::Instance(...)).
  • context.rs:157high — IPv6 ::1:8080 missing brackets; RFC 3986 requires [::1]:8080. Test asserts wrong value too.
  • pipes.rs:78high — TOCTOU race: probe socket liveness then remove isn't atomic. True fix needs advisory lock.
  • handshake.rs:42high.expect() on serialization; function already returns io::Result. Fix: .map_err()?.

Rust SDK

API (OpenRouter)

  • client.rs:60high.eventsource().unwrap() crashes on CannotCloneRequestError. Fix: return Result.

WASM

  • lib.rs:268highu64 as u32 silently truncates compile_output_length. Fix: u32::try_from().

Go SDK

  • client.go:113highjson.Marshal error discarded; sends empty auth header. Fix: check err, skip header on failure.
  • generated types (100+ files)high — unchecked json.Unmarshal in every MarshalJSON; silent corruption. Fix: fix the code generator.

Viewer

  • useSessionStorage.ts:31medium — async effect missing cancellation; same file's second effect does it right. Fix: add cancelled flag + cleanup.

Needs your review

  • release.yml — 12 mcp-filesystem jobs build Linux musl but name artifacts macOS/Windows. Intentional if MCP-FS ships containerized?

Full reference with exact fix code for each bug + refutation reasoning for the 31 rejected findings is in audit/2026-06-03-bug-hunt-reference.md on maya/web.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions