Skip to content

adf migrate and doctor disagree on DEFAULT_LOAD classification for new modules #241

Description

@stackbilt-admin

Problem

charter adf migrate places newly created modules in ON_DEMAND, but charter doctor subsequently flags them as required DEFAULT_LOAD — creating a post-migrate WARN state that requires manual intervention.

Reproduction

  1. Run charter adf migrate --source CLAUDE.md
  2. Migration creates core.adf and places it in ON_DEMAND (or omits it from manifest entirely — see related issue)
  3. Run charter doctor --adf-only
[warn] adf required wiring: Missing from DEFAULT_LOAD: core.adf

Root cause

Doctor has criteria for what qualifies as "required DEFAULT_LOAD" (apparently filename + content signals like git identity, persona constraints, etc.). Migrate doesn't apply those same criteria when deciding where to route new modules — it defaults to ON_DEMAND without checking against doctor's required-wiring rules.

Expected behavior

Either:

  • Migrate applies doctor's required-wiring criteria before assigning load type, so a freshly migrated repo passes doctor without manual edits
  • Doctor's WARN includes a resolution hint — e.g. "Add core.adf to DEFAULT_LOAD in manifest.adf to resolve" — so the fix path is unambiguous
  • Both — migrate asks or infers, doctor explains if it still doesn't match

Context

Encountered on Colony OS migration. core.adf received git identity (Mara_AI, mara_ai@stackbilt.dev) and voice constraints — content the doctor correctly identified as always-needed. The gap was silent until doctor ran.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:adfADF parser/bundler/patcher packageenhancementNew feature or requestpriority:p2Nice to have this cycle

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions