Skip to content

genui check should not re-run the compile pass that lint already covers #1

Description

@CNSeniorious000

genui check currently runs compiler.compile() (the same pass genui lint does) plus TypeScript semantic diagnostics. This means:

  • Running check alone duplicates lint's work
  • Running both lint then check compiles twice

The comment in check.ts states the intent:

genui lint stays the fast-only command, while genui check adds semantic TypeScript diagnostics.

But the implementation doesn't follow through — check still includes the compile pass internally.

Proposed change

check should only run the TypeScript semantic diagnostics (checkGenUITypeScriptCode / checkStandaloneTypeScriptCode), not compiler.compile(). The two commands become orthogonal:

command scope
genui lint fast compile pass (syntax, JSX transform)
genui check TypeScript semantic diagnostics only
both full coverage, no overlap

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions