Skip to content

Rename keys.IssueAssign to keys.Assign (used for both issues and PRs) #97

@joshuacrass

Description

@joshuacrass

Problem:
keys.IssueAssign in keys.go is bound to a and is used in both the issue detail view and the PR detail view (model_prs.go:768). The name IssueAssign is semantically wrong for the PR case. If the key is ever refactored to behave differently per context, the PR case would be silently broken because it references a key named for a different resource type.

Solution:
Rename IssueAssign to Assign in keys.go and update all references in model_issues.go and model_prs.go.

Acceptance Criteria:

  • keys.IssueAssign is renamed to keys.Assign
  • All references in model_issues.go and model_prs.go are updated
  • go vet ./... and go test ./... pass

Metadata

Metadata

Assignees

No one assigned

    Labels

    effort:1Very small effort (< 1 hour)priority:lowLow priority - nice to havetype:refactorCode refactoring

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions