Steam Controller: move grip-sense bars out to the sides#55
Merged
Conversation
petegordon
added
enhancement
The left_gripsense / right_gripsense bar meshes are modeled low on the back of the controller, where they're hidden under the body — so the emissive glow they get while a grip is held (setGripState) isn't visible. Add _repositionGripBars: shift each bar out just beyond the controller's left/right silhouette at load, so the bars and their grip glow are visible in use. Side is derived from geometry; the world shift is converted into the mesh's local frame; originals are kept consistent. Opt-in per profile via gripBarsToSides / gripBarSideGap (enabled for the Steam Controller). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
petegordon
force-pushed
the
feat/steam-controller-grip-bars-to-sides
branch
from
f54813c to
d83dbad
Compare
Split the grip-sense display controls in two: - Rename "Show Grip Sense" → "Show Grip Sense Glow" (the existing setGripVisible: mesh emissive + on-top markers). - Add "Show Grip Sense Bars" (new setGripBarsVisible): shows/hides the grip-sense bar meshes themselves. Visible by default; persisted to localStorage (overlay:gripBars), re-applied on each model load. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56.
Move the grip-sense bar meshes out to the sides
The
left_gripsense/right_gripsensebar meshes are modeled low on the back of the 2026 Steam Controller (Y ≈ −0.026, near the bottom), tucked under the body — so the emissive glow they get while a grip is held (setGripState) isn't visible during use.This moves each bar out just beyond the controller's left/right silhouette at load time, so the bars (and their grip glow) read clearly from the front:
_repositionGripBars()runs after the grip markers are placed (markers keep their original anchoring; only the bar meshes move).originalsis updated so the rest pose stays consistent.gripBarsToSides: true+gripBarSideGap: 0.02(gap past the side edge, in model widths) — enabled only for the Steam Controller.Notes
gripBarSideGaptunes the lateral gap; a vertical offset can be added if the bars should also sit higher.controller-overlay.jsin a different region than Steam Controller: trackpad click detection + whole-pad highlight #54, so the two should merge cleanly; whichever lands second may want a quick rebase.Tests: visualizer 5/5 pass; syntax clean.