Skip to content

Airsonic#30

Open
Khadeeja-Tul-Qubra-Rashdi wants to merge 2 commits into
Yundera:mainfrom
Khadeeja-Tul-Qubra-Rashdi:airsonic
Open

Airsonic#30
Khadeeja-Tul-Qubra-Rashdi wants to merge 2 commits into
Yundera:mainfrom
Khadeeja-Tul-Qubra-Rashdi:airsonic

Conversation

@Khadeeja-Tul-Qubra-Rashdi

Copy link
Copy Markdown

No description provided.

@Maelisse2002

Maelisse2002 commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

🤖 AI Pre-Check

Decision: ⚠️ ai-reviewed:needs-review (new app — advisory; human flow owns the decision)
Tech review (incl. security): needed — new app submission (also: pre-install-cmd present + user-dir volume mount)
Commit: 607cfc4 | Checklist source: CONTRIBUTING.md@main

Apps in this PR

  • airsonic — new (linuxserver airsonic-advanced 11.1.4-ls166)

AI static checks

  • ✅ Specific version tag (no :latest) — app image and ubuntu:22.04 pre-install both pinned
  • ✅ No hardcoded credentials (uses $PUID/$PGID/$TZ)
  • ✅ Volumes under /DATA/AppData/airsonic/ (+ /DATA/Media/Music:ro for the library — inside /DATA, appropriate for a music server)
  • PUID:PGID env vars present
  • cpu_shares set (50) on the single service
  • pre-install-cmd pinned (ubuntu:22.04) and chowns the user dir to $PUID:$PGID
  • x-casaos asset references — no icon:/thumbnail: URLs in metadata, no thumbnail.png, and no screenshots in the PR (only docker-compose.yml + icon.png added)

→ Tier 2 must verify (human)

  • Works immediately after installation
  • Fresh installation tested
  • Uninstall / reinstall preserves data
  • (new app — no prior version / migration path)

Notes for reviewers

  • New app → AI pre-check is advisory only; final decision stays on the human flow (PH + Cristian). Decision forced to needs-review.
  • No Caddy labels (caddy_0/1/2) on the service despite expose: 80 — as written the web UI won't be routed via the gateway/nip.io/sslip.io. Confirm web access before merge.
  • No user: field while the service mounts /DATA/Media/Music; the linuxserver image drops privileges via PUID/PGID (mount is :ro), so likely fine — worth a permissions sanity check.
  • Auth: airsonic-advanced ships a built-in login (index: /login) enabled by default — acceptable per the Security checklist's built-in-auth alternative.
  • Missing required assets: at least one screenshot + thumbnail.png per CONTRIBUTING; x-casaos should reference icon:/thumbnail: URLs pointing at Yundera/AppStore@main.

Next step

→ Tier 2 functional review, then tech + security review (new app submission). Also add the missing assets/metadata and Caddy labels before merge.


Generated by AI pre-check. Checklist read live from CONTRIBUTING.md on main. Labels are the machine-readable verdict; this comment is the human-readable explanation. Humans own the merge.

@Maelisse2002 Maelisse2002 added ai-reviewed:needs-review AI pre-check: ambiguity flagged tech-review:needed Tech + security review required labels Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-reviewed:needs-review AI pre-check: ambiguity flagged tech-review:needed Tech + security review required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants