You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do note that SPLIIT 1.19.1 does not work, their Github repo failed to build and the version is not available
Please test versions before updating to ensure they install properly
rationale.md claims a root exception — quote: "All three services run as user: 0:0 (root)." with reason "spliit: The Node.js application runs Prisma database migrations on startup, which requires write access to the working directory. Running as non-root causes migration failures." Volumes map only to AppData. A human must judge whether the root rationale is acceptable.
Version mismatch: title says v1.19.1 but the spliit image stays 1.19.0. Maintainer @krizcold notes 1.19.1 "does not work, their GitHub repo failed to build and the version is not available." Net effect of this PR is hardening (pin nginx, drop privileged/cap_add, remove hardcoded basic-auth creds), not a version bump.
Reviewed against current main; the PR's merge-base diff is a subset because main has advanced.
Next step
→ Tier 2 functional review, then tech + security review (db volume source edited; root-exception rationale to validate).
Generated by AI pre-check. Checklist read live from CONTRIBUTING.md on main. Labels are the machine-readable verdict; this comment is the human-readable explanation. Humans own the merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Spliit (v1.19.1) with Yundera AppStore conventions — Caddy reverse proxy, resource limits, cpu_shares, multi-language metadata.
Architecture
nginx-hash-lock:latestis a Yundera-maintained imagespliit-network(bridge)pcs(Caddy via nginxhashlock)Submission Checklist
Tech Checklist
user: 0:0, volumes mapped to/DATA/AppData/$AppID/Security Checklist
$PCS_DEFAULT_PASSWORDfor DBspliit:1.19.1,postgres:16.13-alpine(nginx-hash-lock:latestis Yundera image)Functionality Checklist
/DATA/AppData/$AppID/pgdataDocumentation Checklist
Yundera/AppStore@main