Skip to content

Approval banner omits the command/args even though the message carries them #27

Description

@aasis21

Problem

The approval banner in SessionScreen.tsx renders only req.toolName + the option buttons (e.g. "powershell needs your approval"). But the ApprovalRequest message includes toolArgs (see shared/messages.d.ts:96 and messages.mjs:114). The user is asked to approve a command without seeing what it is — they approve blind.

Why it matters

This is the single most important safety affordance in the app. Approving powershell without seeing the command is dangerous; the data needed to show it is already in hand and simply discarded.

Suggested fix

Render req.toolArgs (command / file / path) in the approval banner — at least a one-line summary, expandable to full args — before the Allow/Deny buttons.

Where

mobile/src/components/SessionScreen.tsx (approval banner, lines ~73–93).


Filed from a UI research sweep of the Helm mobile app (landing + live demo session) using Playwright + full source review, cross-referenced against Claude, ChatGPT, GitHub Copilot Chat, and Codex/Claude Code UIs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    approvalsPermission approval flowbugSomething isn't workingsafetySafety-criticaluiUser interface

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions