Skip to content

[pull] main from intitni:main #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 42 commits into from
Jun 24, 2023
Merged

[pull] main from intitni:main #8

Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
595b415
Fix chat not stopping responding on errors
intitni Jun 20, 2023
d8867ba
Update
intitni Jun 20, 2023
ebfcd34
Fix trigger command to correctly throw error
intitni Jun 20, 2023
db1cf1e
Update accept suggestion to automatically fallback to Accessibility A…
intitni Jun 20, 2023
eb51ecc
Remove acceptSuggestionWithAccessibilityAPI
intitni Jun 20, 2023
f73af0e
Fix dependency
intitni Jun 22, 2023
d157fa6
Get Xcode version from the Xcode bundle version.plist
intitni Jun 22, 2023
c30d18a
Merge branch 'feature/read-xcode-version-from-inspector' into hotfix/…
intitni Jun 22, 2023
35d3895
Add completionPanel to XcodeAppInstanceInspector
intitni Jun 22, 2023
0557b54
Say goodbye to comment mode
intitni Jun 22, 2023
fa794b7
Update Xcode inspector observation
intitni Jun 22, 2023
02d1fbb
Remove CommentBaseCommandHandler and RealtimeSuggestionIndicatorContr…
intitni Jun 22, 2023
e5f5600
More on remove comment mode
intitni Jun 22, 2023
ada1289
Support nearby text cursor when completion panel is not visible
intitni Jun 22, 2023
c55fbaa
Support displaying next to the completion panel
intitni Jun 22, 2023
ce262fc
Adjust size
intitni Jun 22, 2023
bea3627
Display inline suggestions in a separate window
intitni Jun 22, 2023
1bbf33f
Merge branch 'feature/inline-suggestion-panel' into hotfix/0.18.3
intitni Jun 23, 2023
8245c31
Update launch agent template
intitni Jun 23, 2023
684cffe
Merge branch 'feature/launch-agent-template' into hotfix/0.18.3
intitni Jun 23, 2023
e5d8152
Fix that the widget will be brought to front when switching spaces
intitni Jun 23, 2023
1f5021d
Merge branch 'feature/hide-from-mission-control' into hotfix/0.18.3
intitni Jun 23, 2023
9d7a735
Bump Codeium version to 1.2.40
intitni Jun 23, 2023
6523133
Merge branch 'feature/codeium-1.2.40' into hotfix/0.18.3
intitni Jun 23, 2023
4f0fd60
Remove unwanted prints
intitni Jun 23, 2023
b6e55d9
Hide nearby cursor suggestion when the line of code is out of frame
intitni Jun 23, 2023
123728d
Add alwaysAcceptSuggestionWithAccessibilityAPI just in case
intitni Jun 23, 2023
2f4dbf1
Update
intitni Jun 23, 2023
aad59b7
Make fullscreenDetector transient
intitni Jun 23, 2023
2e61d39
Merge branch 'feature/make-full-screen-detector-invisible' into hotfi…
intitni Jun 23, 2023
59e64f1
Make fullscreenDetector also invisible
intitni Jun 23, 2023
3fc5ba7
Move suggestion panel window lower in z level
intitni Jun 23, 2023
420191e
Remove the meaningless Task { @MainActor in } in initializer
intitni Jun 23, 2023
fe8e82a
Fix that suggestion panel buttons can't be clicked when completion pa…
intitni Jun 23, 2023
788b197
Fix that widget window was mistakenly hidden is some cases
intitni Jun 23, 2023
9c58fa3
Invalidate suggestion when the current line is empty or space only
intitni Jun 23, 2023
e2389f7
Fix that completion panel change is not observed if Xcode is launched…
intitni Jun 23, 2023
66ccada
Move suggestionWindow up
intitni Jun 23, 2023
5b40449
Invalidate suggestion when the user has type all of them out
intitni Jun 23, 2023
d046df6
Update README.md
intitni Jun 23, 2023
f3964e8
Update appcast.xml
intitni Jun 23, 2023
ccdf016
Merge branch 'hotfix/0.18.3'
intitni Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix that the widget will be brought to front when switching spaces
  • Loading branch information
@intitni
intitni committed Jun 23, 2023
commit e5d8152cb6be71b2f32432f0abea82c1653b2e78
12 changes: 6 additions & 6 deletions Core/Sources/SuggestionWidget/SuggestionWidgetController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public final class SuggestionWidgetController: NSObject {
it.isOpaque = false
it.backgroundColor = .clear
it.level = .init(19)
it.collectionBehavior = [.fullScreenAuxiliary]
it.collectionBehavior = [.fullScreenAuxiliary, .transient]
it.hasShadow = true
it.contentView = NSHostingView(
rootView: WidgetView(
Expand Down Expand Up @@ -72,7 +72,7 @@ public final class SuggestionWidgetController: NSObject {
it.isOpaque = false
it.backgroundColor = .clear
it.level = .init(19)
it.collectionBehavior = [.fullScreenAuxiliary]
it.collectionBehavior = [.fullScreenAuxiliary, .transient]
it.hasShadow = true
it.contentView = NSHostingView(
rootView: TabView(chatWindowViewModel: chatWindowViewModel)
Expand All @@ -93,7 +93,7 @@ public final class SuggestionWidgetController: NSObject {
it.isOpaque = false
it.backgroundColor = .clear
it.level = .init(NSWindow.Level.floating.rawValue + 1)
it.collectionBehavior = [.fullScreenAuxiliary]
it.collectionBehavior = [.fullScreenAuxiliary, .transient]
it.hasShadow = true
it.contentView = NSHostingView(
rootView: SharedPanelView(
Expand All @@ -120,7 +120,7 @@ public final class SuggestionWidgetController: NSObject {
it.isOpaque = false
it.backgroundColor = .clear
it.level = .init(NSWindow.Level.floating.rawValue + 1)
it.collectionBehavior = [.fullScreenAuxiliary]
it.collectionBehavior = [.fullScreenAuxiliary, .transient]
it.hasShadow = true
it.contentView = NSHostingView(
rootView: SuggestionPanelView(
Expand All @@ -147,7 +147,7 @@ public final class SuggestionWidgetController: NSObject {
it.isOpaque = false
it.backgroundColor = .clear
it.level = .floating
it.collectionBehavior = [.fullScreenAuxiliary]
it.collectionBehavior = [.fullScreenAuxiliary, .transient]
it.hasShadow = true
it.contentView = NSHostingView(
rootView: ChatWindowView(viewModel: chatWindowViewModel)
Expand Down Expand Up @@ -240,7 +240,7 @@ public final class SuggestionWidgetController: NSObject {
guard let activeXcode = ActiveApplicationMonitor.activeXcode else { continue }
guard fullscreenDetector.isOnActiveSpace else { continue }
let app = AXUIElementCreateApplication(activeXcode.processIdentifier)
if app.focusedWindow != nil {
if let window = app.focusedWindow, window.isFullScreen {
orderFront()
}
}
Expand Down