Skip to content

[pull] main from intitni:main #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 10 commits into from
Oct 7, 2024
Merged

[pull] main from intitni:main #84

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
50df34c
fixed
RoshanNagaram-eng Oct 4, 2024
779c0da
Removed comments
RoshanNagaram-eng Oct 4, 2024
2291a19
Another fix
RoshanNagaram-eng Oct 4, 2024
edda705
Merge pull request #589 from RoshanNagaram-eng/roshan/fixxocde
intitni Oct 5, 2024
d373a8c
Update to throw instead of returning empty list
intitni Oct 6, 2024
a3dfb3f
Fix a potential crash
intitni Oct 6, 2024
0f70ffc
Fixx trigger menu fallback
intitni Sep 30, 2024
1089530
Bump supported Codeium version
intitni Oct 6, 2024
4235e68
Bump version to 0.34.2
intitni Oct 6, 2024
1fe0874
Merge branch 'hotfix/0.34.2'
intitni Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update to throw instead of returning empty list
  • Loading branch information
@intitni
intitni committed Oct 6, 2024
commit d373a8c0789d847b8e39bcf84e489b263f136684
12 changes: 8 additions & 4 deletions Tool/Sources/SuggestionProvider/SuggestionServiceMiddleware.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ public enum SuggestionServiceMiddlewareContainer {

public struct DisabledLanguageSuggestionServiceMiddleware: SuggestionServiceMiddleware {
public init() {}

struct DisabledLanguageError: Error, LocalizedError {
let language: String
var errorDescription: String? {
"Suggestion service is disabled for \(language)."
}
}

public func getSuggestion(
_ request: SuggestionRequest,
Expand All @@ -55,10 +62,7 @@ public struct DisabledLanguageSuggestionServiceMiddleware: SuggestionServiceMidd
if UserDefaults.shared.value(for: \.suggestionFeatureDisabledLanguageList)
.contains(where: { $0 == language.rawValue })
{
#if DEBUG
Logger.service.info("Suggestion service is disabled for \(language).")
#endif
return []
throw DisabledLanguageError(language: language.rawValue)
}

return try await next(request)
Expand Down